Commit Graph

22923 Commits

Author SHA1 Message Date
TreeHugger Robot cba7f50947 Merge "Validate pointer index in PagedView#onMotionEvent" into ub-launcher3-rvc-dev 2020-05-27 05:03:38 +00:00
Vinit Nayak 93bf1fe1f0 Validate pointer index in PagedView#onMotionEvent
Fixes: 157400422
Change-Id: I556e2e05323ec7f0a47a8a8e3321b8196ee77bcc
2020-05-26 17:22:13 -07:00
Tracy Zhou b1eeeafa6f Merge "Permission protect GridOptionsProvider" into ub-launcher3-rvc-dev 2020-05-26 22:36:37 +00:00
Tony Wickham c093b25c75 Use splitscreen insets for multiwindow, else use thumbnail insets
This is consistent with what we do for the right/bottom clipped
insets already, and fixes cases where the device insets don't
match the thumbnail insets (e.g. for fullscreen apps).

Bug: 157097544
Change-Id: I25216fef0d804704e7c7bd84316f932767c2f110
2020-05-26 16:55:58 -05:00
TreeHugger Robot 0bef6c937a Merge "Fix NPE when recents animation controller is null" into ub-launcher3-rvc-dev 2020-05-26 18:48:42 +00:00
Tony Wickham a47a8f1b1d Fix NPE when recents animation controller is null
If it's null, that means the animation was already canceled or
finished, so we don't need to finish it anyway.

Bug: 157383670
Change-Id: I9b0dde76d5756536d8d97bc3d7f13723f903a79c
2020-05-26 13:05:29 -05:00
Tracy Zhou c6f3b4d0c7 Permission protect GridOptionsProvider
Fixes: 152004429
Test: Manual
Change-Id: I2576322b68b128acf28536a5e37a9853ac9d03c3
2020-05-23 01:24:25 -07:00
TreeHugger Robot 69d772633d Merge "Import translations. DO NOT MERGE" into ub-launcher3-rvc-dev 2020-05-22 23:23:03 +00:00
TreeHugger Robot 667ebafdfa Merge "Import translations. DO NOT MERGE" into ub-launcher3-rvc-dev 2020-05-22 23:22:07 +00:00
Bill Yi 2a5d15c182 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I0391eda3ce9c7d9b9f90de359b5cf0b0363c0d00
2020-05-22 23:09:44 +00:00
Bill Yi 5051db820b Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I37782ef5afd3cf3606bef863f14731996ae9e0c9
2020-05-22 23:09:02 +00:00
Vinit Nayak 5d835bcdaa Enable RotationWatcher when home rotation is on
Update the PagedOrientationHandler when launcher
is allowed to rotate to ensure the correct one
gets set.

Fixes: 157173248
Change-Id: Iffb9df479fcccfb0fe2bd462167242b592949f69
2020-05-21 16:13:27 -07:00
Vinit Nayak c217c72bcc Merge "Maintain fake nav bar position in overview for landscape" into ub-launcher3-rvc-dev 2020-05-21 20:59:25 +00:00
TreeHugger Robot 1152e4526d Merge "Adding a method checking whether Overview has tasks" into ub-launcher3-rvc-dev 2020-05-21 20:47:31 +00:00
TreeHugger Robot 9eae863216 Merge "Insert delays in dumping input state" into ub-launcher3-rvc-dev 2020-05-21 20:39:29 +00:00
TreeHugger Robot bfe7b44a91 Merge "Checking success of injectInputEvent" into ub-launcher3-rvc-dev 2020-05-21 20:29:34 +00:00
vadimt e238271384 Adding a method checking whether Overview has tasks
Change-Id: I9817218990c470ad7f266e336d931e2cd313535e
2020-05-21 13:11:42 -07:00
vadimt f5e98ead9d Insert delays in dumping input state
Hpoing to avoid overwhelming logcat

Bug: 156287114
Change-Id: Ia0e95ade205a2c5cd6d7a27b59c9896fb78370af
2020-05-21 12:42:32 -07:00
vadimt 623670c2e3 Checking success of injectInputEvent
Bug: 156287114
Change-Id: Id000b39a187c909475dd6dd409d14430b3654517
2020-05-21 12:32:33 -07:00
Vinit Nayak c609421f2a Maintain fake nav bar position in overview for landscape
NavBar defaults to display when quickswitch ends,
which is always portrait since home is now always
in portrait. We keep the same nav region that the
user used to swipe up to enter recents and reset once
they swipe to home.

Fixes: 156053957
Test: Swipe up from landscape app, then swipe up
from the same nav bar region to go home.

Change-Id: Ia4cf8172850b991aa5e145897622be3b2afa3779
2020-05-21 11:24:16 -07:00
Vadim Tryshev 2c75d08806 Merge "Failing with diags when UiObject2 container disappears" into ub-launcher3-rvc-dev 2020-05-21 17:53:03 +00:00
Tony Wickham 17312c3566 Keep recents attached to app window on continued switching
- LAST_TASK now has recentsAttachedToAppWindow = true, to match
  NEW_TASK. Though this does mean there's a small chance of
  seeing recents translating in if you swipe up and back down,
  this is preferable to seeing recents translate away if you
  swipe right and back left in two consecutive gestures.
- Until passing the touch slop for a new gesture, keep recents
  attached to the app window. This avoids cases where you
  could have recents view translate away mid-gesture, such as
  in the following case: swipe from A to B, swipe from B back
  to A, touch down during the transition back to A. Before this
  change, you would see recents translate away; with this
  change, recents instead stays in place until we get another
  signal indicating it should detach, such as swiping to home.

Bug: 157153404
Change-Id: I63a3a8b988af1aac5177f101b0b75e73e56b1ceb
2020-05-21 00:55:54 -05:00
Sreyas 1e2457743b Logging to debug Overview Actions not working.
Change-Id: Ic5571ce0c02296415f24413403cbdf62fa9b4594
2020-05-20 17:53:48 -07:00
vadimt 8a8255916f Failing with diags when UiObject2 container disappears
Change-Id: If6af49087a5afd6374776e55067b0502dabb7585
2020-05-20 15:05:49 -07:00
Tony Wickham c7c883a880 Update some TouchInteractionService logs
- Move "finishRecentsAnimation" for NEW_TASK to where we actally
  finish the controller after onTaskAppeared()
- Add "setEndTarget" and "onSettledOnEndTarget" logs

Bug: 156412706
Change-Id: I0a0f81d3b601fc1eed72b372235bbb92368ec246
2020-05-20 14:30:31 -05:00
Jon Miranda 517cec5344 Add all apps education tutorial.
* Added FeatureFlag.ENABLE_ALL_APPS_EDU
* When user swipes up on nav bar three times and goes to hint state
  consecutively, we show the new All Apps education tutorial.
* For now we block interaction while the animation is playing,
  and we remove the view when the animation is done.
* Future CL will leave view up until user successfully reaches All Apps state.

Bug: 151768994
Change-Id: I903e0a3914d0558950ecb8cd714d97ddc10ca06b
2020-05-20 11:44:23 -07:00
Adam Cohen 0a1cefa497 Merge "Delegate horizontal scrolls from the Hotseat to the Workspace" into ub-launcher3-rvc-dev 2020-05-20 16:08:23 +00:00
TreeHugger Robot 6928c3bc05 Merge "Unifying swipe handling for fallback launcher" into ub-launcher3-rvc-dev 2020-05-20 05:32:36 +00:00
TreeHugger Robot 764f67e967 Merge "Re-enable app long-press menu on Go devices" into ub-launcher3-rvc-dev 2020-05-20 02:43:38 +00:00
Sunny Goyal 672d02cd39 Unifying swipe handling for fallback launcher
Previosuly we had a different swipe handler for 3P Launcher which
started either recents or Launcher based on the initial interaction
(horizontal or vertical). This was primarily because we had to wait
for recents transition to finish before starting another activity
which could delay going to home.

Now we always start recents transition to recentsActivity. This allows
us to use the same swipe handling logic as QuickstepLauncher. Home
activity can be started while recents transition is running and can be
controlled using onTaskAppeared callback.

Bug: 156924169
Bug: 156398988
Bug: 156295255
Change-Id: Ib9f02e0281e8d674bde2f4a81eca5fc8a5962144
2020-05-19 19:41:30 -07:00
TreeHugger Robot c475f28b4f Merge "Fix weird split-screen secondary task animation" into ub-launcher3-rvc-dev 2020-05-20 01:57:15 +00:00
TreeHugger Robot a41f9dcbe9 Merge "More logging for swiping to Overview instead of All Apps" into ub-launcher3-rvc-dev 2020-05-19 21:04:20 +00:00
Vinit Nayak a8f083b581 Merge "Increase overview thumbnail size for 2 button landscape." into ub-launcher3-rvc-dev 2020-05-19 20:49:08 +00:00
vadimt f95cfce267 More logging for swiping to Overview instead of All Apps
Bug: 156095088
Change-Id: Ia4d59b43225c7652cfc0ae72c05a5477deeb842b
2020-05-19 12:49:17 -07:00
Vinit Nayak 88830c0657 Increase overview thumbnail size for 2 button landscape.
With shelf hidden in 2 button landscape, need to fill
in the extra space w/ larger thumbnail.

Fixes: 156442623
Test: Larger thumbnail shows up in 2 button landscape
Change-Id: Ie2856c8d248b28ae7c06cbe40c7417a827c2bd96
2020-05-19 12:07:37 -07:00
Ming-Shin Lu ce7eec0bbd Fix weird split-screen secondary task animation
As CL[1] corrects the screenBounds of remote animation target,
and we are now using RemoteAnimationTarget#localBounds to offect the
position.

Remove the offset logics in AppWindowAnimationHelper#updateSourceStack,
and TaskViewSimulator#setPreview, then refine computeSurfaceParams
with offseting the position of HOME task by localBounds.

[1]: I793f01fb290fe65af1bbf8e29e429fbca63ac255

Fix: 153581126
Test: manual as below steps:
     1) Launch a app, swipe up to overview screen.
     2) Tap app icon and pressing "Split screen" item.
     3) After entered split-screen mode, taps the task view.
     4) Make sure the secondary task animation the movement is
        correct and smoothly.

Change-Id: I0e4ed1465e80f48336908813ac694fb3aaa3c347
2020-05-19 17:07:47 +00:00
Jon Spivack 5efa076dae Re-enable app long-press menu on Go devices
Deep shortcuts and the home-screen Widgets menu were removed from Go in b/112904271. Subsequently removing the entire app long-press menu, however, may have been unintended behavior. This re-enables that menu, which currently houses the App Info system shortcut.

Bug: 156120551
Test: Manual
Change-Id: Ifa0befe1896315b5ed905271c2cf4805f70c39c0
2020-05-18 20:23:28 -07:00
thiruram 6bf6848951 Introduces CONTAINER_WIDGETS_TRAY to LauncherSettings.Favorites.
This would log LAUNCHER_ITEM_DRAG_STARTED event when an item is dragged from widgets tray. This also fixes empty component with widget logs.

Sample Log: https://docs.google.com/document/d/1CBP2yTcXdFhPdNG5ZmWFKSgd8mDbMevY-akVlUXPLDo/edit#bookmark=id.bk5w3n8uwhcl

Bug: 152978018
Change-Id: I51d16edae13973d5e62adda0e4efa861fa10dc1b
2020-05-18 16:44:46 -07:00
Vinit Nayak 4ae95beb9b Merge "Override Rect#contains() to include bottom right" into ub-launcher3-rvc-dev 2020-05-18 22:21:55 +00:00
TreeHugger Robot 7cdb4cfecc Merge "Rename closeEvents to reduce confusion" into ub-launcher3-rvc-dev 2020-05-18 21:21:14 +00:00
TreeHugger Robot d5315f8c29 Merge "Using taskView simulator for animation a task to recentsView" into ub-launcher3-rvc-dev 2020-05-18 19:02:30 +00:00
TreeHugger Robot e5a83db490 Merge "Remove tracing for a fixed flake" into ub-launcher3-rvc-dev 2020-05-18 17:21:41 +00:00
vadimt 2bba25a08d Remove tracing for a fixed flake
Bug: 155926212
Change-Id: Ia847d735d58154bc768b69d3ae3dc0af7fcdbf11
2020-05-18 16:34:57 +00:00
Vinit Nayak 08619f8600 Merge "Hide shelf in 2-Button Landscape" into ub-launcher3-rvc-dev 2020-05-17 23:32:00 +00:00
Vinit Nayak 23681083b2 Hide shelf in 2-Button Landscape
Disable overview rotation in 2-Button.

Fixes: 154181816
Test: Tested no button and 2 button,
overview actions worked as before.

Change-Id: Ic22c791c7a93460840d54aaf0bf32884cc110e19
2020-05-17 15:17:11 -07:00
Adam Cohen b66675a36d Delegate horizontal scrolls from the Hotseat to the Workspace
=> Before this change, scrolling horizontally on the the hotseat area was a no-op
=> This is a mild usability issue (or arguably WAI) for the default grid, but for larger grids it feels really broken as you have to reach very high just to scroll to another page.

issue 156507399

Test: manual. Also verified that swipe up still works and goes through the same code path.

Change-Id: I760aca473dd36bc8cfb906cb58e897e2ab7fd1d9
2020-05-15 16:57:37 -07:00
TreeHugger Robot 04f476dcb0 Merge "Log last appeared task id instead of target" into ub-launcher3-rvc-dev 2020-05-15 22:22:43 +00:00
thiruram 2e7f24c118 Rename @LauncherUiEvent to @UiEvent to be consistent with other UiEvents.
Change-Id: I049a238f717cc2a6b0bbb4755794bc4de2935b97
2020-05-15 21:42:46 +00:00
Tony Wickham 39f2f1029b Log last appeared task id instead of target
Might be slightly more useful (e.g. if we
need to compare against last started task id)

Change-Id: I3617be270bec6841fbd943e681de78ada549ff84
2020-05-15 16:32:04 -05:00
Sunny Goyal b9abae9f0f Using taskView simulator for animation a task to recentsView
Also applying transform params in DeviceLockedInputConsumer directly
instead of going through AppWindowAnimationHelper

Bug: 156398988
Bug: 155816922
Change-Id: I791e1a9feb07c4fb787130f8d040a4f404faf734
2020-05-15 14:07:29 -07:00