Commit Graph

3742 Commits

Author SHA1 Message Date
TreeHugger Robot 662796d18b Merge "Fix quick switching to any task that already appeared" into ub-launcher3-rvc-dev 2020-06-12 05:22:44 +00:00
TreeHugger Robot 4aef742314 Merge "Reduce launcher logs in bugreports" into ub-launcher3-rvc-dev 2020-06-11 22:41:39 +00:00
Samuel Fufa 852145c9b5 Reduce launcher logs in bugreports
Bug: 158216867
Test: Manual
Change-Id: I068550f2c0b233d5c7a6c4685efb36b62ced5dde
2020-06-11 15:02:58 -07:00
Samuel Fufa 6fd62fde91 Migrate Hotseat logging to WW
Bug: 158218197
Change-Id: I77743b78593f169ffc30f91ab9963052417dac23
2020-06-11 09:27:36 -07:00
TreeHugger Robot bb58efabc8 Merge "Remove unused HomeRotatedPageHandler" into ub-launcher3-rvc-dev 2020-06-11 03:10:13 +00:00
Vinit Nayak 84f30b213a Remove unused HomeRotatedPageHandler
Transfer functionality of choosing
task menu layout to PortraitPageHandler,
which is what it should have been to
begin with.

Fixes: 158484000
Change-Id: Iadda53e7e1f796c063a111823f7f6278f3fdbf58
2020-06-10 18:47:05 -07:00
TreeHugger Robot 743e25e2d2 Merge "Show discovery tip for hybrid hotseat" into ub-launcher3-rvc-dev 2020-06-10 23:22:14 +00:00
TreeHugger Robot ca5e9cb7ef Merge "Notify SysUi on device rotation for back gesture" into ub-launcher3-rvc-dev 2020-06-10 23:14:06 +00:00
TreeHugger Robot 97c399aa9f Merge "[Overview Actions] Add actions to the task menu for in-place landscape." into ub-launcher3-rvc-dev 2020-06-10 23:08:36 +00:00
Sreyas Rangaraju 9a391afbf1 Merge "Fix Task Icon menu behavior." into ub-launcher3-rvc-dev 2020-06-10 22:47:28 +00:00
Samuel Fufa 5b2da14e72 Show discovery tip for hybrid hotseat
Doc: go/hybrid-hotseat-tips

Issue 157683315: for fully populated hotseat, count returns to home screen and show discovery tip if Tip action was not tapped.
Issue 158301717: Don't use cached items if client has predicted items.

Test: Manual
Change-Id: I4747a1148caa62a6262fb6592d5185bdf216ede6
2020-06-10 15:12:55 -07:00
Becky Qiu 849622f6cb [Overview Actions] Add actions to the task menu for in-place landscape.
Test: local
Bug: 153736749
Change-Id: I9ba5a089e434e75de7d9cc29ebd303f7a1388324
2020-06-10 15:04:56 -07:00
thiruram ba0a6b61a3 Log folder open event into WW.
Bug: 158597506

Sample Log: https://paste.googleplex.com/5351626992779264

Change-Id: Ifb2f061924035abc84472a9a03d1b4212588428b
2020-06-10 15:00:19 -07:00
TreeHugger Robot 16823c2c03 Merge "Set qsb fade interpolator same as workspace for home <-> overview" into ub-launcher3-rvc-dev 2020-06-10 21:45:41 +00:00
thiruram 18c2495b8f Adds PredictedHotseatContainer to launcher_atom.proto
Used for differentiating logs from normal hotseat and predicted hotseat.

Bug: 158218197
Change-Id: I011ff724ea0916b32f680dc24e8d6090d3df766d
2020-06-10 10:44:58 -07:00
TreeHugger Robot 4e975109bb Merge "Decrease predicted icon outline size" into ub-launcher3-rvc-dev 2020-06-10 17:06:48 +00:00
TreeHugger Robot 179880c0f6 Merge "Relaunch app that is restarted mid-gesture" into ub-launcher3-rvc-dev 2020-06-10 06:53:50 +00:00
Winson Chung 7d7864e89a Relaunch app that is restarted mid-gesture
Bug: 156692295
Test: Swipe up from an app that has a HUN and ensure tapping on the
      HUN (or anything that can restart the activity) will start the
      activity while the recents animation is still running
Change-Id: Ia1fbd9cfb21aa64b3c8a0d431ba2d9824ee4c0a1
2020-06-09 23:10:13 -07:00
Sreyas b64b59d025 Fix Task Icon menu behavior.
Tapping task icon will now show the scrim for rest of thumbnail and not snap to page that is already snapped to.
Pressing task icon from clear all will scroll to the page.
Link: https://drive.google.com/file/d/1I90rd6ELPZNIje2_VZ3CamWWeFN8ywhL/view?usp=sharing

Bug: 158004853
Change-Id: I9ac8229a603190ea09a74e1cfb70a6bb6e1e65b7
2020-06-09 21:10:46 -07:00
thiruram 236f40d97e Update StatsLogManager to support ranking related events.
Change-Id: I238f00a782a620f704005d37c8972b5e25610c75
2020-06-10 02:47:58 +00:00
Becky Qiu 23986e9a84 Revert "Fix Task Icon menu behavior."
This reverts commit 6df0148b07.

Reason for revert: breaks the task icon behavior.

Change-Id: I6f654478e0ffe7827efeca1553622dad2e02c5da
2020-06-10 00:20:49 +00:00
TreeHugger Robot 8984fea211 Merge "Apply PendingAnimation#mDuration to all added anims" into ub-launcher3-rvc-dev 2020-06-10 00:18:31 +00:00
Tony Wickham fe54c36822 Apply PendingAnimation#mDuration to all added anims
Doing this at the root instead of individually for all added
animators ensures none fall through the cracks.

Fixes: shelf moving too quickly in 2 button mode
Change-Id: I0de1ba9cee3fb8f1d6161371625d97e4b2305129
2020-06-09 18:35:07 -05:00
Vinit Nayak 92364cdc74 Remove rotation flag check
There's a race condition between when
the flag is read and when it gets set,
and not registering the listener that
the flag is gating can result in a lot
of bad rotation state.

Fixes: 158592847
Change-Id: Idd78e15669698bb0d057d0b6661ea69bfa5c8202
2020-06-09 22:55:07 +00:00
Samuel Fufa 39912270e5 Decrease predicted icon outline size
Bug: 156781454
Change-Id: Id9e1fbb47dbb5c18a41f466b9f3963f93ab6f509
2020-06-09 14:02:48 -07:00
Zak Cohen e246f191de Merge "Overview Actions - use scaled insets for screenshot transition." into ub-launcher3-rvc-dev 2020-06-09 20:36:12 +00:00
Tony Wickham 5e957551be Fix quick switching to any task that already appeared
Previously we did this for the last task that appeared, but didn't
take into account cases where multiple tasks had appeared during
the same gesture state. We handle that now.

Test:
- Quick switch to delayed task A, start new gesture, return to the
  first app after onTaskAppeared(A)
- Quick switch to delayed task A, start new gesture, wait for
  onTaskAppeared(A), then switch to delayed task B, start new
  gesture, wait for onTaskAppeared(B), and switch back to A
- Quick switch to delayed task A, start new gesture, wait for
  onTaskAppeared(A), then switch to delayed task B, start new
  gesture, wait for onTaskAppeared(B), and switch back to A and
  quickly back to original app (before settling on A)
Ensure task starts/resumes and is interactable in all cases.

Bug: 158588954
Change-Id: I647a6d015baa1d9b6d613e6c0e584589f35da54a
2020-06-09 15:07:16 -05:00
Hyunyoung Song 3b1786ce77 Merge "Add FolderInfo label source / Add instance id to snapshot logging" into ub-launcher3-rvc-dev 2020-06-09 18:26:07 +00:00
TreeHugger Robot fd4e7a8907 Merge "Fix bug where scrim did not fade in during staggered workspace animation." into ub-launcher3-rvc-dev 2020-06-09 17:13:50 +00:00
TreeHugger Robot 1a14978809 Merge "Remove debug logs for b/153821199" into ub-launcher3-rvc-dev 2020-06-09 17:00:35 +00:00
Vadim Tryshev 694e27a413 Merge "Workaround for an activity leak" into ub-launcher3-rvc-dev 2020-06-09 16:35:18 +00:00
Jon Miranda f42fe856a6 Remove debug logs for b/153821199
Bug: 153821199
Change-Id: If8996162d1ab48147abd97a27c2ad163696822d7
2020-06-09 08:14:19 -07:00
TreeHugger Robot 726c781625 Merge "Fix Task Icon menu behavior." into ub-launcher3-rvc-dev 2020-06-09 07:17:47 +00:00
Jon Miranda 36918c3e12 Fix bug where scrim did not fade in during staggered workspace animation.
The problem is that in prepareToAnimate, we set the scrim sysUiProgress to 1.

When we call setScrim(Background) we create an animator to set sysUiProgress
to 0 with a duration of 0. We expect this to set sysUiProgress to 0 prior
to the next animation setScrirm(Normal).

When we call setScrim(Normal) we want to animate sysUiProgress to 1, but it
is still 1 since we haven't actually run the setScrim(Background) animation
(we've only added it to the list of animators). Therefore we don't create an
animator at all since the target is already at the final value.

Bug: 158148281
Change-Id: I8ca7ef00fc8a7dad6813c285ead60f5db15939b6
2020-06-08 21:51:51 -07:00
Sreyas 6df0148b07 Fix Task Icon menu behavior.
Tapping task icon will now show the scrim for rest of thumbnail and not snap to page that is already snapped to.
Pressing task icon from clear all will scroll to the page.

Bug: 158004853
Change-Id: I79d0a4ac5be3641c6bdf71c34dcbf136ddbbebd1
2020-06-08 18:55:52 -07:00
Hyunyoung Song 90c5873f50 Add FolderInfo label source / Add instance id to snapshot logging
Bug: 155719741
Change-Id: I6611d67bc7a940b6e7cf80ec788406c9f2499318
2020-06-08 17:48:51 -07:00
Zak Cohen 62c4711b0e Overview Actions - use scaled insets for screenshot transition.
The actual task insets aren't used for display, so to make the
transition line up, use scaled ones.

Bug: 154524544
Test: local

Change-Id: I0f484e6dbf13a558c042f84aa68f1d6e9c23b328
2020-06-09 00:07:54 +00:00
Tony Wickham ff85415865 Set qsb fade interpolator same as workspace for home <-> overview
Test: go to overview from home and vice versa in 0 and 3 button modes,
ensure QSB fades at the same rate as the rest of workspace

Bug: 154637581
Change-Id: I2f15aaf2ba59e6b1d4754060e7b3005bed5db9c7
2020-06-08 18:43:35 -05:00
TreeHugger Robot 4994b333d9 Merge "Fix display changed flag check optimization" into ub-launcher3-rvc-dev 2020-06-08 23:26:12 +00:00
Vinit Nayak 358a3bd2a2 Fix display changed flag check optimization
Seeing bugs come in where display rotation value
is incorrect, correcting the check to only
exclude frame rate change flags since multiple
bits can be set.

Fixes: 158383147
Change-Id: If6cdd2c10bf80024ac655451b957034ed84684a7
2020-06-08 22:23:51 +00:00
vadimt 454de304d0 Workaround for an activity leak
We were told that showing NexusLauncherActivity should suppress the
leak.

Bug: 157099707
Change-Id: I9988ac4a20609e5b25ddc4a90bedf891d45e69da
2020-06-08 15:16:15 -07:00
Becky Qiu 70ff0c1144 Revert "Revert "[Overview Actions] UI update for Landscape.""
This reverts commit 4dfcbec512.

Reason for revert: Fix the margin issue by handling the bottom
insets ourselves.

Change-Id: Ic01cadbbe847e419af8bb444ad57764e719152c3
2020-06-08 21:18:18 +00:00
Jonathan Miranda ee4a2fe698 Merge "Add westworld logging when user reaches All Apps education view." into ub-launcher3-rvc-dev 2020-06-08 20:49:26 +00:00
Vinit Nayak 80303ac4b9 Notify SysUi on device rotation for back gesture
Whenever device rotates, we notify sysui to hide/show
the back gesture if the foreground app also rotates.
We also notify sysui when device rotates to match
the orientation of the current foreground app (this
is for apps with fixed rotations).

Fixes: 154580671
Test: Created test apps of different rotations
and ensured that back functionality was present when
attempting to go back.

Change-Id: I33a71698411d9bc2416b6660f8dbd53233628917
2020-06-08 12:32:32 -07:00
Jon Miranda 472b5d5298 Add westworld logging when user reaches All Apps education view.
Bug: 158333305
Change-Id: I324979640ead3670f4edc57fd61eba2585d33628
2020-06-08 10:27:54 -07:00
Winson Chung db087d3c98 Merge "Ensure that the default fullscreen params have a corner radius" into ub-launcher3-rvc-dev 2020-06-08 16:30:35 +00:00
Vinit Nayak f6858198b9 Merge "Set overview orientation for all nav modes" into ub-launcher3-rvc-dev 2020-06-07 01:56:19 +00:00
TreeHugger Robot f7c768c7db Merge "Disabled app icon Visuals" into ub-launcher3-rvc-dev 2020-06-06 18:58:15 +00:00
Vinit Nayak e03ad7ede2 Set overview orientation for all nav modes
3 Button overview orientation wasn't
getting set, but working because of the sensor.
Now we set orientation when entering overview,
and reset to rotation 0 when exiting overview.
Also fix related bug in RecentsOriented state
where we weren't updating the current sensor
rotation with foreground app orientation.

Fixes: 157069195
Change-Id: Ide1b7dbeb68aeaf6a3c45f7260595f69f4813d94
2020-06-05 20:36:27 -07:00
Samuel Fufa 61bc63a6a4 Disabled app icon Visuals
Bug: 154855908
Test: Manual
Change-Id: I58c75ed51426ceb4a09b608ee77636c803955025
2020-06-05 17:35:00 -07:00