Commit Graph

82 Commits

Author SHA1 Message Date
Hyunyoung Song 95786e077d Good riddance UserEventDispatcher
Bug: 165675920
Bug: 161381246

TL;DR;;
- nano -> lite proto
- add all the missing logs to WW
- pin item related logging fix
- Removed logging for assistant

sgrep "com.android.launcher3.userevent.nano." | cut -f1 -d: | xargs sed -i -e 's/userevent\.nano\./userevent\./g'

Change-Id: Ie2a49fdd891cacbd7ef40a1dc9e41ff0574c7517
2020-09-27 13:41:49 -07:00
Sunny Goyal 852537fd98 Using StatsLog for notifyingAppPredictor
> Adding a listener in StartsLogManager for listening to events.
  This allows events to be directored to the predictor only if
  it is already running, instead of creating it.
> Unifying the event format to be same as hotseat predictor

Bug: 160748731
Change-Id: Ib00e6249ff642c030f00bcad5b748255e704d16a
2020-07-16 14:12:15 -07:00
thiruram dbd61d4026 Log query_length & parent_container for actions on search results.
Bug: 154717227
Change-Id: I8e7d725014f60a2fd9a7fe13fce705acbc7623ad
2020-06-22 18:14:12 -07:00
thiruram ec75cbd85a Adds additional folder label states (UNLABELED & EMPTY_LABEL)
UNLABELED -> title==null and EMPTY_LABEL -> title=="". When adding new items for the folder if the folder is in UNLABELED state, auto-labeling will be enabled.
This change also addresses auto-labeling issue due to false edit from UNLABELED to EMPTY.

Bug: 159164315

Change-Id: Ia17cd27b4afb60420dc15c544f544061fc46ad33
2020-06-22 13:24:07 -07:00
Hyunyoung Song 13c2bc7303 LAUNCHER_APP_LAUNCH_TAP should log correctly for icons inside folder
Bug: 137777105

Change-Id: I5c1552481fc1b788ba41c57bfe97f126f55e5b16
2020-06-11 23:51:17 -07:00
thiruram 18c2495b8f Adds PredictedHotseatContainer to launcher_atom.proto
Used for differentiating logs from normal hotseat and predicted hotseat.

Bug: 158218197
Change-Id: I011ff724ea0916b32f680dc24e8d6090d3df766d
2020-06-10 10:44:58 -07:00
Hyunyoung Song 90c5873f50 Add FolderInfo label source / Add instance id to snapshot logging
Bug: 155719741
Change-Id: I6611d67bc7a940b6e7cf80ec788406c9f2499318
2020-06-08 17:48:51 -07:00
Hyunyoung Song f26c7930de Fix double logging for wallpaper settings icon activation
Bug: 137957099

Change-Id: Id95fa026c1e6f177ffbb03e99cc18ef03e9a37b5
2020-06-07 22:03:06 -07:00
thiruram 63bf8eedf9 Add WW log for drag events from longpress popup window.
Bug: 157765763
Sample Log: https://docs.google.com/document/d/1CBP2yTcXdFhPdNG5ZmWFKSgd8mDbMevY-akVlUXPLDo/edit#bookmark=id.368csp9y1pwc

Change-Id: I73024f2c8010e77b6f89829fda64130f54ff81f1
2020-06-01 21:55:25 +00:00
thiruram 62c7b5c8f7 Adds WW logging for QSB search results & all-apps predicted row.
SearchResultContainer represents apps rows displayed within QSB search results for both default scenario(without search term) and actual search result(with search term).

SearchResultContainer is used for both homescreen QSB and all-apps QSB.

Follow up CLs will add searchOrigin and queryLength in SearchResultContainer

Bug: 152978018
Change-Id: Id5f96490686c4141e3e6b2516907ac0505a777e6
2020-05-27 20:29:40 -07:00
thiruram 6bf6848951 Introduces CONTAINER_WIDGETS_TRAY to LauncherSettings.Favorites.
This would log LAUNCHER_ITEM_DRAG_STARTED event when an item is dragged from widgets tray. This also fixes empty component with widget logs.

Sample Log: https://docs.google.com/document/d/1CBP2yTcXdFhPdNG5ZmWFKSgd8mDbMevY-akVlUXPLDo/edit#bookmark=id.bk5w3n8uwhcl

Bug: 152978018
Change-Id: I51d16edae13973d5e62adda0e4efa861fa10dc1b
2020-05-18 16:44:46 -07:00
thiruram f95f152971 Add LAUNCHER_FOLDER_LABEL_CHANGED events for folder label updates.
Sample Logs for all update combinations: https://docs.google.com/document/d/1CBP2yTcXdFhPdNG5ZmWFKSgd8mDbMevY-akVlUXPLDo/edit#bookmark=id.7y1p8n2dz8ge

Bug: 155410872
Bug: 152978018
Change-Id: I296b124b16aa07878f2cf7b74ab91f13b8e6cfbf
2020-05-13 17:36:10 -07:00
thiruram 6524cc7237 Adds LAUNCHER_FOLDER_LABEL_CHANGED event.
Sample Log: https://docs.google.com/document/d/1CBP2yTcXdFhPdNG5ZmWFKSgd8mDbMevY-akVlUXPLDo/edit#bookmark=id.qwjknn6acmx6

Bug: 155410872
Bug: 152978018

Change-Id: Ib7641d3d42a3f4fd002d1dbb36dc4b9ea0f885fc
2020-05-13 18:40:48 +00:00
thiruram 5a01f0ec51 Implements LAUNCHER_ITEM_DROP_FOLDER_CREATED event.
When item is dropped on a existing item resulting in new folder creation, triggers LAUNCHER_ITEM_DROP_FOLDER_CREATED event with details of the destination package.
This change also introduces new FolderIcon item to launcher_atom.proto to represent folder icon.

Screencast and sample logs: https://docs.google.com/document/d/1CBP2yTcXdFhPdNG5ZmWFKSgd8mDbMevY-akVlUXPLDo/edit#bookmark=id.tmbucd1f44qp

Bug: 152978018

Change-Id: Ib4d343ba9075aa8853652f128457c4638541ec59
2020-05-06 17:24:09 -07:00
thiruram f81e8b002a Implement LAUNCHER_ITEM_DRAG_STARTED event.
* Fixes null component issue when ItemInfo object copiedFrom.
* Fixes missing container when item is dragged from hybrid hotseat.

Sample Logs:
2020-04-30 14:09:45.499 30472-30472/com.google.android.apps.nexuslauncher D/StatsLogManager: LAUNCHER_ITEM_DRAG_STARTED
    # com.android.launcher3.logger.LauncherAtom$ItemInfo@260f31f8
    application {
      component_name: "com.android.chrome/com.google.android.apps.chrome.Main"
      package_name: "com.android.chrome"
    }
    container_info {
      workspace {
        grid_x: 2
        grid_y: 2
        page_index: 2
      }
    }
    is_work: false

2020-04-30 14:23:15.230 31320-31320/com.google.android.apps.nexuslauncher D/StatsLogManager: LAUNCHER_ITEM_DRAG_STARTED
    # com.android.launcher3.logger.LauncherAtom$ItemInfo@608f101
    application {
      component_name: "com.google.android.gm/.ConversationListActivityGmail"
      package_name: "com.google.android.gm"
    }
    container_info {
      hotseat {
        index: 1
      }
    }
    is_work: false

Bug: 152978018

Change-Id: I3d3ce213fd2fc6eb5ffb239e048ceb7c0fa88b53
2020-04-30 15:03:43 -07:00
thiruram acbd7ef70f Updates launcher_atom.proto to support consistent logging for launcher containers.
* Updated default of some fields to invalid values. Because when these fields are not actually set on the client, the default values could lead to misinterpretations on the server side.
* Refactored container messages into a separate oneof message to use it on the client side as interface.

Test: Manual (make NexusLauncherDebug -j100)
Bug: 144124838

Change-Id: I2d2ea05e9d7d043682d8ca1a56a238d9d22174bb
2020-04-29 00:55:28 +00:00
thiruram 73d0bb99fd Add new FolderLabelStates to better understand smart folder acceptance rate based on primary suggestion.
Bug: 153358870

Change-Id: I863536f0f2563aab33484d45e9bb518e08a9ebe5
2020-04-06 19:15:13 +00:00
Hyunyoung Song 7ac0ef1cb1 ItemInfo supports lite proto builder (1/n)
Bug: 144953948
Bug: 137777105

The new lite proto builder is used to send two types of logging to statsd
1) Snapshot logging
2) App launch, task launch, task dismiss

Statsd will be connected once platform CL is submitted

Change-Id: If606cee5288fe4bd6c522605ae84eb0f24174f5b
2020-03-31 20:52:36 -07:00
Hyunyoung Song d1efd4ed21 Remove workspace layout logging that used dumpsys
Bug: 144953948
More context: in next CL, migration will happen to StatsLog

Change-Id: If8ace91ceff6daf1a0af5963b538d7e14401e497
2020-03-29 21:03:38 -07:00
Zak Cohen 8f1e00b662 Log proto - add select mode item interaction type.
Test: build locally
Change-Id: I3d296bc17bed91669223182d2ed5cff7af70940f
2020-03-05 15:41:22 -08:00
TreeHugger Robot 9779405023 Merge "[Overview Actions] Add ControlType for overview action buttons." into ub-launcher3-master 2020-02-21 20:36:35 +00:00
Winson Chung d446f98457 Merge "Adding new tracing call from SysUI" into ub-launcher3-master 2020-02-20 06:37:46 +00:00
Winson Chung f3b7246bf2 Adding new tracing call from SysUI
Bug: 144854916
Test: This change is only to ensure the changes build
Change-Id: I62b247b45454861328b6062ed571c854a374aa34
2020-02-20 04:52:07 +00:00
Becky Qiu 4e3eaa5a71 [Overview Actions] Add ControlType for overview action buttons.
Design: go/logging_for_overview_actions

Test:local, logging result: https://paste.googleplex.com/6489148393259008

Bug:139828243

Change-Id: I61fa66f8ec6edae43f6242599f8d4ea8e28d735d
2020-02-19 17:45:06 -08:00
thiruram c1c2bfa7fb Initial draft of smart folder logging to clearcut pipeline.
* Adds additional fields to launcher_log.proto to capture smart folder related information.
* Uses ProtoLite to generate log object using builder pattern and converts to nano version before writing to clearcut. Hence not making drastic change to existing logging pattern.

Change-Id: I89b10da8d4e35e3abc7ddb553046946f91b43445
2020-02-13 13:32:21 -08:00
Samuel Fufa b641ac2a62 Log Hotseat onboarding user actions
+ Resolve notifiaciton dot scale issue

Bug: 147336566
Bug: 148232056
Change-Id: I0120dc183a876fda38f4682425697378c7be20f3
2020-02-12 10:02:53 -08:00
TreeHugger Robot 800aaa0d32 Merge "Not using SIDELOADED_LAUNCHER name" into ub-launcher3-master 2019-12-21 01:45:50 +00:00
vadimt bd28a8ec0c Not using SIDELOADED_LAUNCHER name
It may imply something malicious, while we simply mean a third-party
launcher.

Bug: 79437767
Change-Id: I2e169fda9404ca7a042e40877ed6f4b7d2d723a1
2019-12-13 17:22:48 -08:00
Samuel Fufa 78e7e5fcaa Add boolean to differentiate icons from workprofile
Bug:145825382
Test:Manual
Change-Id: I95e0cfe48b4a397eb54455374f11c7ea14c028f6
2019-12-10 13:33:37 -08:00
Samuel Fufa 866ff00eb3 Add a "Dismiss" option for predicted apps in Launcher
Test: LongPress on a pridicted app to see dismiss options.
Bug:139020180
Change-Id: I877863c65def0d845c0ae2f0987fe7a4f6277565
2019-08-13 23:57:11 +00:00
Alex Mang 68c67540cd Adding query length parameter to protobuf
Bug: 131940434
Change-Id: Iaa7ca520406df882e154db3662a190607eb61b23
2019-05-09 15:13:52 -07:00
Hyunyoung Song fd94cd5498 Add logging for Task Icon interaction
Bug: 129279637
Change-Id: I135bad16015129b3b60bb13e86783d623e504b1b
2019-04-25 11:56:04 -07:00
Winson Chung 41d58f7100 Add launcher logging of back button
Bug: 127848641
Test: adb shell setprop log.tag.UserEvent VERBOSE, then hit back
Change-Id: I020738280d2e51a8a192e577baf48c0b092f22f6
(cherry picked from commit df7d00328c)
2019-04-03 22:41:39 +00:00
Hyunyoung Song ebc5f82ac5 Add logging for assistant gesture
Bug: 129867977
Change-Id: I6254bf06b7352f6076af229a581d4ebdd584a4a1
2019-04-03 12:31:42 -07:00
vadimt c28aa1a197 Adding logging for showing DWB toast
We generate an event upon every invocation of Overview with at least one
DWB toast.

Bug: 123892673
Change-Id: Ia24f4be8e9f0f6ab6d31095b8367b73fb6c8cd7f
2019-03-14 12:22:29 -07:00
Vadim Tryshev 3514a22313 Adding code to open DWP settings of a recent task
Will transition to an API for opening settings if this CL lands:
ag/5338673.

Bug: 118319143
Test: manual test on a prototype
Change-Id: Ia40576e0cd6196bfb0a0e8657916bbadff4c0b59
2018-10-24 13:30:33 -07:00
Vadim Tryshev dc7d25d3e1 Adding SystemShortcut for RemoteAction
Bug: 117888000
Test: manual test with a prototype
Change-Id: I10ed0a8c0237a85af5ac32a7fc68e1f9d2ffc5ba
2018-10-19 14:34:00 -07:00
Hyunyoung Song 956ec4b0e5 Remove device profile dependency from UserEventDispatcher
Bug: 110122682

Change-Id: I31ba61e60e31f1cc84e6d0cf115193e45d9fcfdb
2018-07-11 23:31:01 -07:00
Hyunyoung Song de184a243d Add logging for selected text and split screen
Bug: 79787082

action:LONGPRESS
  Source child:TASK_PREVIEW

action:TAP
  Source child:SPLIT_SCREEN_TARGET


Change-Id: Ica5a3955f092c6678e646b6df76567cdfa3485df
2018-05-25 10:53:39 -07:00
Hyunyoung Song bd6fba9f58 onResume event should be logged (not twice but once)
Bug: 79541772

Change-Id: I5fe1271007e4579e1ec95d51c215ef48d0c6eedd
2018-05-21 12:27:46 -07:00
Vadim Tryshev d0788021f9 Logging Square button presses opening Recents
Examples of traces are in notes.
Using the button for closing Recents is not logged.
Dooble-tap logs only one entry.

Bug: 79437767
Test: logcat
Change-Id: Ic2c50ecc937dd2e9cb4b3a7c7439d77bba9b372c
2018-05-15 14:58:27 -07:00
Hyunyoung Song 018eec6899 Add logging for Onboarding
Bug: 73784423

* Discovery bounce, homescreen, hotseat
UserEvent: action:TIP
UserEvent:  Source child:HOTSEAT id=0 BOUNCE

* Discovery bounce, overview, prediction
UserEvent: action:TIP
UserEvent:  Source child:PREDICTION BOUNCE

* Swipe up from navbar text (visibility, cancel target)
UserEvent: action:TIP
UserEvent:  Source child:TIP SWIPE_UP_TEXT

UserEvent: action:TAP
UserEvent:  Source child:CANCEL_TARGET SWIPE_UP_TEXT

* Quickscrub text (visibility, cancel target)
UserEvent: action:TIP
UserEvent:  Source child:TIP QUICK_SCRUB_TEXT

UserEvent: action:TAP
UserEvent:  Source child:CANCEL_TARGET QUICK_SCRUB_TEXT

* Prediction apps text (visibility, cancel target)
UserEvent: action:TAP
UserEvent:  Source child:TIP PREDICTION_TEXT

UserEvent: action:TAP
UserEvent:  Source child:CANCEL_TARGET PREDICTION_TEXT

Change-Id: I94710b5ed3d00e3599985b154eb660af4a958288
2018-05-15 14:31:07 -07:00
Mehdi Alizadeh bda47cf925 Refactors ButtonDropTarget to add extension data
Also fixes a bug where DeleteDropTarget was logging Remove instead of
Cancel.

Bug: 78793340
Test: Enable verbose logging and manual test
Change-Id: I0f0cfff070eab003ebb745292630bc6ce3243f4d
2018-05-02 14:20:09 -07:00
Hyunyoung Song 63311a2ddc Add user event logging for clear all button
Bug: 72222505

----------------------------------------------
Verified

UserEvent: action:TAP
UserEvent:  Source child:CLEAR_ALL_BUTTON
UserEvent:  Elapsed container 8142 ms, session 11322 ms, action 0 ms
----------------------------------------------
Change-Id: I3ace51c30129728017c5eb198c52ab1bfd94c0ac
2018-04-27 15:54:15 -07:00
Mario Bertschler d2e3c5de56 Adding WEB_APP item type for logging.
Set in LoggerUtils.newItemTarget if instant app

Bug:67049361
Change-Id: I8e99e5c60bf1a2083f898e8978d403138f803276
2018-04-03 21:18:38 +02:00
Hyunyoung Song b3fbc0ba8f Quick step/scrub/switch logging
- state transition happening due to Home and back is handled by
  specifying src target as 'from' container and dst target as the 'to'
  container
- Source and Destination container shows FROM and TO state for SWIPE/FLING
- event.isStateChange = true indicates that an action resulted in
  state transition
- Elapsed container millis is the screen time on the source container

Bug: 70181187

- logcat printout with setprop log.tag.UserEvent VERBOSE
1) State: WORKSPACE -> ALLAPPS
  action:FLING direction=UP
  Source child:HOTSEAT id=0	parent:WORKSPACE id=0
  Destination child:ALLAPPS
  Elapsed container 1225 ms, session 1225 ms, action 0 ms

2) ALLAPPS -> HOMESCREEN
  action:FLING direction=DOWN
  Source child:ALLAPPS	parent:ALLAPPS
  Destination child:WORKSPACE id=0
  Elapsed container 971 ms, session 2197 ms, action 0 ms

3) HOMESCREEN -> OVERVIEW
  action:FLING direction=UP
  Source child:NAVBAR	parent:WORKSPACE id=0
  Destination child:TASKSWITCHER
  Elapsed container 4834 ms, session 4834 ms, action 0 ms

4) OVERVIEW-> ALLAPPS
  action:FLING direction=UP
  Source child:TASK	parent:TASKSWITCHER
  Destination child:ALLAPPS
  Elapsed container 2176 ms, session 7010 ms, action 0 ms

5) ALLAPPS->OVERVIEW
  action:FLING direction=DOWN
  Source child:ALLAPPS	parent:ALLAPPS
  Destination child:TASKSWITCHER
  Elapsed container 3683 ms, session 10693 ms, action 0 ms

6) OVERVIEW-> HOMESCREEN
  action:FLING direction=DOWN
  Source child:TASK	parent:TASKSWITCHER
  Destination child:WORKSPACE id=0
  Elapsed container 2108 ms, session 12801 ms, action 0 ms

7) APPS-> OVERVIEW
  action:FLING direction=UP
  Source child:NAVBAR	parent:APP
  Destination child:TASKSWITCHER
  Elapsed container 104 ms, session 104 ms, action 0 ms

8) Quickscrub: action:DRAGANDDROP Source child: QUICK

9) Quickswitch: action:FLING Source child: QUICK

Change-Id: I5898230859ff600f48a2a873a40b670fe4d39a0d
2018-02-20 22:40:19 -08:00
Hyunyoung Song 7fb3ccc4a5 Log time spent on different UI surfaces
- When swipe happens on worskpace, elapsed container ms is reset
- Fling DOWN is also logged so that we now know how much time was spent on
  all apps screen
- If screen off or power button trigger onPause, log this event.

Bug: 67745115
Change-Id: Ie3a0090c78195a4a028de9935131e9e034dcf48a
2017-10-19 15:15:02 -07:00
Sunny Goyal 2385ebebee Adding support for derivative apps to safely extend LauncherLog proto
Bug: 37676962
Change-Id: I24716070841b41418ac57b8dc367278e3ebdd046
2017-07-20 11:47:11 -07:00
Hyunyoung Song d5a9b57713 Log whether an event happened during landscape mode or not
b/38211234

<sample log>
  action:TAP
  Source child:APP_ICON, packageHash=-1046965711, componentHash=-371608779, intentHash=208792422, grid(4,4), span(1,1), pageIdx=0	parent:WORKSPACE id=0
  Elapsed container 3071 ms session 3071 ms action 0 ms
  isInLandscapeMode true
  isInMultiWindowMode false
</sample log>

Change-Id: I44dfe4e7ee2a41c56a50cc2b507bbbeedc458018
2017-05-16 11:12:43 -07:00
Hyunyoung Song e295acaeb3 Launcher dump proto that will be used for:
$ adb shell dumpsys activity provider com.android.launcher3/com.android.launcher3.LauncherProvider
To see how the proto is filled: go/launcher-proto-dump

b/31772480

Change-Id: I8e0f1e5e38148a3dfeabd2fc057392193b2625dd
(cherry picked from commit 6aa3729e98)
2017-04-04 23:06:30 +00:00