Commit Graph

15576 Commits

Author SHA1 Message Date
Winson Chung 6485766bd1 Merge "Revert "Remove back button when on home screen"" into ub-launcher3-master 2018-02-16 03:04:30 +00:00
Winson Chung 3b26183907 Merge "Revert "Generating fake “to Recents” events for overview NOT from task"" into ub-launcher3-master 2018-02-16 03:04:25 +00:00
Winson Chung 73aa3025c0 Revert "Synchronizing loader preload to avoid launcher getting stuck in loading state,"
This reverts commit a1b4911e26.

Reason for revert: Temporary revert for NL build

Change-Id: I81527681bd00d49e590a99e238f4d57e5a619d16
2018-02-16 02:42:33 +00:00
Winson Chung dd176e65e3 Revert "Remove back button when on home screen"
This reverts commit 663759e444.

Reason for revert: Temporary revert for NL build

Change-Id: I8614ee348e6e9290c0de0dfdf3e24663f220e356
2018-02-16 02:42:26 +00:00
Winson Chung 53daa2cae8 Revert "Generating fake “to Recents” events for overview NOT from task"
This reverts commit d46e428706.

Reason for revert: Temporary revert for NL build

Change-Id: I0bb46d0fc56a12c642a0ea8610e7a86002a21ada
2018-02-16 02:42:00 +00:00
Tony Wickham fa3efe9494 Fix a couple quickscrub issues
- Always launch workspace card if it's focused when quick scrub ends
  - Previously it would get stuck if quick scrub end was called on
    a background thread (since it was trying to touch RecentsView)
  - Prevent user from being able to get to the workspace card if
    starting quick scrub from an app by introducing bounds checking
- Prevent getting stuck in overview when ending quick scrub
  - There was a race condition where the task wouldn't launch if
    the animation to recents hadn't yet finished. Now there is a
    callback to ensure that launchTask() is always called after.

Bug: 70180755
Change-Id: I3c131011634880a97de8c2935c3ebdab26494b48
2018-02-15 17:21:56 -08:00
TreeHugger Robot cfab8c5ded Merge "Generating fake “to Recents” events for overview NOT from task" into ub-launcher3-master 2018-02-16 00:24:11 +00:00
Vadim Tryshev d46e428706 Generating fake “to Recents” events for overview NOT from task
These records are required by “Transition Delay - Hot Launch From
Recents” test. It doesn’t look at transition times for this event. They
are just a part of its expected sequence of events.

I generate transition delay times as zeroes because no one is looking at
them.

Bug: 72967764
Test: atest google/perf/app-transition/app-transition-from-recents-trace
Change-Id: I4a5b76b95c6c4b54e7fb620951342a3ed8564aed
2018-02-15 16:13:28 -08:00
Winson Chung 748c55bc76 Merge "Prevent rotation during quickscrub gesture." into ub-launcher3-master 2018-02-15 21:58:47 +00:00
Tony Wickham 22a24c1aa2 Merge "Remove back button when on home screen" into ub-launcher3-master 2018-02-15 21:49:26 +00:00
Tony Wickham 663759e444 Remove back button when on home screen
Add OverviewInteractionState to handle setting OverviewInteractionFlags.

Hide back button when in NORMAL state and launcher's window is focused.
Show it when in other states or when launcher's window loses focus.

Change-Id: I35919561b9972789e995f1cc434c23e2afe9e77c
2018-02-15 12:20:16 -08:00
Winson Chung 9004912eaa Prevent rotation during quickscrub gesture.
Bug: 73486148
Change-Id: Ia435608484e49daf93ff4aa675da11ea4f0fd421
2018-02-15 11:35:37 -08:00
Sunny Goyal a1b4911e26 Synchronizing loader preload to avoid launcher getting stuck in loading state,
which could be caused by the following sequence of events

  1) Starts preload => execution moved to background thread
     a) check if loader is running
     ... execution moved to ui thread

  2) Launcher starts
  3) Cancels any running loader and starts a new loader
     .... Execution on background thread
    b) Cancels any running loader and starts a new loader

Synchronizing (3), and [a, b] under same lock would avoid this case
Bug: 73399920

Change-Id: I6b01f797fd6f4a2e5b3c078bb374ad40fcc311c8
2018-02-15 10:31:50 -08:00
Sunny Goyal c36d6eefae Temporarily disabling model preloading
Bug: 73399920
Change-Id: Ia4a93c77a3209c6a9b2baae02a3ee3d6abb693d4
2018-02-14 20:46:31 -08:00
TreeHugger Robot 1672549d9f Merge "Fixing crash when window is not attached" into ub-launcher3-master 2018-02-15 00:28:32 +00:00
Sunny Goyal 1e9da8b5aa Fixing crash when window is not attached
Bug: 72233154
Change-Id: Ibe94f5804be85b0df9180c508e4ae7afe3ba9a1a
2018-02-14 16:17:01 -08:00
Vadim Tryshev 51fc778eea Fixing “Transition Delay - App to Recents” test: the Launcher part
The fix is quite hacky and should be re-done soon. I’m not leaving TODOs
in the code, but I’m tracking the cleanup elsewhere.

We also need a fix in the server to make the test work, but that will be
another CL.

Bug: 72967764
Test: atest google/perf/app-transition/app-transition-to-recents
Change-Id: Ia21c308caa81bd5502f4a4587ae445928f6eca17
2018-02-14 14:48:47 -08:00
TreeHugger Robot 704e6986bb Merge "Setting package to null on launching shortcut if it contains statusflag to support webui." into ub-launcher3-master 2018-02-14 22:16:30 +00:00
Winson Chung 4c021ee1bc Temporarily disable back button deferral of start animation.
Bug: 73356768
Change-Id: I156b0e6db0ac51a325a3a76118ce8efd01e50419
2018-02-14 13:13:41 -08:00
Winson Chung db3a95c956 Reset the interaction handler if it hasn't been recreated.
Bug: 73356768
Change-Id: Ie3236c95cdb8d9ce809bf8651e02d1d803f0b802
2018-02-14 13:06:14 -08:00
Winson Chung ff02cd54d4 Skip updating displacement if handler is already invalidated.
Bug: 73338391
Change-Id: I091e8a682f95631e15b3f2cbe3e281c4f18003b9
2018-02-14 09:16:26 -08:00
TreeHugger Robot f6c65d7e54 Merge "Fixing ANR when using quickscrub from homescreen" into ub-launcher3-master 2018-02-14 01:29:50 +00:00
Sunny Goyal bf6dfc5fa7 Fixing ANR when using quickscrub from homescreen
Change-Id: Id355726f7ec72dc2fd28a3e757355d1143464001
2018-02-13 17:17:48 -08:00
Sunny Goyal 66f2b35320 Adding a utility class to simplify main process initialization.
Change-Id: I796cf758d2a25cf8fd5f9a9b78a7977fd54ca451
2018-02-13 17:08:09 -08:00
TreeHugger Robot a0693d6366 Merge "Defer starting the recents animation when swiping over back button" into ub-launcher3-master 2018-02-14 00:56:32 +00:00
TreeHugger Robot 450d821f48 Merge changes I2130e01c,I3f864ff4 into ub-launcher3-master
* changes:
  Re-enable input consumer to catch touches over window
  Cancel the animation when cleaning up the touch tracking
2018-02-14 00:43:14 +00:00
Winson Chung d56ac2a881 Defer starting the recents animation when swiping over back button
Bug: 73242451
Test: Swipe up over back with suitable launcher build and ensure that we
      don't start the recents animation on touch down

Change-Id: I98314611eaeeabfaa47280157300ea20f0571a61
2018-02-13 16:41:32 -08:00
Winson Chung cc394cdc75 Re-enable input consumer to catch touches over window
- No handler at the moment, it just ignores touches

Change-Id: I2130e01c0515298433b5fbde835dfe97864038c9
2018-02-13 16:31:36 -08:00
Winson Chung c2ef02ee15 Cancel the animation when cleaning up the touch tracking
Bug: 72953248
Test: Add artificial delay and launch home from home button
Change-Id: I3f864ff4e0a90a4c62dbf5fe123bb3e2257c06fa
2018-02-13 16:31:31 -08:00
Jon Miranda 84e2436220 Update widget full sheet / bottom sheet to have top rounded corners.
Bug: 71775241

Change-Id: I11b5adc555f48f44cf8167e8699cae1dfe164736
2018-02-13 16:18:19 -08:00
Jon Miranda 84e71bf964 Enable new opening app transitions for shortcuts.
Platform change: I9a854d43c65c8fa69bf16ccfbed86e8e681a095b

Bug: 70220260
Change-Id: Ic94b6d69c83116c1c21f99a4b2fba94ff62b61b0
2018-02-13 15:36:20 -08:00
Mario Bertschler 8d01cb422d Setting package to null on launching shortcut if it contains
statusflag to support webui.

Bug: 66009310
Change-Id: I37bf15c3779c88489a16f63ed772d460a0bd531c
2018-02-13 14:47:02 -08:00
Tony Wickham d766aadae7 Fix scrolling to first task on swipe up for RTL
Change-Id: I4f316bd6da7e7d370928accb41e1b44a689094af
2018-02-13 12:03:37 -08:00
TreeHugger Robot ba7d129aac Merge "Using paged view for all-apps tabs" into ub-launcher3-master 2018-02-13 18:06:24 +00:00
Sunny Goyal 0bd7f4f2dc Using paged view for all-apps tabs
Bug: 72811152
Change-Id: I0cca426d935f079c923b93fe3d4399f87778fe95
2018-02-13 09:55:29 -08:00
Tony Wickham d91c3f47c1 Merge "Allow quick scrub/switch from minus one" into ub-launcher3-master 2018-02-13 17:51:20 +00:00
Tony Wickham 618a5044cf Allow quick scrub/switch from minus one
Launcher's window doesn't have focus when on minus one. In this case, we
tell the minus one overlay to hide and add a window focused callback to
start quick scrub/switch after launcher regains focus. Since the
transition from minus one takes longer than for launcher to get window
focus, we also defer until the overlay is completely hidden before
starting the quick scrub transition.

Bug: 70180755
Change-Id: Ifcf85aaf1942b51394e68e209b89807fa4007afe
2018-02-13 08:18:57 -08:00
TreeHugger Robot ba747b6f19 Merge "Skip Launcher opening animation if its not in the set of opening apps." into ub-launcher3-master 2018-02-13 01:50:09 +00:00
Tony Wickham aefd062125 Merge "Re-enable quick scrub/switch from launcher" into ub-launcher3-master 2018-02-12 23:58:25 +00:00
Bill Yi 2fd04c2def Import translations. DO NOT MERGE
Change-Id: Ibfab0e5e1709f527c4fa4fcae33522bf47826b25
Auto-generated-cl: translation import
2018-02-12 12:18:27 -08:00
Tony Wickham a066e4434b Re-enable quick scrub/switch from launcher
When we get the onQuickScrubStart() or onQuickSwitch() callbacks, we go
to the overview state with a quicker duration (the same used from apps).
Then we follow the same logic as starting quick scrub/switch from apps
except that we allow you to scrub back to the workspace card.

Bug: 70180755
Change-Id: Iebcdcc4c4ad1e1210e2d1c11e5007c27d3c1eef3
2018-02-12 11:46:40 -08:00
Tony Wickham 62388becd0 Merge "Move window to align with first task during quick scrub" into ub-launcher3-master 2018-02-10 02:02:54 +00:00
Tony Wickham 8cb3002619 Move window to align with first task during quick scrub
Bug: 70180755
Change-Id: I5932462bd1af08ec141518a344c60605b8730d9d
2018-02-09 17:27:40 -08:00
TreeHugger Robot adca2fc1e9 Merge "Fixing workspace card shifted when going to home." into ub-launcher3-master 2018-02-10 00:55:00 +00:00
Sunny Goyal 72289860ee Fixing workspace card shifted when going to home.
When animating the wrospace, we skip the properties if for start and end are same.
But after creating the animation, if the property changes, the final property is
never applied.

Bug: 72257542
Change-Id: Id408c7820476273958e835ae99a3a934ad5a4700
2018-02-09 16:04:44 -08:00
TreeHugger Robot 00092efbdf Merge "Fix bug where two items could occupy same grid cell in hotseat." into ub-launcher3-master 2018-02-09 23:54:40 +00:00
Jon Miranda 23585182cd Fix bug where two items could occupy same grid cell in hotseat.
When long pressing on an app to start, a drag would start on the
Workspace but mDragInfo would not be cleared since onDropCompleted
is not called in this case.

Solution is to set mDragInfo to null in onDragEnd.

Bug: 72206125
Change-Id: I2b9a1563c80e591d946a44f4e949b71f7b423a00
2018-02-09 15:33:37 -08:00
Winson Chung 05a31ede4f Defer launching the quickscrub task until after the page settles
- Tweak the durations to be less laggy
- Add some state logging

Bug: 67957962
Bug: 70180755
Change-Id: Ia0caa5178b3ed976705eb2d973bc00d8f1b9e3ca
2018-02-09 12:43:36 -08:00
Winson Chung 006239bab9 Fix blocking issues re. window transitions and quick scrub
- Clean up the consumer when starting quickscrub/switch in addition to
  motion up
- Defer invalidating the handler until after quickscrub ends
- Ensure that we always finish the remote animation

Bug: 67957962
Bug: 70180755

Change-Id: Id5af5dc9917638f1dfb8e4a04c358aadb19fd67a
2018-02-09 12:42:13 -08:00
Winson Chung 3e803c7a4b Animate the visible task view if launching an app that resolves to the task
Test: Manual, launch app for associated visible task
Change-Id: I7a56553197ad23e1269eb50523eca0ea88898f47
2018-02-09 12:40:10 -08:00