Commit Graph

33171 Commits

Author SHA1 Message Date
Steven Ng 8facf46000 Fix pending restore widget touch issue am: bdffb53843
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15517689

Change-Id: Ie1cd0fccfcb7377853f326e6e0476c3ec08be97a
2021-08-11 23:49:30 +00:00
Steven Ng bdffb53843 Fix pending restore widget touch issue
After http://ag/14980850, we block updateAppWidget until app widget
is restored. However, PendingAppWidgetHostView constructor relies
on updateAppWidget(null) to trigger set listener in getDefaultView().
We should call super.updateAppWidget(null) in the constructor instead.

Test: manual
Bug: 14980850
Change-Id: I30af9778a636af2ad822e7abc152b6f0bfdea1bf
2021-08-11 22:40:06 +01:00
Thales Lima 931bc2a38e navigation: don't run gesture animation if gestures are not enabled
Makes the animation when using 3 button navigation be closer to what we
have in non fallback mode, also fixing the problem when fallback recents
just started and don't have any views.

Fix 194487871
Test: manual with gestures, 2 button and 3 button nav

Change-Id: If3925d6bef1d14f51b86169d06607786972f5f1f
(cherry picked from commit 8d49c4bb29)
2021-08-11 10:26:22 +00:00
Tony Wickham 0b3b2921c3 Don't recreate touch controllers when ending gesture
Test: swipe up to overview from an app and swipe up to dismiss it during the transition
Bug: 189700453
Change-Id: I303696f90dbb236ea93e06d94a3c92d783850fa4
(cherry picked from commit 0e9ecaeea8)
2021-08-10 23:26:33 +00:00
Bill Yi be96e2e3e5 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 8bc9c6355a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15505516

Change-Id: I56065f18ab7ede2373c279263ef8bf6abc53ca98
2021-08-10 19:39:12 +00:00
Bill Yi 8bc9c6355a Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8a0be2eb6ceb321440efdf75d2b8f6232de201fe
2021-08-09 22:32:00 +00:00
Jonathan Miranda dd16ecbc61 Merge "Update extra space allocations for taller devices." into sc-dev 2021-08-05 18:33:56 +00:00
TreeHugger Robot 9d5749fd7f Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-08-05 03:03:29 +00:00
TreeHugger Robot a85c40ebd6 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-08-05 02:53:48 +00:00
Brian Isganitis 200d7634d1 Merge "Fix crash from previewing launcher with unknown wallpaper colors." into sc-dev 2021-08-05 01:08:00 +00:00
Bill Yi 315b29c87e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Id83c1f3b8772c671e8a8836da2435f75d21cf40e
2021-08-04 22:16:53 +00:00
Bill Yi ff049aae0f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8da912b3e7ec23e63a5c1436773cd86b8cb8dffc
2021-08-04 22:14:26 +00:00
Steven Ng 5fc53cbc22 Merge "Don't delete widgets that violate min size requirement" into sc-dev 2021-08-04 20:15:45 +00:00
Jon Miranda a56cb84141 Update extra space allocations for taller devices.
- Take less space from cells
- Distribute some of the empty space above the workspace
- Already confirmed from previous testing that these thresholds
  only affect taller devices

Bug: 194688362
Test: long press on app icons,
      test drag and drop bounds
      test drop target bounds
      test folder opening bounds
      test all grids on taller devices

Change-Id: If90b7663ab4afedca1193bdd73a0ae38a1f25243
2021-08-04 12:00:36 -07:00
Brian Isganitis dafa5040ef Fix crash from previewing launcher with unknown wallpaper colors.
Test: Open wallpaper app with live wallpaper applied should not crash.
Fix: 195246865
Change-Id: Id64de32b35aa7a553daa752438060d7f6822bec8
2021-08-04 18:31:20 +00:00
Steven Ng b269cc5150 Don't delete widgets that violate min size requirement
Test: Manual
Bug: 194766124
Change-Id: I4713e65e27da23d833bb60fb556ae8924a63e305
2021-08-04 11:14:09 +01:00
Tracy Zhou 25399db1e7 Merge "[DO NOT MERGE] Disable live tile in split mode for S" into sc-dev 2021-08-03 21:50:06 +00:00
Tracy Zhou 145bd74749 [DO NOT MERGE] Disable live tile in split mode for S
Recall link: https://recall.googleplex.com/projects/debb8388-5e38-42c5-99ab-20bdfb92d25e/sessions/655af962-b4bd-4dc4-93aa-178852c0d701

Bug: 193991436
Test: enter split screen and swipe up
Change-Id: I7adffcdefb12d225db207542716a436f29df0377
2021-08-03 20:50:27 +00:00
vadimt 21091ada88 Logging to figure out why first dump didn't result in assertion
Bug: 195319692
Test: presubmit
Change-Id: I4a80541a58eb8f630211de4b90836c435f6d41b2
2021-08-03 18:47:35 +00:00
Jonathan Miranda 4a17e66166 Merge "Add more restrictions on whether we increase the hotseat size for tall devices." into sc-dev 2021-07-30 20:37:29 +00:00
Alex Chau e20208e9d1 Merge "Always treat FallbackRecentsView as visible if isInLiveTileMode is true" into sc-dev 2021-07-30 17:53:34 +00:00
Alex Chau fb5ae9060d Always treat FallbackRecentsView as visible if isInLiveTileMode is true
- activity.hasBeenResumed is no longer an accurate indicator after live tile has been introduced, indeed it's always false
- Return recentsView regardless if there is a runningTask as well

Bug: 194286330
Test: In fallback Recents with 3 button, tap overview button from home screen, then tap overview button again. Try combination with back and home button
Change-Id: Ib2775a11f5466abc433763f24192e7bfdcf191a2
(cherry picked from commit 455718e842)
2021-07-30 08:22:03 +00:00
Bill Yi da8bf1142f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I13dab850677f614cab804cae0b3125c93c55eeed
2021-07-30 04:59:15 +00:00
Tracy Zhou dec3330a83 Merge "Clear command queue of OverviewCommandHelper on home tap" into sc-dev 2021-07-29 21:32:22 +00:00
Tracy Zhou 6842315605 Clear command queue of OverviewCommandHelper on home tap
Fixes: 194934483
Test: manual
Change-Id: Id83b341245793c38c305e6ada5581ac4e49527a7
Merged-In: Id83b341245793c38c305e6ada5581ac4e49527a7
2021-07-29 19:09:53 +00:00
Jon Spivack d317f17273 NIU Actions: Change AppTheme to LauncherTheme
Some theme attributes used for the NIU Actions Overview were originally defined in a theme that inherited from LauncherTheme. However, 3rd-party Launchers that also used themes derived from LauncherTheme were unable to access these attributes, leading to crashes when they tried to open the Recents screen on Go devices. Just adding the attributes to LauncherTheme solves this issue.

Bug: 194810415
Test: Manual (tried a couple 3rd-party launchers on Wembley)
Test: m -j RunLauncherGoGoogleRoboTests
Change-Id: I7a2541f2a2ab3b39e0c6cf2fe40a4b096047df70
2021-07-28 19:14:03 -07:00
Jon Miranda 80dda30f49 Add more restrictions on whether we increase the hotseat size for tall devices.
Bug: 194688362
Test: test devices that should not be affected, ensure they are not affected
Change-Id: I0e027354dbafcce30cf616998d2a7bfab516b5de
2021-07-28 14:20:59 -07:00
TreeHugger Robot ce4bdd3561 Merge "Enables Enhanced Smartspace by default." into sc-dev 2021-07-28 00:01:31 +00:00
Andy Wickham 2afb784531 Enables Enhanced Smartspace by default.
Test: MemoryTests.java, manual
Bug: 187428578
Merged-In: Iffc6ae9b79db47d0585486529d2d8dfdf0a24692
Merged-In: I497523aa1be78e4d0890a7a74a1bd08d4ca50f50
Change-Id: I497523aa1be78e4d0890a7a74a1bd08d4ca50f50
2021-07-27 12:34:55 -10:00
TreeHugger Robot 0a5b66af2c Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-07-27 14:39:44 +00:00
Bill Yi 6fc1eae8d0 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia2101dbfa85b65d3de87200f0fbaf5d09c25a7d9
2021-07-27 09:13:26 +00:00
Tracy Zhou 024749a1e0 Merge "Reset current task and dequeue overview commands when recents animation is cancelled" into sc-dev 2021-07-26 21:17:38 +00:00
Tracy Zhou 94e798bac1 Reset current task and dequeue overview commands when recents animation is cancelled
Fixes: 193925362
Test: manual
Change-Id: I792be003e5aabf34324075829d5381cba591892b
2021-07-26 12:17:01 -07:00
TreeHugger Robot aa4c71efa0 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-07-24 05:42:14 +00:00
TreeHugger Robot 19fc9302ba Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-07-24 05:36:43 +00:00
Bill Yi 38e18c295c Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia201032e39017688795dd9082946690e7e77fd45
2021-07-24 03:07:29 +00:00
Bill Yi 818238558a Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I47acd077e560f94d070da5dd2c9b66ac07950e49
2021-07-24 03:05:08 +00:00
TreeHugger Robot 6d9e866669 Merge "Update hotseat sizing for 4x5 grids." into sc-dev 2021-07-23 22:39:48 +00:00
Sunny Goyal e0e64b4851 Merge "Fixing touch events ignored in some cases" into sc-dev 2021-07-23 22:13:35 +00:00
Jonathan Miranda 0c7153bbdf Merge "Add more extra space to hotseat for taller devices." into sc-dev 2021-07-23 21:41:27 +00:00
Jon Miranda 80cddbccb6 Add more extra space to hotseat for taller devices.
Bug: 192520231
Test: manual test on taller devices
Change-Id: I3eccada67f0ba07d01f823c4156f02c3feb97f84
2021-07-23 20:01:16 +00:00
Jon Miranda 069f8c5ac9 Update hotseat sizing for 4x5 grids.
If the qsb bottom margin is smaller than the bottom insets,
we'll fall back to centering the qsb in the available freespace.

Bug: 194435265
Test: 4x5 grid
      multiple devices,
      with: gesture nav enabled
            3 button nav enabled

Merged-In: I9fd4f0da3f2bc9f0b38a621ad1192533260379e3
Change-Id: I711e7d168b80254e73df0d4e1854756d819a705b
2021-07-23 18:47:33 +00:00
TreeHugger Robot 3f062ab8b6 Merge "Folder polish: unbold folder title, ensure icons not cropped in folder." into sc-dev 2021-07-23 18:10:48 +00:00
Jonathan Miranda adeb26b0dc Merge "Update size limits to match spec." into sc-dev 2021-07-23 06:46:27 +00:00
Jon Miranda f33f5b3fc5 Folder polish: unbold folder title, ensure icons not cropped in folder.
- Ensure folder items are scaled to fit within the height/width in 4x5 mode.
- This bug surfaced now since  we increased the icon size.

Bug: 194356039
Test: set display to large, set font to large
Change-Id: Ie360ca67c3c91649a471bce920b2fc6a82fb9661
2021-07-22 17:19:28 -07:00
Jon Miranda e4413cc6ae Update size limits to match spec.
Bug: 194124461
Test: Verified using screnshots over spec
      Only 4x5 grid is affected
      Tested on multiple devices, multiple display options

Change-Id: I301c512e416ed81f6d41f6f0ecbf5994d47d82bf
2021-07-22 16:26:18 -07:00
Sunny Goyal 58e81e5da1 Fixing touch events ignored in some cases
Bug: 160218103
Test: Manual
Change-Id: Ifa71e742451acecd8979a6833a202c6189b4df52
2021-07-22 15:27:43 -07:00
Adam Cohen ed82e0daef Fix widget drop preview outline on 4x5 grids
=> We were not account for mBorderSpacing in the outline calculation
=> This was fine in most cases as this value is 0, but 4x5 appears to be the exception

Bug: 194227752

Test: manual, see video in bug.
Change-Id: Ib590bc142a0f65e75f92ee057f8b4f4b0f81521b
2021-07-22 12:31:21 -07:00
TreeHugger Robot 6a01fe49a5 Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev 2021-07-22 18:53:32 +00:00
Steven Ng a606d344a6 Measure WidgetsFullSheet before estimating the recommended table
size

Issue: The header view height was obtained before any measurement.

Test: On Pixel 5 4x5 gird with Photo widget shown in recommended
      table, make the device in landscape. Then open the full widgets
      picker. The widgets picker can be scrolled. Before this fix,
      scrolling is not possible.
Fix: 194172597
Change-Id: Ib30cf4b95d2ed23ff28f3d24e103f0e919b3a551
2021-07-22 16:08:15 +01:00