Commit Graph

22388 Commits

Author SHA1 Message Date
Jon Miranda ae3efb2232 Fix NPE when closing folder. am: a28e0f474a
Change-Id: I9361391fab78e10e727635c7b27aca97b5698038
2020-04-17 23:15:20 +00:00
Jon Miranda a28e0f474a Fix NPE when closing folder.
There is a race condition where Folder is closing, it unbinds, and then
another call to AbstractFloatingView.closeAllOpenViews tries to close the
Folder again. But since the contents are unbound and removed from the folder,
it produces a NPE.

Bug: 153625271
Change-Id: Ia6c55f15cf7517e26af8f499bc0c1a4828737480
2020-04-17 15:03:33 -07:00
Tony Wickham c6b6432f92 Merge "Remove mPendingCallback from ActivityTracker" into ub-launcher3-rvc-dev am: c09e8fbe9d
Change-Id: Ib2cdfc1fa20b7e71fcacbd6afb655ba76717b52c
2020-04-17 19:55:49 +00:00
Tony Wickham c09e8fbe9d Merge "Remove mPendingCallback from ActivityTracker" into ub-launcher3-rvc-dev 2020-04-17 19:35:49 +00:00
TreeHugger Robot 307d37c0d9 Merge "When dragging down on task, base end displacement on thumbnail" into ub-launcher3-rvc-dev am: e0f58a0f79
Change-Id: I1b79ae998ec8be9005a3af97820d354f434f90a7
2020-04-17 16:49:08 +00:00
TreeHugger Robot e0f58a0f79 Merge "When dragging down on task, base end displacement on thumbnail" into ub-launcher3-rvc-dev 2020-04-17 16:30:32 +00:00
Tony Wickham 0bbdf3a9fd When dragging down on task, base end displacement on thumbnail
TaskView height has a lot of other factors such as icon margin
and actions. Since the thumbnail is what we are dragging to fill
the screen, use its height to determine the progress factor.

Test: swipe down on a task in portrait, landscape, and seascape,
and verify that it follows your finger to the bottom of the
screen. Swiping up also follows your finger for dimiss.

Bug: 151770407
Change-Id: I114a261a06b11f550822178945266cc4a6fd54fe
2020-04-17 10:27:40 -05:00
TreeHugger Robot 88ab1fd87d Merge "Use 87% black instead of 54% for widget text" into ub-launcher3-rvc-dev am: c9fa578444
Change-Id: If5861b21b1ddde7723bdbfda064bd15c6721ee08
2020-04-17 01:08:34 +00:00
TreeHugger Robot c9fa578444 Merge "Use 87% black instead of 54% for widget text" into ub-launcher3-rvc-dev 2020-04-17 00:31:01 +00:00
TreeHugger Robot 83b56aa34b Merge "Simplifies Tutorial fragment layout." into ub-launcher3-rvc-dev am: 71c63c6fda
Change-Id: I0c38ee9db747451b06cf5eedfcf762d917c8a3bb
2020-04-16 23:57:07 +00:00
TreeHugger Robot 71c63c6fda Merge "Simplifies Tutorial fragment layout." into ub-launcher3-rvc-dev 2020-04-16 23:46:25 +00:00
Tony Wickham ab86ab2869 Use 87% black instead of 54% for widget text
This gives sufficient contrast with slightly grey background

Bug: 147275180
Change-Id: I28b25b74c0101665ada14efdd5355c31b0f1b480
2020-04-16 18:32:07 -05:00
TreeHugger Robot a96a0c0978 Merge "Prevent two overlapping long press actions." into ub-launcher3-rvc-dev am: 2a14c83515
Change-Id: Ic94efa35896914bb9f546458ae276d7214df1f24
2020-04-16 22:38:56 +00:00
TreeHugger Robot 2a14c83515 Merge "Prevent two overlapping long press actions." into ub-launcher3-rvc-dev 2020-04-16 22:25:34 +00:00
TreeHugger Robot b16c4ba797 Merge "Cleanup code related to ag/11035582" into ub-launcher3-rvc-dev am: 11e36db88a
Change-Id: I52eb69f1bc54d9896e0470e54e0de541e5731475
2020-04-16 22:11:21 +00:00
TreeHugger Robot 11e36db88a Merge "Cleanup code related to ag/11035582" into ub-launcher3-rvc-dev 2020-04-16 22:04:45 +00:00
TreeHugger Robot 6190a15e61 Merge "Choosing better points to output "start" events for TAPL" into ub-launcher3-rvc-dev am: 64abef8ca1
Change-Id: Ic2cad33d921c71a61d4c00b2a10941760f88864b
2020-04-16 22:03:47 +00:00
TreeHugger Robot 11ac5dc1cf Merge "Removes more Back references for generic tutorial styles." into ub-launcher3-rvc-dev am: 08c6c94398
Change-Id: Ib20d3338544084f92efe766339adc8538c31237c
2020-04-16 22:03:41 +00:00
TreeHugger Robot 920b04bdd2 Merge "Add resume callback to animate back to appropriate depth." into ub-launcher3-rvc-dev am: 74974e802e
Change-Id: I36f309cf90de5d537698d4219be48bc348dca3ee
2020-04-16 22:03:30 +00:00
TreeHugger Robot 64abef8ca1 Merge "Choosing better points to output "start" events for TAPL" into ub-launcher3-rvc-dev 2020-04-16 21:58:47 +00:00
TreeHugger Robot 08c6c94398 Merge "Removes more Back references for generic tutorial styles." into ub-launcher3-rvc-dev 2020-04-16 21:54:18 +00:00
TreeHugger Robot 74974e802e Merge "Add resume callback to animate back to appropriate depth." into ub-launcher3-rvc-dev 2020-04-16 21:47:38 +00:00
Vinit Nayak 916456bb5f Cleanup code related to ag/11035582
Fixes: 154235554
Change-Id: I114d1e1b9e446e15a774a5a51bdf988070091523
2020-04-16 14:16:56 -07:00
Jon Miranda a1567d50d0 Prevent two overlapping long press actions.
We add a check in CheckLongPressHelper to not trigger long press if the
view is already in the pressed state.

This fixes the bug where a stranded DragView is left in the DragLayer.

Repo's every 50 tries:
- Open folder
- Long click and slightly drag the same item over and over in slightly
  different directions.

Logs show that long click on folder item initiates the first long click,
and then later on CheckLongPressHelper triggers another long press before the
initial one is finished.

Bug: 151053858
Change-Id: Ifbb6919e4f0153aaef2904f704baa284e78f1e83
2020-04-16 14:00:50 -07:00
Jonathan Miranda c9e1375ed5 Merge "Add AnimationFlag for SKIP_DEPTH_CONTROLLER." into ub-launcher3-rvc-dev am: a976a2212d
Change-Id: If3b50143c236ea0ba4d01f19bbebbd46839f94cc
2020-04-16 20:23:48 +00:00
Jonathan Miranda a976a2212d Merge "Add AnimationFlag for SKIP_DEPTH_CONTROLLER." into ub-launcher3-rvc-dev 2020-04-16 20:10:05 +00:00
Jon Miranda 172302686c Add resume callback to animate back to appropriate depth.
This fixes the bug where depth gets stuck to 1 after opening a transluscent
activity.

Bug: 152950633
Change-Id: I8bf5f61c57ef79d41656865b1ff1fbadb298fc36
2020-04-16 13:03:48 -07:00
Hyunyoung Song 4fcf088ae0 Merge "Add AllAppsSearchPlugin Bug: 151089843" into ub-launcher3-rvc-dev am: 6dde528c82
Change-Id: I08ad8e8b704a158daf6742c4b2db57ab7b22e287
2020-04-16 19:47:33 +00:00
Andy Wickham 230f390d94 Adds dummy HomeGestureTutorialFragment. am: 4f66dc3bef
Change-Id: Ic5c688ef3bb7551f342d134a2068b1589bc42e4c
2020-04-16 19:47:20 +00:00
Hyunyoung Song 6dde528c82 Merge "Add AllAppsSearchPlugin Bug: 151089843" into ub-launcher3-rvc-dev 2020-04-16 19:45:26 +00:00
Hyunyoung Song 3f82135f06 Add AllAppsSearchPlugin
Bug: 151089843

Change-Id: I6d61fb9c7855bafee731f47147b3070a1b672071
2020-04-16 11:50:04 -07:00
Andy Wickham 4f66dc3bef Adds dummy HomeGestureTutorialFragment.
- Adds a new launch target in Dev options
 - Moves Back handling to the parent TutorialFragment
   (so all Tutorials can handle it as necessary)
 - Currently uses a dummy translating rectangle in
   place of a proper hand animation
 - No actual home gesture recognition is in place yet

Test: Manual
Bug: 148542211
Change-Id: Ic5a545eb9f5003914803272c8ffe367220d63336
2020-04-16 18:23:08 +00:00
Andy Wickham 00e241f82f Simplifies Tutorial fragment layout.
Removes nested LinearLayout and RelativeLayout, as well
as a Space (instead just aligning buttons to the bottom).

Test: Manually verified result looks same as before.

Change-Id: I773079107be5f8862bae68c0f8f5bf6edff79ce8
2020-04-16 18:16:56 +00:00
Andy Wickham ed7c8a41d0 Removes more Back references for generic tutorial styles.
Change-Id: Ie959f897ee19d636eabfd8cbe9a8a2615264d4cf
2020-04-16 18:15:34 +00:00
jayaprakashs 86703b3b49 Don't open the Folder and IME when Folder is created. am: 86932724e7
Change-Id: If166033a3017bcd805adc63292e4aae10d05f923
2020-04-16 09:16:44 +00:00
jayaprakashs 86932724e7 Don't open the Folder and IME when Folder is created.
Bug: 153751859
Change-Id: I8169d0890a43b614b293ca29f504e19c532b90ee
(cherry picked from commit 09066ffeb2)
2020-04-16 02:43:36 +00:00
TreeHugger Robot cd7d0e40d9 Merge "Fix regression where recents button had no animation" into ub-launcher3-rvc-dev am: a359556bff
Change-Id: I8e1f7a7443da5386769e46e3134f51210589b8ac
2020-04-16 00:17:54 +00:00
TreeHugger Robot a359556bff Merge "Fix regression where recents button had no animation" into ub-launcher3-rvc-dev 2020-04-15 23:56:26 +00:00
Tony Wickham 73ff6ddeac Remove mPendingCallback from ActivityTracker
Instead, all callers should use EXTRA_SCHEDULER_CALLBACK, set via
addToIntent(), to provide a callback for the next handleIntent().
The updated runCallbackWhenActivityExists() will do that for the
caller if the activity doesn't already exist (otherwise it will
run the callback synchronously as before).

Bug: 151389129
Change-Id: Idbec264354fd6de166ff3bae98249230078d5674
2020-04-15 18:48:39 -05:00
Tony Wickham 6ebf3d4434 Fix regression where recents button had no animation
Change-Id: I76102b4a9f3581b71285bfa9aa0c9dc29dd3165d
2020-04-15 18:06:28 -05:00
Jon Miranda dc186e68a1 Add AnimationFlag for SKIP_DEPTH_CONTROLLER.
We use this flag to prevent the depth from being immediately set to 0 when
preparing to animate home.

Bug: 152327671
Change-Id: I614c6ae08b9f9e56ecb94fb51748791a38504583
2020-04-15 15:19:49 -07:00
TreeHugger Robot 699e6be178 [automerger skipped] Merge "Import translations. DO NOT MERGE" into ub-launcher3-rvc-dev am: 2e201a887d -s ours
am skip reason: subject contains skip directive

Change-Id: I90ceaf260364a1252bc89c9d63b7b21ac32ae4ef
2020-04-15 22:05:02 +00:00
TreeHugger Robot 2e201a887d Merge "Import translations. DO NOT MERGE" into ub-launcher3-rvc-dev 2020-04-15 22:00:38 +00:00
TreeHugger Robot 070dec105f Merge "Removing tracing for a fixed bug" into ub-launcher3-rvc-dev am: 62d493d50b
Change-Id: Iccccf405d5a9ea6b3fbfe0950138aee7fb66e7d9
2020-04-15 21:59:49 +00:00
TreeHugger Robot 62d493d50b Merge "Removing tracing for a fixed bug" into ub-launcher3-rvc-dev 2020-04-15 21:57:31 +00:00
TreeHugger Robot ebcff1447e Merge "Address race condition with drag from external window" into ub-launcher3-rvc-dev am: 1fe0a4e080
Change-Id: I16c1d400c42a7c99d7c7ee307ae3f90bfc43d181
2020-04-15 21:53:16 +00:00
TreeHugger Robot 1fe0a4e080 Merge "Address race condition with drag from external window" into ub-launcher3-rvc-dev 2020-04-15 21:41:34 +00:00
Tony Wickham cfb803c42c Address race condition with drag from external window
When dragging from another window, e.g. when pinning an app shortcut,
there's a race condition as follows if launcher is killed:
- System drag starts
- Workspace loads and starts binding, canceling the drag

With this change, the drag will get onDragStart() again after this
case and allow completion of the drop.

Change-Id: I3f1c786ad1d451ecda9bbac5e9a9a3e0d8b66f73
2020-04-15 15:56:57 -05:00
vadimt f528fa6518 Removing tracing for a fixed bug
Bug: 138251824
Change-Id: Icd0d5001bfce0b1dabc102a2bbb0212a57d5839a
2020-04-15 13:51:47 -07:00
TreeHugger Robot 6434273834 Merge "Increasing string size limit" into ub-launcher3-rvc-dev am: ac9cf47712
Change-Id: Iec63856a68e327e3fad7bd2f45e19c46400a1240
2020-04-15 20:51:01 +00:00