Commit Graph

1286 Commits

Author SHA1 Message Date
Steven Ng 391404fcb7 Add personal / work tabs for work profile widgets
Video: https://drive.google.com/file/d/1TORRNcvVM7fIvNd_WZaajLbI7D9z4VFA/view?usp=sharing


Test: Main profile only: run AddConfigWidgetTest.
      With work profile: manually launch the full widgets sheet.
      Go to the personal tab: only personal widgets are shown.
      Go to the work tab: only work widgets are shown
      Successfully add personal / work widgets from the full widgets
      sheet.

Bug: 179797520

Change-Id: Iad8b90c2af35e0580319d7a05510ec88e4f8b86c
2021-02-22 16:10:09 +00:00
Vinit Nayak a34af18b0e Update System settings content observer to cache values.
Existing ContentObserver will cache values and overwrite
them when the value itself is modified or caller force
updates.

Bug: 149571513
Test: Wrote unit tests, mostly for caching logic.
Not meant to test ContentObserver contract for registering an
observer.

Change-Id: I12835f6c2be27ce17f65a55c51c4ef85c63b4487
2021-02-16 20:58:53 -08:00
Steven Ng e92bc55d12 Make all widgets collapsed in the full widget picker by default
Changes:
1. Add a WidgetListHeader view for showing icon, app name and a subtitle.
2. Only WidgetListHeaders are always visible to users in the full widget
   picker.
3. Only one widgets list from an app is visible in the full widget picker
   at any one time.

Test: Auto: run add robolectric tests under widget/picker
      Manual: Open full widgets picker. Then, expand and collapse apps.
      Video: https://drive.google.com/file/d/1gzfeEm5IOAu0qHsO77OTS2eMfU7CHJiL/view?usp=sharing

Bug: 179797520
Change-Id: Idac58be23dfeafcb79b3c61b4972d3addb462de1
2021-02-15 17:46:38 +00:00
Steven Ng 2f5648a911 Refactoring before adding a new view type in the WidgetsListAdapter
Changes made:
1. Model: added an abstract class for storing common information for
   entries shown in the full page widgets picker.
2. Introduced a ViewHolderBinder interface to split the logic of binding
   data to ViewHolder into separate classes.
3. Move the view holder binding of WidgetsListRow from WidgetListAdapter
   to its new class.
4. Move some widgets picker classes into a new picker package.

Test: Auto: Run WidgetsListAdapterTest, WidgetsListRowEntryTest and
      WidgetsListRowViewHolderBinderTest.
      Manual: open the all apps widgets tray and navigate the list.

Bug: 179797520
Change-Id: Iab29557842bb79156cad84d00a4c5d0db0c5aa06
2021-02-10 21:23:40 +00:00
TreeHugger Robot f56efc0187 Merge "Adding debug tracing for Device.wait" 2021-01-20 18:58:21 +00:00
Vadim Tryshev 9e86e3b89d Merge "Removing automatic failure investigator" 2021-01-20 18:46:42 +00:00
vadimt 952471f675 Removing automatic failure investigator
It wasn't updated for a while,
creates a false impression that the failure
is already tracked, and hopefully soon
will be replaced by new clustering.

Test: presubmit
Bug: 161478674
Change-Id: Icc3716c1f534867d5e4b21d18c9cede273da8704
2021-01-19 15:14:03 -08:00
vadimt ed86cb19bc Adding debug tracing for Device.wait
I suspect it may wait for a period of time less than
the specified one, causing flakes.

Test: presubmit
Bug: 177318681
Change-Id: I0be8790c6ee9a5831767fe83c36054ed5a84f8d7
2021-01-15 13:58:03 -08:00
vadimt f48097f270 Correctly generating heap dumps for OOP tests
Not trying to dump the test process :)

Still using Debug.dumpHprofData for inproc because
using shell command for inproc can deadlock.

Test: manual
Bug: 177065099
Change-Id: I4b581954a01ecc8a1427409baa030aaa3b70d6b5
2021-01-14 19:43:28 -08:00
TreeHugger Robot 23f0dc318c Merge "Generating Hdumps for more leaks" 2021-01-14 07:01:55 +00:00
vadimt c37058976d Generating Hdumps for more leaks
Test: presubmits
Bug: 177065099
Change-Id: I386229cf92a925d2953952ed0fab6c44dcdc61f0
2021-01-13 11:34:16 -08:00
Samuel Fufa a5f289a605 Increase timeout and additional logs for WorkTabTest#testWorkEduFlow
Bug: 159671700
Test: WorkTabTest#testWorkEduFlow
Change-Id: I5c015fbb9555be0e3e74c721873da4edd0393c8a
2021-01-13 10:26:00 -06:00
TreeHugger Robot b3f2862a30 Merge "Removing workaround for battery defender" 2021-01-08 19:45:32 +00:00
vadimt f4bb052ca0 Removing workaround for battery defender
The bug is supposed to be fixed.

Bug: 151613234
Change-Id: I8e803ead29e08e68fa75f61b5ad0e1198c9228ec
(cherry picked from commit ff39fd3e14)
2021-01-05 19:17:33 +00:00
Sunny Goyal 9b1e77377b Removing shelf from 2-button gesture mode
Test: Manual
Bug: 175137718
Change-Id: Ifb64b4dcac53252aefa8ee0bd6434f90f1d868b7
2021-01-05 19:07:21 +00:00
vadimt 0d9cb19453 Checking menu item test to improve test fail diags
Test: atest
Bug: 75641613
Change-Id: Idb5c7fe744e4a3e69ee0fdb59d1a5a58bc6ce0b2
2020-12-14 19:57:59 -08:00
Ice Chang feb22118bf Merge "Add swipes left method in Background.java" 2020-12-12 16:33:16 +00:00
Samuel Fufa 06ade42dd7 Merge "Resolve Flaky work tab tests" 2020-12-10 23:49:34 +00:00
Samuel Fufa b8df6a573a Resolve Flaky work tab tests
In cases where test execution and launcher relayout overlap, mLauncher.getAppsView().getContentView() returns a recyclerview instead of pagedView. This is resolved when rebindAdapters is later called with showTabs=true. The issue here is we are keeping a stale value of mLauncher.getAppsView().getContentView() in WorkEduView which is problematic as pagedView is required to set the right tab index for the test.

This behavior also affects work testWorkEduIntermittent as we need to verify the a pagedView is visible before text execution.
Bug: 149867607
Bug: 159671700
Test: flake -t com.android.launcher3.ui.WorkTabTest

Change-Id: I4b0968d6b9daa5c8fe741d4b1ed090f9c7acabed
2020-12-10 11:02:13 -06:00
Winson Chung ff6d94dd92 DO NOT MERGE Revert "Handle uiMode changes"
Bug: 171707437
Test: Repro steps on bug

This reverts commit 0ad7b172e6.

Change-Id: If30cbb6c155e879dc8307a0a4a06dfb548b389a1
(cherry picked from commit 4b4341d3a7)
2020-12-09 07:33:40 +00:00
icechang 212cff1dec Add swipes left method in Background.java
Bug: 153276032
Test: TF_GLOBAL_CONFIG=/google/src/cloud/<ldap>/<workspace>/google3/wireless/android/test_tools/forrest/configs/local-host-config.xml \
pts-tradefed run commandAndExit cuj/<testname> \
--primary-abi-only \
--log-level verbose --log-level-display verbose \
--wifi-network GoogleGuest

Test:

Change-Id: Ib1cbc609f47a547f173e8170f00af9e8bdfa77bb
2020-12-01 21:34:26 +08:00
TreeHugger Robot 20decea517 Merge "Removing binder call from the gesture injection" 2020-11-30 21:49:21 +00:00
Samuel Fufa e5d2ad8e34 Even more logs for flaky work test
Bug: 159671700
Change-Id: I009f243b5e3076d15bc89a4755d5ddb9a5b3119e
2020-11-19 22:54:02 +00:00
vadimt daa731f1fe Removing binder call from the gesture injection
This causes jank under lock contention stress.

Test: local
Bug: 173072373
Change-Id: I3a44e510254f6d651cedb91f72e1789ae97d9b67
2020-11-19 22:12:09 +00:00
Sunny Goyal 54834b0909 Merge commit '2cd8dd628268a177357afcccfeb7da8639e3a061' into merge_ub-launcher3-master_6976145
Test: manual, presubmit on the source branch
    x20/teams/android-launcher/merge/ub-launcher3-master_master_6976145.html

Change-Id: Ic13b1a20cc3d555e8e86717ca0da97103ff09c85
2020-11-16 14:40:43 -08:00
TreeHugger Robot 2b2c448679 Merge "Add more logs for WorkTabTest flake investigation" into ub-launcher3-master 2020-11-05 18:08:34 +00:00
Samuel Fufa d91bad956f Add more logs for WorkTabTest flake investigation
Bug: 159671700
Change-Id: I92f64bafa756a65d3e63514474028b82b059e357
2020-11-05 11:14:16 -06:00
Vadim Tryshev c0ef31e38f Revert "Removing workaround for battery defender"
This reverts commit ff39fd3e14.

Reason for revert: The CL coincided with a start of flakes "phone is locked". Let's revert and see if it fixed that. https://flakes-clusters.corp.google.com/#/?androidAtpBranch=git_master&androidAtpModule=com.google.android.apps.nexuslauncher.out_of_proc_tests&d=30&cid=9fd6b65c-e48c-4bc3-b19b-f5c610a1999a&maxResults=20

Change-Id: I90f8abbb1794c19593ed8a235a82c0e53030c0a2
2020-10-31 01:50:29 +00:00
Winson Chung 87f2b09072 Merging from ub-launcher3-master @ build 6925377
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-master_master_6925377.html

Change-Id: I928b100c8f41abff34047df69d988622123f9939
2020-10-23 10:16:50 -07:00
Winson Chung f99351888c Revert "Revert "Merge commit '8d14dbe041199d611839140f1c9285fd4174e9f4' ...""
This reverts commit 087a9e39b6.

Change-Id: I05b17a6e4aaaef6de3c2fa26aad45a39eb2833f9
2020-10-23 09:27:48 -07:00
vadimt ff39fd3e14 Removing workaround for battery defender
The bug is supposed to be fixed.

Bug: 151613234
Change-Id: I8e803ead29e08e68fa75f61b5ad0e1198c9228ec
2020-10-22 11:14:10 -07:00
vadimt 0ebbc18803 Removing tracing for a gone flake
Bug: 156044202
Change-Id: Ice142bb941fee7b731f46c2073fab17d83bbc871
2020-10-06 14:52:27 -07:00
TreeHugger Robot 470403eb58 Merge "Remove widgets that no longer fit the workspace in their current spans." into ub-launcher3-master 2020-10-05 18:29:54 +00:00
Alistair Delva 087a9e39b6 Revert "Merge commit '8d14dbe041199d611839140f1c9285fd4174e9f4' ..."
Revert "Merging from ub-launcher3-master @ build 6877130"

Revert "Merging from ub-launcher3-master @ build 6877130"

Revert "Merging from ub-launcher3-master @ build 6877130"

Revert submission 12738409-merge_ub-launcher3-master_6877130

Reason for revert: Introduced crashes to global presubmit

Reverted Changes:
I624658ce6:Merge commit '8d14dbe041199d611839140f1c9285fd4174...
Iccd2f1e3a:Merging from ub-launcher3-master @ build 6877130
I791d64951:Merging from ub-launcher3-master @ build 6877130
Icdd32ab01:Merging from ub-launcher3-master @ build 6877130

Bug: 169963211
Change-Id: I77a4ae59e823147beae8dd7cb9b54ccdace2c7f4
2020-10-05 14:46:26 +00:00
Matt Casey 49a94be109 Merge commit '8d14dbe041199d611839140f1c9285fd4174e9f4' into merge_ub-launcher3-master_6877130
Change-Id: I624658ce682b55042a12faacd4cf0cfd5d3a9a56
2020-10-01 18:55:38 +00:00
Jon Miranda 1d7ed30dba Remove widgets that no longer fit the workspace in their current spans.
This can happen when display size changes.
We compare span sizes of widget in the db to the min sizes of the widget
in the current display size. If the widget can no longer fit in its existing
spans, we remove it.

Also update test widgets to have minWidth/minHeight of 1dp. This ensures that
the spanX, spanY, min* values remain consistent between different test devices.

Bug: 168818961
Change-Id: I723372e4582658f78b2f23ced9073cb77977a6b8
2020-09-30 16:19:21 -07:00
Samuel Fufa 9fa2d8812a Resolve race condition between @Before conditions
Bug: 159671700
Change-Id: I5c96c32c171b7b539ce0ea799cf45955c2bee670
2020-09-30 10:57:04 -07:00
Samuel Fufa e806f95349 Additional logs to resolve flaky work profile
Bug: 159671700
Change-Id: I9bed08ef89b06f79ee1e6a4140a880eeeb76ee75
2020-09-22 12:57:45 -07:00
TreeHugger Robot 087b3fec4f Merge "Remove tracing for a non-repro flake" into ub-launcher3-master 2020-09-21 18:56:44 +00:00
vadimt b1ee0a020f Remove tracing for a non-repro flake
Change-Id: I53cc5020435bb3b630754a77d73590b35b595407
2020-09-17 11:53:44 -07:00
Vadim Tryshev c77a225faf Merge "Revert "Speed up tests by injecting input events asynchronously"" into ub-launcher3-master 2020-09-17 17:57:33 +00:00
Vadim Tryshev 7729447716 Revert "Speed up tests by injecting input events asynchronously"
This reverts commit 4c80053950.

Reason for revert: Broke tests

Change-Id: I3bd556b3127c0936b18a3fec8202b492d2ecb099
2020-09-17 17:15:08 +00:00
Treehugger Robot ece21e957e Merge "optimization of searching apps in Chinese" am: a0357329e0 am: f655c6e433 am: b634086d6c am: 27ae39420e am: 44150f8da4
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1425241

Change-Id: I1b270e7153c41789fb6a7eba88f29b0baa27780e
2020-09-17 14:52:29 +00:00
Treehugger Robot 44150f8da4 Merge "optimization of searching apps in Chinese" am: a0357329e0 am: f655c6e433 am: b634086d6c am: 27ae39420e
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1425241

Change-Id: Ic0b8025774c0c62e039ea9edd6f8f0e545107488
2020-09-17 14:12:18 +00:00
TreeHugger Robot 7144004c56 Merge "Speed up tests by injecting input events asynchronously" into ub-launcher3-master 2020-09-17 01:22:07 +00:00
Jon Miranda fcc7dd7e57 Merging from ub-launcher3-master @ build 6834159
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-master_master_6834159.html

Change-Id: I4350d0ddedd107d7005625480aefda19e5d06ba2
2020-09-14 22:13:30 +00:00
zhaoguomanong 97cc6df21d optimization of searching apps in Chinese
Signed-off-by: zhaoguomanong <zhaoguomanong@gmail.com>
Change-Id: Id322eb8b5249d6163da8a5d3476a6cf9500ad6bb
2020-09-10 22:58:15 -04:00
Sreyas 46aba2a46e Adding content push button behind flag to OAV.
Tested: TaplTestsNexus:testOverviewActions()
Change-Id: I83bc6e5033e2292776c927fba363214f347e01ce
2020-09-10 12:59:55 -07:00
Tony Wickham fa9675a32e Merging from ub-launcher3-rvc-qpr-dev @ build 6770831
Bug:150504032
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-rvc-qpr-dev_rvc-qpr-dev_6770831.html

Change-Id: Ic07dd8bd495cd0e013a00a29d9d9f11e246dc568
Merged-In: I5e9c73a7ac3033fe82006c4bd72824f56b8988f8
2020-08-18 04:59:10 +00:00
Mehdi Alizadeh 4595166bf5 Merging from ub-launcher3-master @ build 6767682
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-master_master_6767682.html

Change-Id: I5e9c73a7ac3033fe82006c4bd72824f56b8988f8
2020-08-16 12:31:21 -07:00