Commit Graph

576 Commits

Author SHA1 Message Date
Vadim Tryshev c5c0e5e96e Merge "Improving TAPL diagnostics" into sc-dev 2021-06-22 18:06:06 +00:00
TreeHugger Robot 5dae3f3162 Merge "Improving diagnostics for objects disappearing from screen" into sc-dev 2021-06-22 03:33:19 +00:00
vadimt 2c81502028 Improving TAPL diagnostics
Test: presubmit
Bug: 187761685
Change-Id: Ib8e965862c6accb393681c8b3ede60c7f9d26e48
2021-06-21 19:22:18 -07:00
TreeHugger Robot 0877cdab7a Merge "Ensure widgets header is out of the gesture region before clicking" into sc-dev 2021-06-18 00:56:52 +00:00
Vadim Tryshev 26cd946f29 Merge "Improving diagnostics when Launcher dies while in ContentProvider call" into sc-dev 2021-06-17 21:02:24 +00:00
Tony Wickham d410a2c168 Ensure widgets header is out of the gesture region before clicking
This way, NexusLauncher won't appear during the Launcher3 test.

Test: AddConfigWidgetTest#testConfigCancelled
Bug: 188450580
Change-Id: Iedf0e0e17eab2473ecd2d17a4391cf9db3e80599
2021-06-17 17:49:54 +00:00
vadimt 5a03ade794 Improving diagnostics when Launcher dies while in ContentProvider call
Test: presubmit
Bug: 191059619
Change-Id: Ib87a41663a63729024b41603973b782cf4763551
2021-06-15 19:34:24 -07:00
Jon Miranda 229c4c3235 App Shortcut menu bug fixes and polish.
- Widget is its own item.
- Change order of icon order.
- Update grab handle colors

Bug: 188095695
Test: long press on apps with/without widgets, long press apps on workspace/
      all apps/search

Change-Id: Iabb9b4b3f3a928103b9d62601f22e74ef2325d7c
2021-06-15 18:59:51 -07:00
vadimt c636900a90 Improving diagnostics for objects disappearing from screen
Test: presubmit
Bug: 187761685
Change-Id: Id932e8100399990d791f7825787708d5d459f61e
2021-06-15 18:52:31 -07:00
vadimt 7d3f73c856 Excluding corner radius from quick switch gesture.
Test: forrest on new devices
Bug: 190638716

Change-Id: Iefa89e040ab77869db7022d7c535a5546e03ae3c
2021-06-14 15:05:23 -07:00
TreeHugger Robot b32c61a6cc Merge "Logging UPs and DOWNs that TAPL injects" into sc-dev 2021-06-14 20:55:48 +00:00
vadimt 1e1ad449a8 Logging UPs and DOWNs that TAPL injects
Test: presubmit
Bug: 190748682
Change-Id: I82e792724bab178a9c3ca190609af913fbaf4a87
2021-06-11 14:10:45 -07:00
Jon Miranda 32ff76cb4e Adding color back to popup container.
For Color exctraction now occurs in groups:
- System shortcuts
- Deep shortcuts
- Notifications

For home setting popup, each DeepShortcutView will have its own
extracted color.

Bug: 188095443
Test: manual
Change-Id: I7e209f863ff180b8f017aeb2a73c6f1a51842e68
2021-06-10 19:15:24 +00:00
TreeHugger Robot 3941bc65e3 Merge "Delaying initializing "is launcher3" flag" into sc-dev 2021-06-02 00:11:47 +00:00
vadimt 8d27c4c40c Delaying initializing "is launcher3" flag
Launcher3 tests may set default launcher after instantiating TAPL

Test: presubmit
Bug: 188477498
Change-Id: I6e40bc3fcf9c4f040983f164d3a04d0189228f83
2021-06-01 14:11:58 -07:00
zakcohen cad022499c Remove overview feedback.
Bug: 189489289
Test: TAPL update
Change-Id: If531aed1b2e10de9b60f9929cbcdcb5e7ffd436b
2021-05-27 14:09:09 -07:00
vadimt bfac8730fe Improving TAPL messaging
Test: presubmit
Bug: 187761685
Change-Id: I83eb0eef2f9c8c33cc9d1b42cb52fb670a5bf427
2021-05-20 15:48:29 -07:00
vadimt e2801bcb77 Removing pss checks in memory tests
Test: presubmit
Bug: 185181057
Change-Id: I4f504f9540b80c62cd3f1024ff1d1b57102f2ed6
2021-05-12 18:57:55 -07:00
TreeHugger Robot 39228d0325 Merge "Improving TAPL error messages" into sc-dev 2021-05-12 19:10:34 +00:00
Winson Chung d193f65878 Merge "Use testapi to trigger gc in system and sysui" into sc-dev 2021-05-11 05:02:37 +00:00
vadimt a6cb751715 Improving TAPL error messages
Test: forrest
Bug: 187761685
Change-Id: I822f3f28e7153028fb5746e037066153478ec86d
2021-05-10 17:50:41 -07:00
vadimt eefc2e1de1 Diagnosing only system health problems happened during the test
Test: presubmit
Bug: 187761685
Change-Id: I3feba12e2228fe6dda3b0d65d904b0b839da2108
2021-05-11 00:31:24 +00:00
Winson Chung b09a41d86c Use testapi to trigger gc in system and sysui
- Do this prior to gc'ing launcher to ensure that temporary binder
  refs on the system side a released

Bug: 186268407
Test: Presubmit

Change-Id: I7878e1042b07ded5491af6153cff9b0772c557db
2021-05-10 13:00:37 -07:00
TreeHugger Robot 60f6662fa3 Merge "Temporary wait to check that waiting after swiping from context menu is a way to the real fix." into sc-dev 2021-05-04 03:18:07 +00:00
vadimt e9ce95bed8 Temporary wait to check that waiting after swiping from context menu is a way to the real fix.
Test: presubmit
Bug: 187080582
Change-Id: Ief09857c267e8786bb6f67203db26b47f27060ea
2021-05-03 19:05:35 -07:00
Alina Zaidi 2b5124ec41 Fix some bugs in widget pickers.
- Update color of Educational tip view contents. Background colorAccentSecondary
in NexusLauncher above S, colorAccent otherwise (b/185834169)
- Update widget picker search bar color and its text font and color. (b/186423026)
- Update button padding and text in pin widget picker. (b/182994384, b/183601584)

Bug: 185834169
Bug: 186423026
Bug: 182994384
Bug: 183601584
Test: Manually tested
Change-Id: I36cd3ed2285677d0c164db8f57f6c90a5f247982
2021-04-30 07:52:23 +01:00
TreeHugger Robot 0d51bc3caa Merge "Better diags when Launcher is manipulated on the locked phone" into sc-dev 2021-04-22 13:22:05 +00:00
vadimt 4c6722ede5 Better diags when Launcher is manipulated on the locked phone
Test: presubmit
Bug: 185395995
Change-Id: I9a7e0bda47851ce186adc15838f9ace9a2c8195a
2021-04-20 19:38:46 -07:00
Steven Ng 8c8d99f966 Fix flaky widget tapl tests
Potential issues:
1. Widgets floating tips view is being shown
2. Header visible height is too small to be considered as a scroll
   gesture

Test: Run AddConfigWidgetTest, AddWidgetTest, BindWidgetTest &
      RequestPinItemTest
Bug: 185733371
Change-Id: Ic3e9188724dd920349ce8d8e8d98392b94b40642
2021-04-20 23:01:19 +01:00
vadimt 6a562d8cbe Waiting for NexusLauncher to go away after swiping up from menu
Swiping up can temporarily bring Nexus Launcher if the
current launcher is a Launcher3 one. Wait for the
current launcher to reappear.

Test: presubmit
Bug: 183615088
Change-Id: Iff6eaf3bf27f7ddca445fab86780f8cf82f97352
2021-04-13 11:22:03 -07:00
Zak Cohen b391ebf798 TAPL Increase size of Background to Overview swipe gesture
The instrumentation is using the swipe height, not width, for when in
landscape. Ideally this should be plumbed through but it isn't yet so fix
with a bigger gesture.

Test: TaplTestNexus#testBackground
Bug: 184059820
Change-Id: Id19f65f51468af707baea0a1b31569bb84f7fcb8
2021-03-31 15:10:21 -07:00
Steven Ng 26a9df6046 Fix AddWidgetTest & AddWidgetConfigTest
Simplify the scrolling by a scroll down a smaller fixed distance. This
way we don't need to scroll back-n-forth in order to handle the
overlapping of the search bar and the targeted widget.

Test: run AddWidgetTest & AddWidgetConfigTest

Bug: 183616605
Change-Id: Icc72f4ba6c61bdb95ab5eaf22600407d59d14eba
2021-03-25 20:57:13 +00:00
Steven Ng 6c5e02ac27 Fix scrolling in widgets picker tapl tests
If the search bar and the target widget item intersect, scroll up to
make the target widget item clickable.

Test: run AddWidgetTest, AddConfigWidgetTest

Bug: 183403949
Change-Id: I847cc34757cb02b1a12e18e511fda749873ad5da
2021-03-24 00:01:53 +00:00
Steven Ng 682af23651 Merge "Renders widget recommendations" into sc-dev 2021-03-19 23:18:22 +00:00
Steven Ng 4235fc129c Renders widget recommendations
Update the tapl test logic to scroll a smaller distance to avoid the
search bar blocking the target touch area.

Test: Open full widgets sheet and observe the widget recommendations
      shown at the top.
      Run AddConfigWidgetTest

Bug: 179797520

Change-Id: I6d53bbb46e2cb928ed7d015aaac604be17d33178
2021-03-19 21:11:32 +00:00
TreeHugger Robot bab908bfca Merge "Disable waiting for animation from event injection" into sc-dev 2021-03-19 20:24:54 +00:00
Sunny Goyal c373e1c642 Adding an optional QSB in hotseat
Removing sections in all-apps during transition and treating
it as a single unit

Bug: 175137718
Test: Manual
Change-Id: I55a501d80b5903f1a9d92a26b3784784fd9e50fd
2021-03-17 12:21:44 -07:00
Vadim Tryshev f4cacd720c Merge "Fixing Launcher3 tests" into sc-dev 2021-03-15 17:47:05 +00:00
vadimt 730b9d60a4 Fixing Launcher3 tests
Adding an atest config.
Correctly calculating display height.
Allowing scrolling from a partially visible bottom row in AllApps

Test: presubmit
Bug: 182006150
Change-Id: I5f3b976ac05ed1c2e1ffbb67cc6db0c0ee13ae6c
2021-03-12 15:11:34 -08:00
vadimt 288960b5ba Disable waiting for animation from event injection
This will avoid taking locks from it,
and stop TAPL from introducing jank under lock contention.

Bug: 173469230
Test: presubmit
Change-Id: Ifeba2dc7528b573ffaba2aa94dfdae6b8a14a7b3
2021-03-11 19:11:19 -08:00
vadimt 368dc79f55 Increase wait times in TAPL
This helps to avoid misleading errors when
the system has performance problems.

Test: presubmit
Bug: 179392551
Change-Id: I4de3c543f32f41af64bd6107885df82b03973d35
2021-03-10 12:19:12 -08:00
TreeHugger Robot d3b82a2471 Merge "Log a bit more data in switchToAllApps()" into sc-dev 2021-02-27 03:15:24 +00:00
Tony Wickham 4faa87c478 Log a bit more data in switchToAllApps()
Test: TaplTestsQuickstep.testWorkspaceSwitchToAllApps
Bug: 181122114
Change-Id: Ice5515f5b3ac87c42af42d946036505879deb235
2021-02-26 16:25:35 -08:00
Vadim Tryshev e1ea6cf754 Merge "Waiting for the state of views to settle after orientation change" into sc-dev 2021-02-26 19:37:06 +00:00
TreeHugger Robot 47603e4e69 Merge "Diagnosing expected selector in app-start" into sc-dev 2021-02-26 19:28:44 +00:00
vadimt 6e2a8e86df Diagnosing expected selector in app-start
Test: manual
Bug: 179392551
Change-Id: I4c7173e784caaa6435927f94eef6b269884d0ce9
2021-02-25 19:32:41 -08:00
vadimt 5f21f104f0 Waiting for the state of views to settle after orientation change
Presumably, we currently have flakes when immediately
after orientation change, we check for the presence of certain
views, and they are still not present.

Test: presubmit
Bug: 181057446
Change-Id: I6dbcb757a47c19728d4096283da6710f6dd5aa02
2021-02-25 18:50:49 -08:00
Steven Ng e8d92342fa Replace horizontal ScrollViews with tables in the full widgets picker
Test: Run gnl test, AddWidgetTest
      Run Robolectric tests for widgets
      Manual test video: https://drive.google.com/file/d/1uwCtVNIlC9150kv5eEfILfP5r5M7ARYm/view?usp=sharing

Bug: 179797520
Change-Id: I2f4cdf84338a91b63967879d0c9268c312ace19b
2021-02-24 19:49:15 +00:00
Steven Ng 391404fcb7 Add personal / work tabs for work profile widgets
Video: https://drive.google.com/file/d/1TORRNcvVM7fIvNd_WZaajLbI7D9z4VFA/view?usp=sharing


Test: Main profile only: run AddConfigWidgetTest.
      With work profile: manually launch the full widgets sheet.
      Go to the personal tab: only personal widgets are shown.
      Go to the work tab: only work widgets are shown
      Successfully add personal / work widgets from the full widgets
      sheet.

Bug: 179797520

Change-Id: Iad8b90c2af35e0580319d7a05510ec88e4f8b86c
2021-02-22 16:10:09 +00:00
Steven Ng e92bc55d12 Make all widgets collapsed in the full widget picker by default
Changes:
1. Add a WidgetListHeader view for showing icon, app name and a subtitle.
2. Only WidgetListHeaders are always visible to users in the full widget
   picker.
3. Only one widgets list from an app is visible in the full widget picker
   at any one time.

Test: Auto: run add robolectric tests under widget/picker
      Manual: Open full widgets picker. Then, expand and collapse apps.
      Video: https://drive.google.com/file/d/1gzfeEm5IOAu0qHsO77OTS2eMfU7CHJiL/view?usp=sharing

Bug: 179797520
Change-Id: Idac58be23dfeafcb79b3c61b4972d3addb462de1
2021-02-15 17:46:38 +00:00