Commit Graph

876 Commits

Author SHA1 Message Date
TreeHugger Robot 98833d525c Merge "Updating some non-final static objects" into ub-launcher3-master 2019-12-11 22:07:53 +00:00
TreeHugger Robot 7d2f42d97a Merge "Moving logging Launcher and platform versions before matching" into ub-launcher3-master 2019-12-11 21:30:35 +00:00
Sunny Goyal 73b5a27b14 Updating some non-final static objects
Updating various static objects to use a standard pattern so that
it is easier to track and cleanup those objects

Bug: 141376165
Change-Id: Ia539cbfa338d544dddad771c5027b6748762768b
2019-12-11 13:22:58 -08:00
TreeHugger Robot 4f37a5e268 Merge "Removing static instances of UserManagerCompat and AppWidgetManager" into ub-launcher3-master 2019-12-11 18:41:04 +00:00
Sunny Goyal 337c81f664 Removing static instances of UserManagerCompat and AppWidgetManager
> Changing the lifecycle to follow other static objects in Launcher
> Removing compat interface and inlining everything to helpers

Bug: 141376165
Change-Id: I82bd5db1969101de9a7eac77f32728d70195bb35
2019-12-11 10:03:19 -08:00
vadimt 61e285245e Moving logging Launcher and platform versions before matching
I suspect that sometimes APIs return versions that are different from
ones in the bugreport. We want to see them before possible non-match
failures.

Bug: 145935261
Change-Id: Ia1a9208de111368245eac9147ae4a189db823105
2019-12-09 18:15:33 -08:00
vadimt bdaa179b92 Consistently checking state change messages
Checking for events whenever Launcher sends them.
Checking for correct events (final events, not for events from
intermediate state changes).

This should simplify diagnosing of bugs involving TAPL.
This is also supposed to fix Fallback overview tests.

Bug: 143488140
Change-Id: If053ed808ec71bf2b652ab680be5bdfe9ff8cbb9
2019-12-09 12:33:39 -08:00
Sunny Goyal 4b5b0eb60d Moving some tests to robolectric
> Adding support for simulating model load

Bug: 130562632
Change-Id: I1de8c0abe2e74d4e7e47e18914316c339920609a
2019-12-09 11:17:12 -08:00
Tony Wickham 8a50a6d858 Send home intent after reaching 3P launcher on swipe up
Also keep the 3P launcher's alpha at 0 during the gesture, and
don't send the home intent if user touches during the transition.

Bug: 139682945
Change-Id: Ie758f0b337bb173b34f5585ec1915b7ea1145094
2019-12-05 14:40:13 -08:00
TreeHugger Robot 0868d999f1 Merge "Improving error messages when swiping up to home" into ub-launcher3-master 2019-11-22 18:40:56 +00:00
vadimt 7d6e7add97 Improving error messages when swiping up to home
Change-Id: I7c230d657eacb7a386a906e1f5470a15e1fe5868
2019-11-21 19:12:19 -08:00
TreeHugger Robot 9ccea3961c Merge "Accelerating dragging to workspace by using pause at the end of the gesture" into ub-launcher3-master 2019-11-21 22:30:04 +00:00
thiruram 5e1ecf6d73 Adds proto-lite libraries to Launcher3 make files.
Change-Id: Icb2f8fcdb4d5344de835f4702fc01ec80d4a3b84
2019-11-20 21:49:44 +00:00
vadimt 83b7a6d8bf Accelerating dragging to workspace by using pause at the end of the
gesture

Change-Id: Ib14b9519e23aa34156dab9eff75cd2609ad57e14
2019-11-19 15:00:29 -08:00
TreeHugger Robot 10bf76941f Merge "Making the default launcher rule outer for the Portrait-Landscape one" into ub-launcher3-master 2019-11-19 22:51:54 +00:00
vadimt 4d627f09c0 Staring swipe-to-all-apps gesture from above bottom gesture area
Bug: 139682945
Change-Id: I2fe8929c1dea8448c23394afd6f9d711b73f2562
2019-11-19 21:48:55 +00:00
vadimt f9e559275d Making the default launcher rule outer for the Portrait-Landscape one
Portrait-Landscape uses Launcher activity and needs it to be set up
correctly.

Change-Id: I13c9712647b3e45a259039d7968bb95cfe8158ef
2019-11-19 13:36:29 -08:00
vadimt 73cd121122 When scrolling in All apps, scroll to last clickable row
Not the last row. This fixes tests broken after some assumption broke in
platform at an unknown moment.

Since the gesture distance became smaller in some cases, the speed of
the gesture became slower, and on some devices, the scroll gesture
triggers icon dragging.

To prevent this, I reduced the number of steps in the gesture to 10, but
added a slow-down at the end of the gesture to avoid inertia.

Also made some names and calculations clearer.

Bug: 144180777
Change-Id: Ie6c5776606ecff64d553fa836bdb3d90f32c5d9e
2019-11-15 13:40:29 -08:00
Vadim Tryshev d82d667194 Merge "Revert "When scrolling in All apps, scroll to last clickable row"" into ub-launcher3-master 2019-11-15 00:58:22 +00:00
Vadim Tryshev a354835c6e Revert "When scrolling in All apps, scroll to last clickable row"
This reverts commit 7afd271a17.

Reason for revert: b/144522058

Bug: 144522058

Change-Id: Ie104b092a44e3a2fee0803fa83f1af7f8fd0afdf
2019-11-14 22:34:08 +00:00
Pinyao Ting 44677f7e88 fix custom shortcut test
Bug: 143725213
Change-Id: I296452faea67568b39a35968bb813dc4e51a51fc
2019-11-14 14:13:22 -08:00
vadimt fa6f56761b Improving error message
The old one could be misunderstood as "the whole Launcher is missing".

Change-Id: I91cad52ee297b0250cba23215743a47c24757ae1
2019-11-13 18:26:28 -08:00
TreeHugger Robot 236ef051fd Merge "Tapl: AllApps: ensuring a minimal vertical size of an icon" into ub-launcher3-master 2019-11-13 20:52:36 +00:00
vadimt 480083490f Tapl: AllApps: ensuring a minimal vertical size of an icon
Clicking an icon within its padding area is ignored by Launcher. Hence,
ensuring that the whole icon is visible.

Bug: 141770616
Change-Id: I19e3ba7cfa25de75a47202845d0838bea46af92c
2019-11-13 20:20:57 +00:00
Pinyao Ting fed4d8e8da disable custom shortcut test in oop
am: d9dd8ef3ba

Change-Id: I6cb1f18c3e7ca1cd79aa5f58a0e03ef07eb797ee
2019-11-13 10:40:01 -08:00
Pinyao Ting d9dd8ef3ba disable custom shortcut test in oop
Bug: 142154748
Change-Id: I08ec8f665a3cc45610f8f2b27a60f7334a2b1b24
2019-11-12 23:37:20 -08:00
vadimt 7afd271a17 When scrolling in All apps, scroll to last clickable row
Not the last row.

Also scrolling in the middle of All Apps, not at the top, because
otherwise the scroll can start on search box.

Bug: 144180777
Change-Id: I219faec165b8b403530a9c09d419cc453aea6039
2019-11-11 10:46:28 -08:00
vadimt b0a14e96ae Removing temporary tweaks to make tests pass in presubmit
Now that we have a more reliable build of CF

Bug: 142828227
Change-Id: Ib385443048b6ccd9e1eb3372dc39947536f948bd
2019-11-11 09:23:28 -08:00
Jon Miranda 13a7980e09 System apps must target API 29 or higher
AndroidManifest.xml already updated

Bug: 143991628
Change-Id: Ia9ddeda016548a0ebe5c5ec527741a7a8f9c0e4d
2019-11-06 16:01:25 -08:00
vadimt 137f5b62ac Improve diags when system errors cause failing Launcher tests
Now, for example, we won't diagnose a locked phone as a
"home button not showing in 3-button mode", even though it's technically
correct.

Change-Id: Ibdfa0741af7ff8545a811f6702dda74dc6c31c2e
2019-11-04 14:50:22 -08:00
Pinyao Ting 5eee5f4da0 enable custom shortcut test
Bug: 141568904
Change-Id: Ie51ef6f7a2f5d4579689a82184bdd7681a266d04
2019-10-31 17:09:40 -07:00
Sunny Goyal 3808a69a6c Storing BitmapInfo instead of icon and color directly in itemInfo
This will allow subclassing BitmapInfo to support custom icon/dynamic
icons which can be loaded on the background thread instead of going
through IconFactory which runs on UiThread

Change-Id: Ieced6e91330bdff1b505826d097a8df711dfe967
2019-10-28 11:12:47 -07:00
vadimt b7eedb4579 Support for overriding test run flavor
Change-Id: I054a1eaa888cd97a7c7fa5fcc65513d6d89c3a1c
2019-10-25 16:44:29 -07:00
vadimt 23c8341096 Removing tracing and @Stability for a fixed bug
Bug: 142514365
Change-Id: I147850db274c465fb964eca30b97b3ebaaa2ccf6
2019-10-25 11:21:33 -07:00
Winson Chung ef558648e6 Bump time to scroll to last visible row (affects jank/perf tests)
- Regression from ag/9592395, bump the time of scrolling to the
  last visible row slightly to prevent a fling

Bug: 141484300
Change-Id: I41c041fe591aceebc63b7e869a705164babb09ea
2019-10-24 15:31:34 -07:00
TreeHugger Robot f13109df05 Merge "Refactor SwipeDetector to track both axes" into ub-launcher3-qt-future-dev 2019-10-24 19:24:12 +00:00
Tony Wickham eed585b0c3 Refactor SwipeDetector to track both axes
Existing clients now use the SingleAxisSwipeDetector subclass. A
followup CL will add BothAxesSwipeDetector, whose first client will be
the quick switch from home controller.

Bug: 126596417
Change-Id: I54c71088cfe99ff28cdc719a1eb7a7d06ac95d2d
Merged-In: I54c71088cfe99ff28cdc719a1eb7a7d06ac95d2d
2019-10-24 18:56:44 +00:00
Tony Wickham 5aeb3b84b8 Refactor SwipeDetector to track both axes
Existing clients now use the SingleAxisSwipeDetector subclass. A
followup CL will add BothAxesSwipeDetector, whose first client will be
the quick switch from home controller.

Bug: 126596417
Change-Id: I54c71088cfe99ff28cdc719a1eb7a7d06ac95d2d
2019-10-24 10:38:17 -07:00
TreeHugger Robot 85561d1e44 Merge "Fix testQuickSwitchFromApp" into ub-launcher3-master 2019-10-24 00:12:09 +00:00
Tony Wickham bc42d64c85 Fix testQuickSwitchFromApp
Instead of starting getAppPackageName() and relying on it being our Test
Pin Item activity, instead launch our own test activities with the
FLAG_ACTIVITY_MULTIPLE_TASK and FLAG_ACTIVITY_NEW_DOCUMENT flags.

Test:
- Locally run testQuickSwitchFromApp() from Android Studio
- flake -oop -t com.android.quickstep.TaplTestsQuickstep#testQuickSwitchFromApp

Bug: 140252765
Change-Id: Ie137261ce65bfd3dd39df78d57784854a026e967
2019-10-23 23:42:19 +00:00
Tony Wickham 476b7d4378 Fix testQuickSwitchFromApp
Instead of starting getAppPackageName() and relying on it being our Test
Pin Item activity, instead launch our own test activities with the
FLAG_ACTIVITY_MULTIPLE_TASK and FLAG_ACTIVITY_NEW_DOCUMENT flags.

Test:
- Locally run testQuickSwitchFromApp() from Android Studio
- flake -oop -t com.android.quickstep.TaplTestsQuickstep#testQuickSwitchFromApp

Bug: 140252765
Change-Id: Ie137261ce65bfd3dd39df78d57784854a026e967
Merged-In: Ie137261ce65bfd3dd39df78d57784854a026e967
2019-10-23 23:40:57 +00:00
Winson Chung f6448e62e6 Merge "Reduce animation time for some common TAPL actions (affects jank/perf tests)" into ub-launcher3-master 2019-10-23 23:40:53 +00:00
Winson Chung 82b2ef27c8 Reduce animation time for some common TAPL actions (affects jank/perf tests)
- All apps swipe up 1s -> 200ms (doesn't matter if it's a fling)
- Scroll to last visible row 2.5s -> 1.25s (seems sufficient to not be a fling)
- Drag icon to workspace 2s -> 500ms (seems sufficient to not be a fling)
- This changes the total frames produced for the jank tests, but should not
  change the jank proportion or the individual frame drawing times

Bug: 141484300
Change-Id: I9f2e647ebc2c27c6269238daa4c3e6ad314c8161
Signed-off-by: Winson Chung <winsonc@google.com>
2019-10-23 23:31:20 +00:00
TreeHugger Robot 7caa519140 Merge "Step 4 from the plan below:" into ub-launcher3-master 2019-10-23 17:54:19 +00:00
vadimt 3a13366e00 Restoring 10-sec wait for model initialization
Will see if ag/9573576 fixed long model loading

Bug: 136278866
Bug: 142514365
Change-Id: If0dc61faff00683cf3248c127a64ff5b065f9ae4
2019-10-18 12:43:10 -07:00
vadimt ad81b816f0 Step 4 from the plan below:
1. Skip all tests that fail in inproc mode on CF (this CL)
2. Observe postsubmit and make sure no inproc tests are failing or too
flaky on CF
3. Enable presubmit
4. Switch to skipping tests from step 1 only for inproc presubmit;
they'll start failing in postsubmit
5. Gradually make all tests pass and not flaky and enable them back on
presubmit

Bug: 142828227
Change-Id: I0092d6b92b0358866f8cbf9e00dbe3fabe23703d
2019-10-17 17:52:29 -07:00
vadimt af317c7821 More preparation for enabling inproc presubmits
Bug: 136278866
Change-Id: Icc4a0d935acf76950197bc184f8dba5d07ee85c5
2019-10-17 12:07:10 -07:00
TreeHugger Robot 35903d2cb2 Merge "Reducing the time for expected launcher initialization back to 10 sec" into ub-launcher3-master 2019-10-17 07:18:37 +00:00
vadimt 6332b7d73c Reducing the time for expected launcher initialization back to 10 sec
It was temporarily raised to 60 sec.

https://googleplex-android-review.git.corp.google.com/9563509
should've fixed some problems with loading time, but likely not all.

We need to observe whether this test starts flaking again.

testDragIcon will run only in Launcher postsubmit, and won't block
merges to platform if it fails.

Bug: 142514365
Change-Id: I2b9a9d043346ebda721221cefd6118a1a799501f
2019-10-16 17:49:29 -07:00
vadimt 3680357a67 Preparing to enabling Inproc launcher tests as presubmit
The plan:
1. Skip all tests that fail in inproc mode on CF (this CL)
2. Observe postsubmit and make sure no inproc tests are failing or too
flaky on CF
3. Enable presubmit
4. Switch to skipping tests from step 1 only for inproc presubmit;
they'll start failing in postsubmit
5. Gradually make all tests pass and not flaky and enable them back on
presubmit

Bug: 142828227
Change-Id: I6ea3d53771503e8fd968555bb2e4cb1be10d83ef
2019-10-16 17:35:18 -07:00