From 06d314917fcf44bae9f1178b225e9280caec17ea Mon Sep 17 00:00:00 2001 From: Colin Cross Date: Thu, 15 Dec 2016 12:55:03 -0800 Subject: [PATCH] Fix unused parameter warning for mips builds libbacktrace_offline was inheriting -Wno-unused-parameter from llvm's makefiles. Fix an unused parameter warning when compiling for an unsupported architecture, and return false since *value wasn't written. Test: lunch aosp_mips-eng && mma -j Change-Id: I7df990f01e1025ca17ec3717107df56d2349f3cb --- libbacktrace/BacktraceOffline.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libbacktrace/BacktraceOffline.cpp b/libbacktrace/BacktraceOffline.cpp index 9e95563b0..5e543286e 100644 --- a/libbacktrace/BacktraceOffline.cpp +++ b/libbacktrace/BacktraceOffline.cpp @@ -34,6 +34,7 @@ extern "C" { #include #include +#include #include #include #include @@ -534,6 +535,10 @@ bool BacktraceOffline::ReadReg(size_t reg, uint64_t* value) { default: result = false; } +#else + UNUSED(reg); + UNUSED(value); + result = false; #endif return result; }