openkylin
/
platform_system_core
mirror of https://gitee.com/openkylin/platform_system_core.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Clarify SELinux service error message 

1) Attempt to make the error message associated with a missing service
better.
2) Provide a link to more in-depth documentation.

Bug: 65023716
Test: code compiles.
Change-Id: Ie0f1896fb41d5afd11501f046cb51d4c8afe0a62
This commit is contained in:
Nick Kralevich 2017-08-25 12:08:57 -07:00
parent 06e0c704d7
commit 1ea19eb44d
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
init/service.cpp
View File

@ -82,7 +82,11 @@ static Result<std::string> ComputeContextFromExecutable(std::string& service_nam
free(new_con);
}
if (rc == 0 && computed_context == mycon.get()) {
return Error() << "Service does not have an SELinux domain defined";
return Error() << "File " << service_path << "(labeled \"" << filecon.get()
<< "\") has incorrect label or no domain transition from " << mycon.get()
<< " to another SELinux domain defined. Have you configured your "
"service correctly? https://source.android.com/security/selinux/"
"device-policy#label_new_services_and_address_denials";
}
if (rc < 0) {
return Error() << "Could not get process context";