diff --git a/libutils/tests/Android.bp b/libutils/tests/Android.bp index ec6b67f21..f81943da4 100644 --- a/libutils/tests/Android.bp +++ b/libutils/tests/Android.bp @@ -18,33 +18,43 @@ cc_test { name: "libutils_tests", + host_supported: true, srcs: [ - "BlobCache_test.cpp", "BitSet_test.cpp", "Looper_test.cpp", "LruCache_test.cpp", "RefBase_test.cpp", "String8_test.cpp", "StrongPointer_test.cpp", - "SystemClock_test.cpp", "Unicode_test.cpp", "Vector_test.cpp", ], - shared_libs: [ - "libz", - "liblog", - "libcutils", - "libutils", - ], -} + target: { + android: { + srcs: [ + "BlobCache_test.cpp", + "SystemClock_test.cpp", + ], + shared_libs: [ + "libz", + "liblog", + "libcutils", + "libutils", + ], + }, + host: { + static_libs: [ + "libutils", + "liblog", + ], + }, + }, -cc_test_host { - name: "libutils_tests_host", - srcs: ["Vector_test.cpp"], - static_libs: [ - "libutils", - "liblog", + cflags: [ + "-Wall", + "-Wextra", + "-Werror", ], } diff --git a/libutils/tests/StrongPointer_test.cpp b/libutils/tests/StrongPointer_test.cpp index 323a6f20a..153cf9683 100644 --- a/libutils/tests/StrongPointer_test.cpp +++ b/libutils/tests/StrongPointer_test.cpp @@ -21,13 +21,13 @@ using namespace android; -class Foo : public LightRefBase { +class SPFoo : public LightRefBase { public: - explicit Foo(bool* deleted_check) : mDeleted(deleted_check) { + explicit SPFoo(bool* deleted_check) : mDeleted(deleted_check) { *mDeleted = false; } - ~Foo() { + ~SPFoo() { *mDeleted = true; } private: @@ -36,13 +36,13 @@ private: TEST(StrongPointer, move) { bool isDeleted; - Foo* foo = new Foo(&isDeleted); + SPFoo* foo = new SPFoo(&isDeleted); ASSERT_EQ(0, foo->getStrongCount()); ASSERT_FALSE(isDeleted) << "Already deleted...?"; - sp sp1(foo); + sp sp1(foo); ASSERT_EQ(1, foo->getStrongCount()); { - sp sp2 = std::move(sp1); + sp sp2 = std::move(sp1); ASSERT_EQ(1, foo->getStrongCount()) << "std::move failed, incremented refcnt"; ASSERT_EQ(nullptr, sp1.get()) << "std::move failed, sp1 is still valid"; // The strong count isn't increasing, let's double check the old object @@ -52,7 +52,7 @@ TEST(StrongPointer, move) { ASSERT_FALSE(isDeleted) << "deleted too early! still has a reference!"; { // Now let's double check it deletes on time - sp sp2 = std::move(sp1); + sp sp2 = std::move(sp1); } ASSERT_TRUE(isDeleted) << "foo was leaked!"; }