From 5ccdfa63499ed8342bde875ead003ff90f336f19 Mon Sep 17 00:00:00 2001 From: Christopher Ferris Date: Mon, 7 Mar 2016 19:18:31 -0800 Subject: [PATCH] Don't fail if the new pss is less than stable. Sometimes, the new pss is significantly less than the stable pss. Do not fail if this case occurs. Change-Id: Ic7da87275a821818e375d05cac10e84c62710c5e --- libbacktrace/backtrace_test.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libbacktrace/backtrace_test.cpp b/libbacktrace/backtrace_test.cpp index b975db955..ab09564c7 100644 --- a/libbacktrace/backtrace_test.cpp +++ b/libbacktrace/backtrace_test.cpp @@ -1412,9 +1412,9 @@ void CheckForLeak(pid_t pid, pid_t tid) { } size_t new_pss = GetPssBytes(); ASSERT_TRUE(new_pss != 0); - size_t abs_diff = (new_pss > stable_pss) ? new_pss - stable_pss : stable_pss - new_pss; - // As long as the new pss is within a certain amount, consider everything okay. - ASSERT_LE(abs_diff, MAX_LEAK_BYTES); + if (new_pss > stable_pss) { + ASSERT_LE(new_pss - stable_pss, MAX_LEAK_BYTES); + } } TEST(libbacktrace, check_for_leak_local) {