diff --git a/metrics/counter_test.cc b/metrics/counter_test.cc
index 73a50db4a..c0761e2e7 100644
--- a/metrics/counter_test.cc
+++ b/metrics/counter_test.cc
@@ -7,7 +7,7 @@
#include
#include
#include
-#include
+#include
#include
#include
@@ -15,6 +15,7 @@
#include "counter_mock.h" // For TaggedCounterMock.
#include "metrics_library_mock.h"
+using base::FilePath;
using ::testing::_;
using ::testing::MockFunction;
using ::testing::StrictMock;
@@ -58,7 +59,7 @@ class TaggedCounterTest : public testing::Test {
virtual void TearDown() {
logging::SetLogMessageHandler(NULL);
test_ = NULL;
- file_util::Delete(FilePath(kTestRecordFile), false);
+ base::DeleteFile(FilePath(kTestRecordFile), false);
}
// Asserts that the record file contains the specified contents.
@@ -74,8 +75,8 @@ class TaggedCounterTest : public testing::Test {
}
TaggedCounter::Record record;
- if (!file_util::ReadFromFD(fd, reinterpret_cast(&record),
- sizeof(record))) {
+ if (!base::ReadFromFD(fd, reinterpret_cast(&record),
+ sizeof(record))) {
testing::Message msg;
msg << "Unable to read " << sizeof(record) << " bytes from "
<< kTestRecordFile;
@@ -100,9 +101,9 @@ class TaggedCounterTest : public testing::Test {
bool AssertNoOrEmptyRecordFile() {
FilePath record_file(counter_.filename_);
int64 record_file_size;
- return !file_util::PathExists(record_file) ||
- (file_util::GetFileSize(record_file, &record_file_size) &&
- record_file_size == 0);
+ return !base::PathExists(record_file) ||
+ (base::GetFileSize(record_file, &record_file_size) &&
+ record_file_size == 0);
}
// Adds a reporter call expectation that the specified tag/count
@@ -196,7 +197,7 @@ TEST_F(TaggedCounterTest, BadFileLocation) {
EXPECT_TRUE(LogContains("Unable to open the persistent counter file: "
"No such file or directory"));
EXPECT_EQ(TaggedCounter::kRecordInvalid, counter_.record_state_);
- file_util::Delete(FilePath(kDoesNotExistFile), false);
+ base::DeleteFile(FilePath(kDoesNotExistFile), false);
}
TEST_F(TaggedCounterTest, Flush) {
diff --git a/metrics/libmetrics-180609.gyp b/metrics/libmetrics-180609.gyp
new file mode 100644
index 000000000..4226712c7
--- /dev/null
+++ b/metrics/libmetrics-180609.gyp
@@ -0,0 +1,8 @@
+{
+ 'variables': {
+ 'libbase_ver': 180609,
+ },
+ 'includes': [
+ '../metrics/libmetrics.gypi',
+ ],
+}
diff --git a/metrics/libmetrics-242728.gyp b/metrics/libmetrics-242728.gyp
new file mode 100644
index 000000000..a8b194840
--- /dev/null
+++ b/metrics/libmetrics-242728.gyp
@@ -0,0 +1,8 @@
+{
+ 'variables': {
+ 'libbase_ver': 242728,
+ },
+ 'includes': [
+ '../metrics/libmetrics.gypi',
+ ],
+}
diff --git a/metrics/libmetrics.gypi b/metrics/libmetrics.gypi
new file mode 100644
index 000000000..21af05d4c
--- /dev/null
+++ b/metrics/libmetrics.gypi
@@ -0,0 +1,29 @@
+{
+ 'target_defaults': {
+ 'dependencies': [
+ '../libchromeos/libchromeos-<(libbase_ver).gyp:libchromeos-<(libbase_ver)',
+ ],
+ 'variables': {
+ 'deps': [
+ 'libchrome-<(libbase_ver)',
+ ]
+ },
+ 'cflags_cc': [
+ '-fno-exceptions',
+ ],
+ },
+ 'targets': [
+ {
+ 'target_name': 'libmetrics-<(libbase_ver)',
+ 'type': 'shared_library',
+ 'cflags': [
+ '-fvisibility=default',
+ ],
+ 'sources': [
+ 'c_metrics_library.cc',
+ 'metrics_library.cc',
+ 'timer.cc',
+ ],
+ },
+ ],
+}
diff --git a/metrics/metrics.gyp b/metrics/metrics.gyp
index 9709c35b3..0a5ac48ba 100644
--- a/metrics/metrics.gyp
+++ b/metrics/metrics.gyp
@@ -1,48 +1,32 @@
{
+ 'variables': {
+ 'libbase_ver': 242728,
+ },
'target_defaults': {
- 'dependencies': [
- '../libchromeos/libchromeos-<(libbase_ver).gyp:libchromeos-<(libbase_ver)',
- ],
- 'variables': {
- 'deps': [
- 'dbus-1',
- 'dbus-glib-1',
- 'glib-2.0',
- 'gobject-2.0',
- 'gthread-2.0',
- 'libchrome-<(libbase_ver)',
- ]
- },
- 'cflags_cc': [
- '-fno-exceptions',
- ],
+ 'dependencies': [
+ '../libchromeos/libchromeos-<(libbase_ver).gyp:libchromeos-<(libbase_ver)',
+ ],
+ 'variables': {
+ 'deps': [
+ 'dbus-1',
+ 'dbus-glib-1',
+ 'glib-2.0',
+ 'gobject-2.0',
+ 'gthread-2.0',
+ 'libchrome-<(libbase_ver)',
+ ]
+ },
+ 'cflags_cc': [
+ '-fno-exceptions',
+ ],
},
'targets': [
- {
- 'target_name': 'metrics',
- 'type': 'static_library',
- 'sources': [
- 'c_metrics_library.cc',
- 'metrics_library.cc',
- 'timer.cc',
- ],
- },
- {
- 'target_name': 'libmetrics',
- 'type': 'shared_library',
- 'cflags': [
- '-fvisibility=default',
- ],
- 'sources': [
- 'c_metrics_library.cc',
- 'metrics_library.cc',
- 'timer.cc',
- ],
- },
{
'target_name': 'libmetrics_daemon',
'type': 'static_library',
- 'dependencies': ['libmetrics'],
+ 'dependencies': [
+ '../metrics/libmetrics-<(libbase_ver).gyp:libmetrics-<(libbase_ver)',
+ ],
'link_settings': {
'libraries': [
'-lrootdev',
@@ -58,7 +42,9 @@
{
'target_name': 'metrics_client',
'type': 'executable',
- 'dependencies': ['libmetrics'],
+ 'dependencies': [
+ '../metrics/libmetrics-<(libbase_ver).gyp:libmetrics-<(libbase_ver)',
+ ],
'sources': [
'metrics_client.cc',
]
@@ -79,7 +65,9 @@
{
'target_name': 'metrics_library_test',
'type': 'executable',
- 'dependencies': ['libmetrics'],
+ 'dependencies': [
+ '../metrics/libmetrics-<(libbase_ver).gyp:libmetrics-<(libbase_ver)',
+ ],
'includes': ['../common-mk/common_test.gypi'],
'sources': [
'metrics_library_test.cc',
diff --git a/metrics/metrics_daemon.cc b/metrics/metrics_daemon.cc
index f3849eeef..01fec167d 100644
--- a/metrics/metrics_daemon.cc
+++ b/metrics/metrics_daemon.cc
@@ -11,15 +11,17 @@
#include
#include
-#include
-#include
-#include
-#include
+#include
+#include
+#include
+#include
#include
#include
#include "counter.h"
+using base::FilePath;
+using base::StringPrintf;
using base::Time;
using base::TimeDelta;
using base::TimeTicks;
@@ -528,13 +530,13 @@ void MetricsDaemon::ProcessUncleanShutdown() {
bool MetricsDaemon::CheckSystemCrash(const string& crash_file) {
FilePath crash_detected(crash_file);
- if (!file_util::PathExists(crash_detected))
+ if (!base::PathExists(crash_detected))
return false;
// Deletes the crash-detected file so that the daemon doesn't report
// another kernel crash in case it's restarted.
- file_util::Delete(crash_detected,
- false); // recursive
+ base::DeleteFile(crash_detected,
+ false); // recursive
return true;
}
@@ -706,7 +708,7 @@ bool MetricsDaemon::VmStatsParseStats(const char* stats,
bool MetricsDaemon::VmStatsReadStats(struct VmstatRecord* stats) {
string value_string;
FilePath* path = new FilePath(vmstats_path_);
- if (!file_util::ReadFileToString(*path, &value_string)) {
+ if (!base::ReadFileToString(*path, &value_string)) {
delete path;
LOG(WARNING) << "cannot read " << vmstats_path_;
return false;
@@ -718,11 +720,11 @@ bool MetricsDaemon::VmStatsReadStats(struct VmstatRecord* stats) {
bool MetricsDaemon::ReadFreqToInt(const string& sysfs_file_name, int* value) {
const FilePath sysfs_path(sysfs_file_name);
string value_string;
- if (!file_util::ReadFileToString(sysfs_path, &value_string)) {
+ if (!base::ReadFileToString(sysfs_path, &value_string)) {
LOG(WARNING) << "cannot read " << sysfs_path.value().c_str();
return false;
}
- if (!RemoveChars(value_string, "\n", &value_string)) {
+ if (!base::RemoveChars(value_string, "\n", &value_string)) {
LOG(WARNING) << "no newline in " << value_string;
// Continue even though the lack of newline is suspicious.
}
@@ -901,7 +903,7 @@ gboolean MetricsDaemon::MeminfoCallbackStatic(void* handle) {
bool MetricsDaemon::MeminfoCallback() {
string meminfo_raw;
const FilePath meminfo_path("/proc/meminfo");
- if (!file_util::ReadFileToString(meminfo_path, &meminfo_raw)) {
+ if (!base::ReadFileToString(meminfo_path, &meminfo_raw)) {
LOG(WARNING) << "cannot read " << meminfo_path.value().c_str();
return false;
}
@@ -1051,7 +1053,7 @@ void MetricsDaemon::MemuseCallback() {
bool MetricsDaemon::MemuseCallbackWork() {
string meminfo_raw;
const FilePath meminfo_path("/proc/meminfo");
- if (!file_util::ReadFileToString(meminfo_path, &meminfo_raw)) {
+ if (!base::ReadFileToString(meminfo_path, &meminfo_raw)) {
LOG(WARNING) << "cannot read " << meminfo_path.value().c_str();
return false;
}
diff --git a/metrics/metrics_daemon.h b/metrics/metrics_daemon.h
index 82372f832..6ceb13617 100644
--- a/metrics/metrics_daemon.h
+++ b/metrics/metrics_daemon.h
@@ -9,9 +9,9 @@
#include
#include