openkylin
/
platform_system_core
mirror of https://gitee.com/openkylin/platform_system_core.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

ueventd: fixup ueventd_test.cpp 

Use ASSERT_EQ() instead of EXPECT_EQ() to prevent segfaults after
failed API calls.

Do not run setfscreatecon_IsPerThread unless we're in permissive mode
as it will not pass otherwise.

Test: init unit tests
Change-Id: I70525d438e89f1ec036255890169a50b5007b4c4
This commit is contained in:
Tom Cherry 2017-07-19 14:54:21 -07:00
parent a022ea424d
commit 2ef572be30
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
init/ueventd_test.cpp
View File

@ -63,7 +63,10 @@ void WriteFromMultipleThreads(std::vector<std::pair<std::string, T>>& files_and_
}
TEST(ueventd, setegid_IsPerThread) {
if (getuid() != 0) return;
if (getuid() != 0) {
GTEST_LOG_(INFO) << "Skipping test, must be run as root.";
return;
}
TemporaryDir dir;
@ -78,13 +81,20 @@ TEST(ueventd, setegid_IsPerThread) {
for (const auto& [file, expected_gid] : files_and_gids) {
struct stat info;
EXPECT_EQ(0, stat(file.c_str(), &info));
ASSERT_EQ(0, stat(file.c_str(), &info));
EXPECT_EQ(expected_gid, info.st_gid);
}
}
TEST(ueventd, setfscreatecon_IsPerThread) {
if (getuid() != 0) return;
if (getuid() != 0) {
GTEST_LOG_(INFO) << "Skipping test, must be run as root.";
return;
}
if (!is_selinux_enabled() || security_getenforce() == 1) {
GTEST_LOG_(INFO) << "Skipping test, SELinux must be enabled and in permissive mode.";
return;
}
const char* const contexts[] = {
"u:object_r:audio_device:s0",
@ -105,7 +115,7 @@ TEST(ueventd, setfscreatecon_IsPerThread) {
for (const auto& [file, expected_context] : files_and_contexts) {
char* file_context;
EXPECT_GT(getfilecon(file.c_str(), &file_context), 0);
ASSERT_GT(getfilecon(file.c_str(), &file_context), 0);
EXPECT_EQ(expected_context, file_context);
freecon(file_context);
}