openkylin
/
platform_system_core
mirror of https://gitee.com/openkylin/platform_system_core.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge \"Fix clang-tidy performance warnings in crash_reporter.\" 

am: 5dd9dc5859

Change-Id: Ibc5b64b14e021925187c33ad048f332438309414
This commit is contained in:
Chih-Hung Hsieh 2016-07-28 06:24:21 +00:00 committed by android-build-merger
parent 1cbd1f5016 5dd9dc5859
commit 320f634361
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crash_reporter/crash_collector.cc
View File

@ -317,7 +317,7 @@ bool CrashCollector::CheckHasCapacity(const FilePath &crash_directory) {
continue;
std::string filename(ent->d_name);
size_t last_dot = filename.rfind(".");
size_t last_dot = filename.rfind('.');
std::string basename;
// If there is a valid looking extension, use the base part of the
// name. If the only dot is the first byte (aka a dot file), treat

2
crash_reporter/kernel_collector_test.cc
View File

@ -283,7 +283,7 @@ TEST_F(KernelCollectorTest, CollectOK) {
pos += strlen(kNamePrefix);
std::string filename = log.substr(pos, std::string::npos);
// Take the name up until \n
size_t end_pos = filename.find_first_of("\n");
size_t end_pos = filename.find_first_of('\n');
ASSERT_NE(std::string::npos, end_pos);
filename = filename.substr(0, end_pos);
ASSERT_EQ(0U, filename.find(test_crash_directory().value()));