From 5ba300346706e79cb7afcbe5f6b498df5d696d5c Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Mon, 22 Aug 2016 14:17:58 -0700 Subject: [PATCH] liblog: use SOCK_NONBLOCK directly. No need to have a race, even if it doesn't matter. Change-Id: Ia79f2633643bc63618de0fd85953b3226415484f --- liblog/logd_writer.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/liblog/logd_writer.c b/liblog/logd_writer.c index 059f17034..ed82902b4 100644 --- a/liblog/logd_writer.c +++ b/liblog/logd_writer.c @@ -67,12 +67,9 @@ static int logdOpen() int i, ret = 0; if (logdLoggerWrite.context.sock < 0) { - i = TEMP_FAILURE_RETRY(socket(PF_UNIX, SOCK_DGRAM | SOCK_CLOEXEC, 0)); + i = TEMP_FAILURE_RETRY(socket(PF_UNIX, SOCK_DGRAM | SOCK_CLOEXEC | SOCK_NONBLOCK, 0)); if (i < 0) { ret = -errno; - } else if (TEMP_FAILURE_RETRY(fcntl(i, F_SETFL, O_NONBLOCK)) < 0) { - ret = -errno; - close(i); } else { struct sockaddr_un un; memset(&un, 0, sizeof(struct sockaddr_un));