From 90f5d648489ca8304d7c3ca8995e4e0b9ddab6cb Mon Sep 17 00:00:00 2001 From: Mikhail Lappo Date: Thu, 23 Mar 2017 22:32:30 +0100 Subject: [PATCH] Va_end should be used with va_start va_start is used and va_end should be invoked accordingly Change-Id: Id7037aa8092438b27e445e5147972836602bfd55 --- libpixelflinger/codeflinger/mips64_disassem.c | 1 + libpixelflinger/codeflinger/mips_disassem.c | 1 + libutils/Printer.cpp | 2 ++ 3 files changed, 4 insertions(+) diff --git a/libpixelflinger/codeflinger/mips64_disassem.c b/libpixelflinger/codeflinger/mips64_disassem.c index f28d72627..1856e5c0e 100644 --- a/libpixelflinger/codeflinger/mips64_disassem.c +++ b/libpixelflinger/codeflinger/mips64_disassem.c @@ -555,6 +555,7 @@ static void db_printf(const char* fmt, ...) } else { vprintf(fmt, argp); } + va_end(argp); } /* diff --git a/libpixelflinger/codeflinger/mips_disassem.c b/libpixelflinger/codeflinger/mips_disassem.c index 3007b1534..83a9740ed 100644 --- a/libpixelflinger/codeflinger/mips_disassem.c +++ b/libpixelflinger/codeflinger/mips_disassem.c @@ -562,6 +562,7 @@ static void db_printf(const char* fmt, ...) } else { vprintf(fmt, argp); } + va_end(argp); } diff --git a/libutils/Printer.cpp b/libutils/Printer.cpp index 98cd2c66a..84af2930b 100644 --- a/libutils/Printer.cpp +++ b/libutils/Printer.cpp @@ -47,9 +47,11 @@ void Printer::printFormatLine(const char* format, ...) { #ifndef _WIN32 if (vasprintf(&formattedString, format, arglist) < 0) { // returns -1 on error ALOGE("%s: Failed to format string", __FUNCTION__); + va_end(arglist); return; } #else + va_end(arglist); return; #endif