From 3fa9a59ea323e6b59e1c9292e088071b9e85a4b8 Mon Sep 17 00:00:00 2001 From: Greg Kaiser Date: Tue, 8 Jan 2019 06:29:22 -0800 Subject: [PATCH] debuggerd: Fix return type in error case With our method returning 'bool', a "return -1" is interpretted as 'true'. We change this to an explicit 'false', as desired. Test: TreeHugger Change-Id: I222858b797bc4242a2dc6d4fe81df3d2586d055a --- debuggerd/client/debuggerd_client.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debuggerd/client/debuggerd_client.cpp b/debuggerd/client/debuggerd_client.cpp index 785df99c5..610b96b22 100644 --- a/debuggerd/client/debuggerd_client.cpp +++ b/debuggerd/client/debuggerd_client.cpp @@ -72,7 +72,7 @@ bool debuggerd_trigger_dump(pid_t tid, DebuggerdDumpType dump_type, unsigned int std::string error; if (!android::procinfo::GetProcessInfo(tid, &procinfo, &error)) { LOG(ERROR) << "libdebugged_client: failed to get process info: " << error; - return -1; + return false; } pid = procinfo.pid; }