openkylin
/
platform_system_core
mirror of https://gitee.com/openkylin/platform_system_core.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge "init/service.cpp: fix FD leak for services with consoles"

This commit is contained in:
Treehugger Robot 2016-12-10 22:07:27 +00:00 committed by Gerrit Code Review
parent b0aa8b2369 9596d2b95d
commit 4173d9b57c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
init/service.cpp
View File

@ -567,9 +567,9 @@ bool Service::Start() {
console_ = default_console;
}
bool have_console = (open(console_.c_str(), O_RDWR | O_CLOEXEC) != -1);
bool have_console = (access(console_.c_str(), R_OK | W_OK) != -1);
if (!have_console) {
PLOG(ERROR) << "service '" << name_ << "' couldn't open console '" << console_ << "'";
PLOG(ERROR) << "service '" << name_ << "' cannot gain read/write access to console '" << console_ << "'";
flags_ |= SVC_DISABLED;
return false;
}