From 42a04ac3b464ab425af48a72ab73183938f51fea Mon Sep 17 00:00:00 2001 From: David Anderson Date: Sun, 13 Dec 2020 21:14:45 -0800 Subject: [PATCH] libsnapshot: Don't export snapuserd server includes. Also, move main() to snapuserd_daemon.cpp. Bug: N/A Test: builds Change-Id: Iddeec5785450caa59a7e55daaa63b4584087392e --- fs_mgr/libsnapshot/snapuserd.cpp | 20 ++---------------- .../{include/libsnapshot => }/snapuserd.h | 0 fs_mgr/libsnapshot/snapuserd_daemon.cpp | 21 ++++++++++++++++++- .../libsnapshot => }/snapuserd_daemon.h | 2 +- fs_mgr/libsnapshot/snapuserd_server.cpp | 5 +++-- .../libsnapshot => }/snapuserd_server.h | 2 +- 6 files changed, 27 insertions(+), 23 deletions(-) rename fs_mgr/libsnapshot/{include/libsnapshot => }/snapuserd.h (100%) rename fs_mgr/libsnapshot/{include/libsnapshot => }/snapuserd_daemon.h (96%) rename fs_mgr/libsnapshot/{include/libsnapshot => }/snapuserd_server.h (99%) diff --git a/fs_mgr/libsnapshot/snapuserd.cpp b/fs_mgr/libsnapshot/snapuserd.cpp index 34254a352..4f9480684 100644 --- a/fs_mgr/libsnapshot/snapuserd.cpp +++ b/fs_mgr/libsnapshot/snapuserd.cpp @@ -14,12 +14,11 @@ * limitations under the License. */ +#include "snapuserd.h" + #include -#include #include -#include -#include namespace android { namespace snapshot { @@ -824,18 +823,3 @@ bool Snapuserd::Run() { } // namespace snapshot } // namespace android - -int main([[maybe_unused]] int argc, char** argv) { - android::base::InitLogging(argv, &android::base::KernelLogger); - - android::snapshot::Daemon& daemon = android::snapshot::Daemon::Instance(); - - std::string socket = android::snapshot::kSnapuserdSocket; - if (argc >= 2) { - socket = argv[1]; - } - daemon.StartServer(socket); - daemon.Run(); - - return 0; -} diff --git a/fs_mgr/libsnapshot/include/libsnapshot/snapuserd.h b/fs_mgr/libsnapshot/snapuserd.h similarity index 100% rename from fs_mgr/libsnapshot/include/libsnapshot/snapuserd.h rename to fs_mgr/libsnapshot/snapuserd.h diff --git a/fs_mgr/libsnapshot/snapuserd_daemon.cpp b/fs_mgr/libsnapshot/snapuserd_daemon.cpp index 4c8fa5768..08b5bff04 100644 --- a/fs_mgr/libsnapshot/snapuserd_daemon.cpp +++ b/fs_mgr/libsnapshot/snapuserd_daemon.cpp @@ -14,8 +14,12 @@ * limitations under the License. */ +#include "snapuserd_daemon.h" + #include -#include +#include + +#include "snapuserd_server.h" namespace android { namespace snapshot { @@ -89,3 +93,18 @@ void Daemon::SignalHandler(int signal) { } // namespace snapshot } // namespace android + +int main([[maybe_unused]] int argc, char** argv) { + android::base::InitLogging(argv, &android::base::KernelLogger); + + android::snapshot::Daemon& daemon = android::snapshot::Daemon::Instance(); + + std::string socket = android::snapshot::kSnapuserdSocket; + if (argc >= 2) { + socket = argv[1]; + } + daemon.StartServer(socket); + daemon.Run(); + + return 0; +} diff --git a/fs_mgr/libsnapshot/include/libsnapshot/snapuserd_daemon.h b/fs_mgr/libsnapshot/snapuserd_daemon.h similarity index 96% rename from fs_mgr/libsnapshot/include/libsnapshot/snapuserd_daemon.h rename to fs_mgr/libsnapshot/snapuserd_daemon.h index c6779b817..fc107a31a 100644 --- a/fs_mgr/libsnapshot/include/libsnapshot/snapuserd_daemon.h +++ b/fs_mgr/libsnapshot/snapuserd_daemon.h @@ -16,7 +16,7 @@ #include -#include +#include "snapuserd_server.h" namespace android { namespace snapshot { diff --git a/fs_mgr/libsnapshot/snapuserd_server.cpp b/fs_mgr/libsnapshot/snapuserd_server.cpp index 7a5cead95..9f460c1b3 100644 --- a/fs_mgr/libsnapshot/snapuserd_server.cpp +++ b/fs_mgr/libsnapshot/snapuserd_server.cpp @@ -26,8 +26,9 @@ #include #include -#include -#include + +#include "snapuserd.h" +#include "snapuserd_server.h" namespace android { namespace snapshot { diff --git a/fs_mgr/libsnapshot/include/libsnapshot/snapuserd_server.h b/fs_mgr/libsnapshot/snapuserd_server.h similarity index 99% rename from fs_mgr/libsnapshot/include/libsnapshot/snapuserd_server.h rename to fs_mgr/libsnapshot/snapuserd_server.h index 1491aacb4..6e897aa19 100644 --- a/fs_mgr/libsnapshot/include/libsnapshot/snapuserd_server.h +++ b/fs_mgr/libsnapshot/snapuserd_server.h @@ -28,7 +28,7 @@ #include #include -#include +#include "snapuserd.h" namespace android { namespace snapshot {