From d3c86412adfb3b782ee8b4a70b8c25be5d35138a Mon Sep 17 00:00:00 2001 From: NIEJuhu Date: Sat, 10 Jun 2017 13:20:41 +0800 Subject: [PATCH] libsysutils: Fix vold vulnerability in FrameworkListener Don't release the sender socket when FrameworkListener receives a command that exceed the maximum buffer length Bug: https://issuetracker.google.com/issues/62812018 Test: manual Change-Id: I160f504f3fb902ba25fc79deb8ae7d78d811a807 --- libsysutils/src/FrameworkListener.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libsysutils/src/FrameworkListener.cpp b/libsysutils/src/FrameworkListener.cpp index 1b6076fc8..6f76e7679 100644 --- a/libsysutils/src/FrameworkListener.cpp +++ b/libsysutils/src/FrameworkListener.cpp @@ -68,7 +68,7 @@ bool FrameworkListener::onDataAvailable(SocketClient *c) { android_errorWriteLog(0x534e4554, "29831647"); c->sendMsg(500, "Command too large for buffer", false); mSkipToNextNullByte = true; - return false; + return true; } int offset = 0;