From 4a1bc3824e19a96448470abfb128e109eb704ea6 Mon Sep 17 00:00:00 2001 From: Steve Fung Date: Mon, 14 Sep 2015 02:56:07 -0700 Subject: [PATCH] crash_reporter: Fix a couple crash_sender issues - Added grep to the list of required modules. - Run crash_sender with the 'system' group to allow calls to metrics_client to read both metrics files owned by system and crash_reporter files owned by root. - Fix periodic_scheduler's check delay to actually be 5 minutes. Bug: 23122375 Change-Id: Iff214c4e591a676a516162a92ea5aedcf0824f46 --- crash_reporter/Android.mk | 2 +- crash_reporter/init.crash_reporter.rc | 1 + crash_reporter/periodic_scheduler | 3 +-- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/crash_reporter/Android.mk b/crash_reporter/Android.mk index 467432a19..6cd34ab6f 100644 --- a/crash_reporter/Android.mk +++ b/crash_reporter/Android.mk @@ -81,7 +81,7 @@ include $(CLEAR_VARS) LOCAL_MODULE := crash_sender LOCAL_MODULE_CLASS := EXECUTABLES LOCAL_MODULE_PATH := $(TARGET_OUT_EXECUTABLES) -LOCAL_REQUIRED_MODULES := curl periodic_scheduler +LOCAL_REQUIRED_MODULES := curl grep periodic_scheduler LOCAL_SRC_FILES := crash_sender include $(BUILD_PREBUILT) diff --git a/crash_reporter/init.crash_reporter.rc b/crash_reporter/init.crash_reporter.rc index db9bb6fa1..30e87f5b5 100644 --- a/crash_reporter/init.crash_reporter.rc +++ b/crash_reporter/init.crash_reporter.rc @@ -27,3 +27,4 @@ service crash_reporter /system/bin/crash_reporter --init service crash_sender /system/bin/periodic_scheduler 3600 14400 crash_sender \ /system/bin/crash_sender class late_start + group system diff --git a/crash_reporter/periodic_scheduler b/crash_reporter/periodic_scheduler index 7fdb5c9d0..5408da74c 100755 --- a/crash_reporter/periodic_scheduler +++ b/crash_reporter/periodic_scheduler @@ -22,8 +22,7 @@ set -e -u SCRIPT_NAME="$(basename "$0")" -#CHECK_DELAY=300 # Check every 5 minutes. -CHECK_DELAY=15 # Check every 5 minutes. +CHECK_DELAY=300 # Check every 5 minutes. KILL_DELAY=10 # How long to let the job clean up after a timeout. # Let the unittests override. : ${SPOOL_DIR:=/data/misc/crash_reporter/spool/cron-lite}