openkylin
/
platform_system_core
mirror of https://gitee.com/openkylin/platform_system_core.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge "Check sp<>::clear() for data races"

This commit is contained in:
Hans Boehm 2018-08-17 22:20:39 +00:00 committed by Gerrit Code Review
parent 572d33347b f4f76205fe
commit 59cd823752
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libutils/include/utils/StrongPointer.h
View File

@ -228,8 +228,10 @@ void sp<T>::force_set(T* other) {
template<typename T>
void sp<T>::clear() {
if (m_ptr) {
m_ptr->decStrong(this);
T* oldPtr(*const_cast<T* volatile*>(&m_ptr));
if (oldPtr) {
oldPtr->decStrong(this);
if (oldPtr != *const_cast<T* volatile*>(&m_ptr)) sp_report_race();
m_ptr = nullptr;
}
}