From d5d7abe3d1969ff1848c316c54d3f560947b3626 Mon Sep 17 00:00:00 2001 From: Narayan Kamath Date: Wed, 10 Aug 2016 12:24:05 +0100 Subject: [PATCH] zip_archive: Improve error message on fallocate failure. Noticed on b/30765660. Change-Id: I1a98f83fef02a7368bdc2e1f8f24a0771eebe468 --- libziparchive/zip_archive.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libziparchive/zip_archive.cc b/libziparchive/zip_archive.cc index a2d6fccd1..af6e02c67 100644 --- a/libziparchive/zip_archive.cc +++ b/libziparchive/zip_archive.cc @@ -819,8 +819,9 @@ class FileWriter : public Writer { // disk does not have enough space. result = TEMP_FAILURE_RETRY(fallocate(fd, 0, current_offset, declared_length)); if (result == -1 && errno == ENOSPC) { - ALOGW("Zip: unable to allocate space for file to %" PRId64 ": %s", - static_cast(declared_length + current_offset), strerror(errno)); + ALOGW("Zip: unable to allocate %" PRId64 " bytes at offset %" PRId64 " : %s", + static_cast(declared_length), static_cast(current_offset), + strerror(errno)); return std::unique_ptr(nullptr); } }