diff --git a/include/log/log_read.h b/include/log/log_read.h deleted file mode 100644 index 1b70affc3..000000000 --- a/include/log/log_read.h +++ /dev/null @@ -1,170 +0,0 @@ -/* - * Copyright (C) 2013-2014 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -#ifndef _LIBS_LOG_LOG_READ_H -#define _LIBS_LOG_LOG_READ_H - -#include -#include - -/* struct log_time is a wire-format variant of struct timespec */ -#define NS_PER_SEC 1000000000ULL - -#ifdef __cplusplus - -// NB: do NOT define a copy constructor. This will result in structure -// no longer being compatible with pass-by-value which is desired -// efficient behavior. Also, pass-by-reference breaks C/C++ ABI. -struct log_time { -public: - uint32_t tv_sec; // good to Feb 5 2106 - uint32_t tv_nsec; - - static const uint32_t tv_sec_max = 0xFFFFFFFFUL; - static const uint32_t tv_nsec_max = 999999999UL; - - log_time(const timespec &T) - { - tv_sec = T.tv_sec; - tv_nsec = T.tv_nsec; - } - log_time(uint32_t sec, uint32_t nsec) - { - tv_sec = sec; - tv_nsec = nsec; - } - static const timespec EPOCH; - log_time() - { - } - log_time(clockid_t id) - { - timespec T; - clock_gettime(id, &T); - tv_sec = T.tv_sec; - tv_nsec = T.tv_nsec; - } - log_time(const char *T) - { - const uint8_t *c = (const uint8_t *) T; - tv_sec = c[0] | (c[1] << 8) | (c[2] << 16) | (c[3] << 24); - tv_nsec = c[4] | (c[5] << 8) | (c[6] << 16) | (c[7] << 24); - } - - // timespec - bool operator== (const timespec &T) const - { - return (tv_sec == static_cast(T.tv_sec)) - && (tv_nsec == static_cast(T.tv_nsec)); - } - bool operator!= (const timespec &T) const - { - return !(*this == T); - } - bool operator< (const timespec &T) const - { - return (tv_sec < static_cast(T.tv_sec)) - || ((tv_sec == static_cast(T.tv_sec)) - && (tv_nsec < static_cast(T.tv_nsec))); - } - bool operator>= (const timespec &T) const - { - return !(*this < T); - } - bool operator> (const timespec &T) const - { - return (tv_sec > static_cast(T.tv_sec)) - || ((tv_sec == static_cast(T.tv_sec)) - && (tv_nsec > static_cast(T.tv_nsec))); - } - bool operator<= (const timespec &T) const - { - return !(*this > T); - } - log_time operator-= (const timespec &T); - log_time operator- (const timespec &T) const - { - log_time local(*this); - return local -= T; - } - log_time operator+= (const timespec &T); - log_time operator+ (const timespec &T) const - { - log_time local(*this); - return local += T; - } - - // log_time - bool operator== (const log_time &T) const - { - return (tv_sec == T.tv_sec) && (tv_nsec == T.tv_nsec); - } - bool operator!= (const log_time &T) const - { - return !(*this == T); - } - bool operator< (const log_time &T) const - { - return (tv_sec < T.tv_sec) - || ((tv_sec == T.tv_sec) && (tv_nsec < T.tv_nsec)); - } - bool operator>= (const log_time &T) const - { - return !(*this < T); - } - bool operator> (const log_time &T) const - { - return (tv_sec > T.tv_sec) - || ((tv_sec == T.tv_sec) && (tv_nsec > T.tv_nsec)); - } - bool operator<= (const log_time &T) const - { - return !(*this > T); - } - log_time operator-= (const log_time &T); - log_time operator- (const log_time &T) const - { - log_time local(*this); - return local -= T; - } - log_time operator+= (const log_time &T); - log_time operator+ (const log_time &T) const - { - log_time local(*this); - return local += T; - } - - uint64_t nsec() const - { - return static_cast(tv_sec) * NS_PER_SEC + tv_nsec; - } - - static const char default_format[]; - - // Add %#q for the fraction of a second to the standard library functions - char *strptime(const char *s, const char *format = default_format); -} __attribute__((__packed__)); - -#else - -typedef struct log_time { - uint32_t tv_sec; - uint32_t tv_nsec; -} __attribute__((__packed__)) log_time; - -#endif - -#endif /* define _LIBS_LOG_LOG_READ_H */ diff --git a/include/log/logger.h b/include/log/logger.h index b8d1e79bc..65b38de8d 100644 --- a/include/log/logger.h +++ b/include/log/logger.h @@ -11,16 +11,13 @@ #define _LIBS_LOG_LOGGER_H #include -#ifdef __linux__ -#include /* clockid_t definition */ -#endif +#include #ifdef __cplusplus #include #endif #include -#include #ifdef __cplusplus extern "C" { @@ -80,6 +77,155 @@ struct logger_entry_v4 { char msg[0]; /* the entry's payload */ } __attribute__((__packed__)); +/* struct log_time is a wire-format variant of struct timespec */ +#define NS_PER_SEC 1000000000ULL + +#ifdef __cplusplus + +// NB: do NOT define a copy constructor. This will result in structure +// no longer being compatible with pass-by-value which is desired +// efficient behavior. Also, pass-by-reference breaks C/C++ ABI. +struct log_time { +public: + uint32_t tv_sec; // good to Feb 5 2106 + uint32_t tv_nsec; + + static const uint32_t tv_sec_max = 0xFFFFFFFFUL; + static const uint32_t tv_nsec_max = 999999999UL; + + log_time(const timespec &T) + { + tv_sec = T.tv_sec; + tv_nsec = T.tv_nsec; + } + log_time(uint32_t sec, uint32_t nsec) + { + tv_sec = sec; + tv_nsec = nsec; + } + static const timespec EPOCH; + log_time() + { + } +#ifdef __linux__ + log_time(clockid_t id) + { + timespec T; + clock_gettime(id, &T); + tv_sec = T.tv_sec; + tv_nsec = T.tv_nsec; + } +#endif + log_time(const char *T) + { + const uint8_t *c = (const uint8_t *) T; + tv_sec = c[0] | (c[1] << 8) | (c[2] << 16) | (c[3] << 24); + tv_nsec = c[4] | (c[5] << 8) | (c[6] << 16) | (c[7] << 24); + } + + // timespec + bool operator== (const timespec &T) const + { + return (tv_sec == static_cast(T.tv_sec)) + && (tv_nsec == static_cast(T.tv_nsec)); + } + bool operator!= (const timespec &T) const + { + return !(*this == T); + } + bool operator< (const timespec &T) const + { + return (tv_sec < static_cast(T.tv_sec)) + || ((tv_sec == static_cast(T.tv_sec)) + && (tv_nsec < static_cast(T.tv_nsec))); + } + bool operator>= (const timespec &T) const + { + return !(*this < T); + } + bool operator> (const timespec &T) const + { + return (tv_sec > static_cast(T.tv_sec)) + || ((tv_sec == static_cast(T.tv_sec)) + && (tv_nsec > static_cast(T.tv_nsec))); + } + bool operator<= (const timespec &T) const + { + return !(*this > T); + } + log_time operator-= (const timespec &T); + log_time operator- (const timespec &T) const + { + log_time local(*this); + return local -= T; + } + log_time operator+= (const timespec &T); + log_time operator+ (const timespec &T) const + { + log_time local(*this); + return local += T; + } + + // log_time + bool operator== (const log_time &T) const + { + return (tv_sec == T.tv_sec) && (tv_nsec == T.tv_nsec); + } + bool operator!= (const log_time &T) const + { + return !(*this == T); + } + bool operator< (const log_time &T) const + { + return (tv_sec < T.tv_sec) + || ((tv_sec == T.tv_sec) && (tv_nsec < T.tv_nsec)); + } + bool operator>= (const log_time &T) const + { + return !(*this < T); + } + bool operator> (const log_time &T) const + { + return (tv_sec > T.tv_sec) + || ((tv_sec == T.tv_sec) && (tv_nsec > T.tv_nsec)); + } + bool operator<= (const log_time &T) const + { + return !(*this > T); + } + log_time operator-= (const log_time &T); + log_time operator- (const log_time &T) const + { + log_time local(*this); + return local -= T; + } + log_time operator+= (const log_time &T); + log_time operator+ (const log_time &T) const + { + log_time local(*this); + return local += T; + } + + uint64_t nsec() const + { + return static_cast(tv_sec) * NS_PER_SEC + tv_nsec; + } + + static const char default_format[]; + + // Add %#q for the fraction of a second to the standard library functions + char *strptime(const char *s, const char *format = default_format); +} __attribute__((__packed__)); + +#else + +typedef struct log_time { + uint32_t tv_sec; + uint32_t tv_nsec; +} __attribute__((__packed__)) log_time; + +#endif + /* * The maximum size of the log entry payload that can be * written to the logger. An attempt to write more than @@ -94,8 +240,6 @@ struct logger_entry_v4 { */ #define LOGGER_ENTRY_MAX_LEN (5*1024) -#define NS_PER_SEC 1000000000ULL - struct log_msg { union { unsigned char buf[LOGGER_ENTRY_MAX_LEN + 1]; diff --git a/include/private/android_logger.h b/include/private/android_logger.h index c3ea1ed7b..52ddade65 100644 --- a/include/private/android_logger.h +++ b/include/private/android_logger.h @@ -25,10 +25,14 @@ #include #include -#include +#include #define LOGGER_MAGIC 'l' +#if defined(__cplusplus) +extern "C" { +#endif + /* Header Structure to pstore */ typedef struct __attribute__((__packed__)) { uint8_t magic; @@ -84,6 +88,7 @@ typedef struct __attribute__((__packed__)) { * in C++. * http://stackoverflow.com/questions/4412749/are-flexible-array-members-valid-in-c */ + typedef struct __attribute__((__packed__)) { int8_t type; // EVENT_TYPE_STRING; int32_t length; // Little Endian Order @@ -98,10 +103,6 @@ typedef struct __attribute__((__packed__)) { char data[]; } android_log_event_string_t; -#if defined(__cplusplus) -extern "C" { -#endif - #define ANDROID_LOG_PMSG_FILE_MAX_SEQUENCE 256 /* 1MB file */ #define ANDROID_LOG_PMSG_FILE_SEQUENCE 1000 diff --git a/liblog/Android.bp b/liblog/Android.bp index ba7cc8a76..7f705ed69 100644 --- a/liblog/Android.bp +++ b/liblog/Android.bp @@ -89,7 +89,6 @@ cc_library { ], logtags: ["event.logtags"], compile_multilib: "both", - stl: "none", } ndk_library { diff --git a/liblog/log_time.cpp b/liblog/log_time.cpp index d2bf18166..c8bd27d2d 100644 --- a/liblog/log_time.cpp +++ b/liblog/log_time.cpp @@ -19,7 +19,7 @@ #include #include -#include +#include #include "log_portability.h" diff --git a/liblog/logd_reader.c b/liblog/logd_reader.c index b89434917..2da74ce78 100644 --- a/liblog/logd_reader.c +++ b/liblog/logd_reader.c @@ -34,7 +34,6 @@ #include #include #include -#include #include #include diff --git a/liblog/logd_writer.c b/liblog/logd_writer.c index ed82902b4..171647b25 100644 --- a/liblog/logd_writer.c +++ b/liblog/logd_writer.c @@ -34,7 +34,6 @@ #include #include #include -#include #include #include diff --git a/liblog/logger.h b/liblog/logger.h index 2a4cfcb56..8367f445e 100644 --- a/liblog/logger.h +++ b/liblog/logger.h @@ -22,7 +22,6 @@ #include #include -#include #include #include "log_portability.h" diff --git a/liblog/logger_write.c b/liblog/logger_write.c index 08e634892..72673e08f 100644 --- a/liblog/logger_write.c +++ b/liblog/logger_write.c @@ -27,7 +27,6 @@ #include #include #include -#include #include #include diff --git a/liblog/tests/liblog_benchmark.cpp b/liblog/tests/liblog_benchmark.cpp index f4e3089f6..22404d180 100644 --- a/liblog/tests/liblog_benchmark.cpp +++ b/liblog/tests/liblog_benchmark.cpp @@ -23,7 +23,6 @@ #include #include #include -#include #include #include "benchmark.h" diff --git a/liblog/tests/liblog_test.cpp b/liblog/tests/liblog_test.cpp index b3b44e332..cb9a5223f 100644 --- a/liblog/tests/liblog_test.cpp +++ b/liblog/tests/liblog_test.cpp @@ -26,7 +26,6 @@ #include #include #include -#include #include #include #include diff --git a/logcat/logcat.cpp b/logcat/logcat.cpp index 7e2bac779..468b13f01 100644 --- a/logcat/logcat.cpp +++ b/logcat/logcat.cpp @@ -32,7 +32,6 @@ #include #include #include -#include #include #include #include diff --git a/logcat/tests/logcat_test.cpp b/logcat/tests/logcat_test.cpp index 3daee134e..269bcc8a0 100644 --- a/logcat/tests/logcat_test.cpp +++ b/logcat/tests/logcat_test.cpp @@ -29,7 +29,6 @@ #include #include #include -#include #define BIG_BUFFER (5 * 1024) diff --git a/logd/FlushCommand.h b/logd/FlushCommand.h index 7172d5fc8..a6cdf9dc2 100644 --- a/logd/FlushCommand.h +++ b/logd/FlushCommand.h @@ -16,7 +16,7 @@ #ifndef _FLUSH_COMMAND_H #define _FLUSH_COMMAND_H -#include +#include #include class LogBufferElement; diff --git a/logd/LogBuffer.h b/logd/LogBuffer.h index 162c189dd..871e6bbf9 100644 --- a/logd/LogBuffer.h +++ b/logd/LogBuffer.h @@ -119,7 +119,7 @@ public: unsigned long getSize(log_id_t id); int setSize(log_id_t id, unsigned long size); unsigned long getSizeUsed(log_id_t id); - // *strp uses malloc, use free to release. + std::string formatStatistics(uid_t uid, pid_t pid, unsigned int logMask); void enableStatistics() { diff --git a/logd/LogBufferElement.h b/logd/LogBufferElement.h index e7f88b94d..5a60c4dad 100644 --- a/logd/LogBufferElement.h +++ b/logd/LogBufferElement.h @@ -23,7 +23,7 @@ #include #include -#include +#include class LogBuffer; diff --git a/logd/LogKlog.h b/logd/LogKlog.h index ee73b7187..6e150e72a 100644 --- a/logd/LogKlog.h +++ b/logd/LogKlog.h @@ -17,8 +17,8 @@ #ifndef _LOGD_LOG_KLOG_H__ #define _LOGD_LOG_KLOG_H__ +#include #include -#include char *log_strntok_r(char *s, size_t *len, char **saveptr, size_t *sublen);