Revert "Revert "init: warn slow action""

This reverts commit 1802d11cc7.

Test: grep init log
Bug: 32712851
This commit is contained in:
Wei Wang 2016-11-15 23:58:55 -08:00
parent 0673412bb9
commit 8b1d526a72
1 changed files with 5 additions and 3 deletions

View File

@ -118,14 +118,16 @@ void Action::ExecuteCommand(const Command& command) const {
Timer t;
int result = command.InvokeFunc();
// TODO: this should probably be changed to "if (failed || took a long time)"...
if (android::base::GetMinimumLogSeverity() <= android::base::DEBUG) {
double duration_ms = t.duration() * 1000;
// Any action longer than 50ms will be warned to user as slow operation
if (duration_ms > 50.0 ||
android::base::GetMinimumLogSeverity() <= android::base::DEBUG) {
std::string trigger_name = BuildTriggersString();
std::string cmd_str = command.BuildCommandString();
std::string source = command.BuildSourceString();
LOG(INFO) << "Command '" << cmd_str << "' action=" << trigger_name << source
<< " returned " << result << " took " << t.duration() << "s";
<< " returned " << result << " took " << duration_ms << "ms.";
}
}