openkylin
/
platform_system_core
mirror of https://gitee.com/openkylin/platform_system_core.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

libcutils: bug str_parms.c:str_parms_get_float(). 

str_parms_get_float did not return the output into
*val. Only output if returning with no error. Audit
shows no internal users of this library function

Change-Id: I14a3f08a098072a159dd93f85ead36b3f445816f
This commit is contained in:
Mark Salyzyn 2013-11-22 07:38:46 -08:00
parent ba02cd1e9b
commit 8e71ddeac0
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libcutils/str_parms.c
View File

@ -1,5 +1,5 @@
/*
* Copyright (C) 2011 The Android Open Source Project
* Copyright (C) 2011-2013 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -280,10 +280,11 @@ int str_parms_get_float(struct str_parms *str_parms, const char *key,
return -ENOENT;
out = strtof(value, &end);
if (*value != '\0' && *end == '\0')
return 0;
if (*value == '\0' || *end != '\0')
return -EINVAL;
return -EINVAL;
*val = out;
return 0;
}
static bool combine_strings(void *key, void *value, void *context)