openkylin
/
platform_system_core
mirror of https://gitee.com/openkylin/platform_system_core.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Improve error message for unknown struct members 

We now customize the error message to correctly refer to the '.' or
'->' operator , whichever one is actually being used when the error
occurs.
This commit is contained in:
Jack Palevich 2009-09-04 15:34:21 -07:00
parent 5fd66ae01e
commit 8fe5dcac34
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libacc/acc.cpp
View File

@ -4527,7 +4527,7 @@ class Compiler : public ErrorSink {
pGen->forceR0RVal();
Type* pStruct = pGen->getR0Type();
if (pStruct->tag == TY_STRUCT) {
doStructMember(pStruct);
doStructMember(pStruct, true);
} else {
error("expected a struct value to the left of '.'");
}
@ -4536,7 +4536,7 @@ class Compiler : public ErrorSink {
Type* pPtr = pGen->getR0Type();
if (pPtr->tag == TY_POINTER && pPtr->pHead->tag == TY_STRUCT) {
pGen->loadR0FromR0();
doStructMember(pPtr->pHead);
doStructMember(pPtr->pHead, false);
} else {
error("Expected a pointer to a struct to the left of '->'");
}
@ -4602,7 +4602,7 @@ class Compiler : public ErrorSink {
}
}
void doStructMember(Type* pStruct) {
void doStructMember(Type* pStruct, bool isDot) {
Type* pStructElement = lookupStructMember(pStruct, tok);
if (pStructElement) {
next();
@ -4610,7 +4610,8 @@ class Compiler : public ErrorSink {
} else {
String buf;
decodeToken(buf, tok, true);
error("Expected a struct member to the right of '.', got %s", buf.getUnwrapped());
error("Expected a struct member to the right of '%s', got %s",
isDot ? "." : "->", buf.getUnwrapped());
}
}