From 422367b97f5e3abcf8e4552fddf12f35e18e66f9 Mon Sep 17 00:00:00 2001 From: Steven Moreland Date: Tue, 6 Mar 2018 14:57:46 -0800 Subject: [PATCH] init: use FQName parse FQName::FQName(string) could leave the FQName in an invalid state, and so this constructor is being removed and the mValid member is being removed. Bug: 73774955 Test: boots + interface_start control messages received by init Change-Id: I58d4a089c0a0f1c2cc5129c5e87321e7f6663b72 --- init/service.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/init/service.cpp b/init/service.cpp index 8130e73a9..964393f12 100644 --- a/init/service.cpp +++ b/init/service.cpp @@ -446,8 +446,8 @@ Result Service::ParseInterface(const std::vector& args) { const std::string& interface_name = args[1]; const std::string& instance_name = args[2]; - const FQName fq_name = FQName(interface_name); - if (!fq_name.isValid()) { + FQName fq_name; + if (!FQName::parse(interface_name, &fq_name)) { return Error() << "Invalid fully-qualified name for interface '" << interface_name << "'"; }