diff --git a/include/utils/BackupHelpers.h b/include/utils/BackupHelpers.h index 1d0daa741..f60f4ead6 100644 --- a/include/utils/BackupHelpers.h +++ b/include/utils/BackupHelpers.h @@ -128,6 +128,7 @@ int backup_helper_test_empty(); int backup_helper_test_four(); int backup_helper_test_files(); int backup_helper_test_null_base(); +int backup_helper_test_missing_file(); int backup_helper_test_data_writer(); int backup_helper_test_data_reader(); #endif diff --git a/libs/utils/BackupHelpers.cpp b/libs/utils/BackupHelpers.cpp index ffe4dff9f..4c3e37dd1 100644 --- a/libs/utils/BackupHelpers.cpp +++ b/libs/utils/BackupHelpers.cpp @@ -64,6 +64,7 @@ struct FileState { struct FileRec { char const* file; // this object does not own this string + bool deleted; FileState s; }; @@ -135,18 +136,23 @@ read_snapshot_file(int fd, KeyedVector* snapshot) static int write_snapshot_file(int fd, const KeyedVector& snapshot) { + int fileCount = 0; int bytesWritten = sizeof(SnapshotHeader); // preflight size const int N = snapshot.size(); for (int i=0; i& snapshot) return errno; } - for (int i=0; i= 0) { - LOGP("back_up_files key already in use '%s'", key.string()); - return -1; + if (newSnapshot.indexOfKey(key) >= 0) { + LOGP("back_up_files key already in use '%s'", key.string()); + return -1; + } } newSnapshot.add(key, r); } @@ -331,24 +340,24 @@ back_up_files(int oldSnapshotFD, BackupDataWriter* dataStream, int newSnapshotFD while (n 0) { + if (g.deleted || cmp < 0) { + // file removed + LOGP("file removed: %s", p.string()); + g.deleted = true; // They didn't mention the file, but we noticed that it's gone. + dataStream->WriteEntityHeader(p, -1); + n++; + } + else if (cmp > 0) { // file added - const FileRec& g = newSnapshot.valueAt(m); LOGP("file added: %s", g.file); write_update_file(dataStream, q, g.file); m++; } - else if (cmp < 0) { - // file removed - LOGP("file removed: %s", p.string()); - dataStream->WriteEntityHeader(p, -1); - n++; - } else { // both files exist, check them const FileState& f = oldSnapshot.valueAt(n); - FileRec& g = newSnapshot.editValueAt(m); int fd = open(g.file, O_RDONLY); if (fd < 0) { @@ -550,6 +559,7 @@ backup_helper_test_four() String8 filenames[4]; FileState states[4]; FileRec r; + r.deleted = false; r.file = NULL; states[0].modTime_sec = 0xfedcba98; @@ -1149,6 +1159,59 @@ backup_helper_test_null_base() return 0; } +int +backup_helper_test_missing_file() +{ + int err; + int oldSnapshotFD; + int dataStreamFD; + int newSnapshotFD; + + system("rm -r " SCRATCH_DIR); + mkdir(SCRATCH_DIR, 0777); + mkdir(SCRATCH_DIR "data", 0777); + + write_text_file(SCRATCH_DIR "data/b", "b\nbb\n"); + + char const* files[] = { + SCRATCH_DIR "data/a", + SCRATCH_DIR "data/b", + SCRATCH_DIR "data/c", + }; + + char const* keys[] = { + "a", + "b", + "c", + }; + + dataStreamFD = creat(SCRATCH_DIR "null_base.data", 0666); + if (dataStreamFD == -1) { + fprintf(stderr, "error creating: %s\n", strerror(errno)); + return errno; + } + + newSnapshotFD = creat(SCRATCH_DIR "null_base.snap", 0666); + if (newSnapshotFD == -1) { + fprintf(stderr, "error creating: %s\n", strerror(errno)); + return errno; + } + + { + BackupDataWriter dataStream(dataStreamFD); + + err = back_up_files(-1, &dataStream, newSnapshotFD, files, keys, 1); + if (err != 0) { + return err; + } + } + + close(dataStreamFD); + close(newSnapshotFD); + + return 0; +} + #endif // TEST_BACKUP_HELPERS