Merge "Remove ACgroupController_getFlags to fix API breakage"

This commit is contained in:
Treehugger Robot 2019-06-18 01:26:31 +00:00 committed by Gerrit Code Review
commit ad6f656be2
4 changed files with 3 additions and 17 deletions

View File

@ -70,8 +70,8 @@ bool CgroupController::HasValue() const {
bool CgroupController::IsUsable() const {
if (!HasValue()) return false;
uint32_t flags = ACgroupController_getFlags(controller_);
return (flags & CGROUPRC_CONTROLLER_FLAG_MOUNTED) != 0;
static bool enabled = (access(GetProcsFilePath("", 0, 0).c_str(), F_OK) == 0);
return enabled;
}
std::string CgroupController::GetTasksFilePath(const std::string& rel_path) const {
@ -160,7 +160,6 @@ void CgroupMap::Print() const {
const ACgroupController* controller = ACgroupFile_getController(i);
LOG(INFO) << "\t" << ACgroupController_getName(controller) << " ver "
<< ACgroupController_getVersion(controller) << " path "
<< ACgroupController_getFlags(controller) << " flags "
<< ACgroupController_getPath(controller);
}
}

View File

@ -27,11 +27,6 @@ uint32_t ACgroupController_getVersion(const ACgroupController* controller) {
return controller->version();
}
uint32_t ACgroupController_getFlags(const ACgroupController* controller) {
CHECK(controller != nullptr);
return controller->flags();
}
const char* ACgroupController_getName(const ACgroupController* controller) {
CHECK(controller != nullptr);
return controller->name();

View File

@ -66,17 +66,10 @@ __attribute__((warn_unused_result)) uint32_t ACgroupController_getVersion(const
__INTRODUCED_IN(29);
/**
* Flag bitmask used in ACgroupController_getFlags
* Flag bitmask to be used when ACgroupController_getFlags can be exported
*/
#define CGROUPRC_CONTROLLER_FLAG_MOUNTED 0x1
/**
* Returns the flags bitmask of the given controller.
* If the given controller is null, return 0.
*/
__attribute__((warn_unused_result)) uint32_t ACgroupController_getFlags(const ACgroupController*)
__INTRODUCED_IN(29);
/**
* Returns the name of the given controller.
* If the given controller is null, return nullptr.

View File

@ -4,7 +4,6 @@ LIBCGROUPRC { # introduced=29
ACgroupFile_getControllerCount;
ACgroupFile_getController;
ACgroupController_getVersion;
ACgroupController_getFlags;
ACgroupController_getName;
ACgroupController_getPath;
local: