Merge "Flattenable: switch from assignment to memcpy()."

This commit is contained in:
David Pursell 2016-09-23 22:46:03 +00:00 committed by Gerrit Code Review
commit b2356a6993
1 changed files with 9 additions and 2 deletions

View File

@ -19,10 +19,13 @@
#include <stdint.h>
#include <string.h>
#include <sys/types.h>
#include <utils/Errors.h>
#include <utils/Debug.h>
#include <type_traits>
namespace android {
@ -60,14 +63,18 @@ public:
// write a POD structure
template<typename T>
static void write(void*& buffer, size_t& size, const T& value) {
*static_cast<T*>(buffer) = value;
static_assert(std::is_trivially_copyable<T>::value,
"Cannot flatten a non-trivially-copyable type");
memcpy(buffer, &value, sizeof(T));
advance(buffer, size, sizeof(T));
}
// read a POD structure
template<typename T>
static void read(void const*& buffer, size_t& size, T& value) {
value = *static_cast<T const*>(buffer);
static_assert(std::is_trivially_copyable<T>::value,
"Cannot unflatten a non-trivially-copyable type");
memcpy(&value, buffer, sizeof(T));
advance(buffer, size, sizeof(T));
}
};