logd: Adjust to match defacto coding style

(cherry picked from commit c46f77bd2a)

Change-Id: I80685cdc7116e10c5a5a77abe856fd96804f9117
This commit is contained in:
Mark Salyzyn 2014-02-18 11:23:53 -08:00
parent 740f9b4f97
commit c03e72cc1c
5 changed files with 11 additions and 13 deletions

View File

@ -63,7 +63,7 @@ void FlushCommand::runSocketCommand(SocketClient *client) {
}
if (it == times.end()) {
/* Create LogTimeEntry in notifyNewLog() ? */
// Create LogTimeEntry in notifyNewLog() ?
if (mTail == (unsigned long) -1) {
LogTimeEntry::unlock();
return;
@ -74,7 +74,7 @@ void FlushCommand::runSocketCommand(SocketClient *client) {
client->incRef();
/* release client and entry reference counts once done */
// release client and entry reference counts once done
entry->startReader_Locked();
LogTimeEntry::unlock();
}

View File

@ -52,11 +52,12 @@ void LogBuffer::log(log_id_t log_id, struct timespec realtime,
LogBufferElementCollection::iterator it = mLogElements.end();
LogBufferElementCollection::iterator last = it;
while (--it != mLogElements.begin()) {
if ((*it)->getRealTime() <= elem->getRealTime()) {
if ((*it)->getRealTime() <= realtime) {
break;
}
last = it;
}
if (last == mLogElements.end()) {
mLogElements.push_back(elem);
} else {
@ -83,7 +84,7 @@ void LogBuffer::log(log_id_t log_id, struct timespec realtime,
}
if (end_always
|| (end_set && (end >= (*last)->getMonotonicTime()))) {
|| (end_set && (end >= (*last)->getMonotonicTime()))) {
mLogElements.push_back(elem);
} else {
mLogElements.insert(last,elem);

View File

@ -16,6 +16,6 @@
#include "LogCommand.h"
LogCommand::LogCommand(const char *cmd) :
FrameworkCommand(cmd) {
LogCommand::LogCommand(const char *cmd)
: FrameworkCommand(cmd) {
}

View File

@ -160,7 +160,7 @@ bool LogTimeEntry::FilterFirstPass(const LogBufferElement *element, void *obj) {
}
if ((!me->mPid || (me->mPid == element->getPid()))
&& (me->mLogMask & (1 << element->getLogId()))) {
&& (me->mLogMask & (1 << element->getLogId()))) {
++me->mCount;
}

View File

@ -59,16 +59,14 @@ public:
void startReader_Locked(void);
bool runningReader_Locked(void) const
{
bool runningReader_Locked(void) const {
return threadRunning || mRelease || mError || mNonBlock;
}
void triggerReader_Locked(void) { threadTriggered = true; }
void triggerSkip_Locked(unsigned int skip) { skipAhead = skip; }
// Called after LogTimeEntry removed from list, lock implicitly held
void release_Locked(void)
{
void release_Locked(void) {
mRelease = true;
if (mRefCount || threadRunning) {
return;
@ -89,8 +87,7 @@ public:
bool owned_Locked(void) const { return mRefCount != 0; }
void decRef_Locked(void)
{
void decRef_Locked(void) {
if ((mRefCount && --mRefCount) || !mRelease || threadRunning) {
return;
}