From 09175a0264d86b6e0cae9324cd95aef0711ae560 Mon Sep 17 00:00:00 2001 From: George Burgess IV Date: Wed, 25 Jan 2017 17:25:57 -0800 Subject: [PATCH] Add mode bits to a call to open with O_CREAT Open with O_CREAT needs mode bits: https://linux.die.net/man/3/open Found by running clang FORTIFY over AOSP. Bug: 32073964 Test: Now builds with clang FORTIFY. Change-Id: Iee4c93c5482f510e0adf8104c27e394b5d87ec88 --- libcutils/fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libcutils/fs.c b/libcutils/fs.c index 488fdfc28..b253b1cd9 100644 --- a/libcutils/fs.c +++ b/libcutils/fs.c @@ -80,7 +80,7 @@ static int fs_prepare_path_impl(const char* path, mode_t mode, uid_t uid, gid_t create: create_result = prepare_as_dir ? TEMP_FAILURE_RETRY(mkdir(path, mode)) - : TEMP_FAILURE_RETRY(open(path, O_CREAT | O_CLOEXEC | O_NOFOLLOW | O_RDONLY)); + : TEMP_FAILURE_RETRY(open(path, O_CREAT | O_CLOEXEC | O_NOFOLLOW | O_RDONLY, 0644)); if (create_result == -1) { if (errno != EEXIST) { ALOGE("Failed to %s(%s): %s",