From d6f2e696245993da4211f8a67e8c2463fd6c7a78 Mon Sep 17 00:00:00 2001 From: George Burgess IV Date: Wed, 8 Feb 2017 23:40:34 -0800 Subject: [PATCH] Add permission bits to open() with O_CREAT. It's an error to pass open O_CREAT without giving it mode bits: https://linux.die.net/man/3/open Bug: 32073964 Test: Compiles with clang FORTIFY. Change-Id: I6b2a3694f85565afdeb782585c6af36e8c4d1557 --- libappfuse/tests/FuseBufferTest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libappfuse/tests/FuseBufferTest.cc b/libappfuse/tests/FuseBufferTest.cc index db35d330d..1a1abd57e 100644 --- a/libappfuse/tests/FuseBufferTest.cc +++ b/libappfuse/tests/FuseBufferTest.cc @@ -31,7 +31,7 @@ namespace fuse { constexpr char kTempFile[] = "/data/local/tmp/appfuse_test_dump"; void OpenTempFile(android::base::unique_fd* fd) { - fd->reset(open(kTempFile, O_CREAT | O_RDWR)); + fd->reset(open(kTempFile, O_CREAT | O_RDWR, 0600)); ASSERT_NE(-1, *fd) << strerror(errno); unlink(kTempFile); ASSERT_NE(-1, *fd) << strerror(errno);