Merge "Disallow operator!() on unique_fd"

am: 0a887aa14c

Change-Id: I76c4bf585d1082e08cd01ba59b6b25b26c16ddad

base/include/android-base/unique_fd.h

@@ -105,6 +105,9 @@ class unique_fd_impl final {
   int get() const { return fd_; }
   operator int() const { return get(); }  // NOLINT
 
+  // Catch bogus error checks (i.e.: "!fd" instead of "fd != -1").
+  bool operator!() const = delete;
+
   int release() __attribute__((warn_unused_result)) {
     tag(fd_, this, nullptr);
     int ret = fd_;

init/service.cpp

@@ -177,7 +177,7 @@ Result<Success> Service::SetUpPidNamespace() const {
 Result<Success> Service::EnterNamespaces() const {
     for (const auto& [nstype, path] : namespaces_to_enter_) {
         auto fd = unique_fd{open(path.c_str(), O_RDONLY | O_CLOEXEC)};
-        if (!fd) {
+        if (fd == -1) {
             return ErrnoError() << "Could not open namespace at " << path;
         }
         if (setns(fd, nstype) == -1) {