From c75a02fe3f9abec006a1e88794f2fa12fbeafd8f Mon Sep 17 00:00:00 2001 From: Brigid Smith Date: Thu, 17 Jul 2014 14:52:33 -0700 Subject: [PATCH] Added default constructor for log_t. Bug: 16357258 Change-Id: I39169b35653d2b717fadbcff75978db01cc375ef --- debuggerd/utility.cpp | 2 ++ debuggerd/utility.h | 7 +++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/debuggerd/utility.cpp b/debuggerd/utility.cpp index a1633448a..9a30fe3de 100644 --- a/debuggerd/utility.cpp +++ b/debuggerd/utility.cpp @@ -59,6 +59,8 @@ bool is_allowed_in_logcat(enum logtype ltype) { void _LOG(log_t* log, enum logtype ltype, const char* fmt, ...) { bool write_to_tombstone = (log->tfd != -1); bool write_to_logcat = is_allowed_in_logcat(ltype) + && log->crashed_tid != -1 + && log->current_tid != -1 && (log->crashed_tid == log->current_tid); bool write_to_activitymanager = (log->amfd != -1); diff --git a/debuggerd/utility.h b/debuggerd/utility.h index 518305dc5..31684ce50 100644 --- a/debuggerd/utility.h +++ b/debuggerd/utility.h @@ -37,7 +37,7 @@ #endif -typedef struct { +struct log_t{ /* tombstone file descriptor */ int tfd; /* Activity Manager socket file descriptor */ @@ -46,7 +46,10 @@ typedef struct { pid_t crashed_tid; // The tid of the thread we are currently working with. pid_t current_tid; -} log_t; + + log_t() + : tfd(-1), amfd(-1), crashed_tid(-1), current_tid(-1) {} +}; // List of types of logs to simplify the logging decision in _LOG enum logtype {