From 919f538e6d2c9aa45034f4232e38f9e811eec6d8 Mon Sep 17 00:00:00 2001 From: Mark Salyzyn Date: Sun, 4 Feb 2018 15:27:23 -0800 Subject: [PATCH] lmkd: use after free Remove a use-after free reference of procp->pid, using the already captured pid variable. Test: lmkd_unit_tests Bug: 33808187 Change-Id: I3f5f8dd9acab2e28c81465d6195b73ae47e0a3c4 --- lmkd/lmkd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lmkd/lmkd.c b/lmkd/lmkd.c index b486a17c7..15471e0cc 100644 --- a/lmkd/lmkd.c +++ b/lmkd/lmkd.c @@ -615,11 +615,11 @@ static int kill_one_process(struct proc* procp, int min_score_adj, bool is_criti pid_remove(pid); if (r) { - ALOGE("kill(%d): errno=%d", procp->pid, errno); + ALOGE("kill(%d): errno=%d", pid, errno); return -1; - } else { - return tasksize; } + + return tasksize; } /*