From d233c2752bfa96d5fc55c6d45622f64a48288cce Mon Sep 17 00:00:00 2001 From: Colin Cross Date: Sat, 17 Dec 2016 13:34:05 -0800 Subject: [PATCH] Remove obsolete mentions of LLVM_HOST_BUILD_MK The libbacktrace common flags don't need the flags from LLVM_HOST_BUILD_MK, they are added directly to libbacktrace_offline. The -fno-omit-frame-pointer is unnecessary, as we no longer import flags only used to build LLVM into everything that depends on LLVM. Removing -Wno-extern-c-compat doesn't cause any warnings. Test: mma -j Change-Id: Ia01380e8572c3d84268843291a54ec8c932a327f --- libbacktrace/Android.bp | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/libbacktrace/Android.bp b/libbacktrace/Android.bp index 684e611a7..5b31ecb9f 100644 --- a/libbacktrace/Android.bp +++ b/libbacktrace/Android.bp @@ -27,22 +27,8 @@ cc_defaults { include_dirs: ["external/libunwind/include/tdep"], - // TODO: LLVM_DEVICE_BUILD_MK - // TODO: LLVM_HOST_BUILD_MK target: { - host: { - // -fno-omit-frame-pointer should be set for host build. Because currently - // libunwind can't recognize .debug_frame using dwarf version 4, and it relies - // on stack frame pointer to do unwinding on x86. - // $(LLVM_HOST_BUILD_MK) overwrites -fno-omit-frame-pointer. so the below line - // must be after the include. - cflags: [ - "-Wno-extern-c-compat", - "-fno-omit-frame-pointer", - ], - }, - darwin: { enabled: false, },