openkylin
/
platform_system_core
mirror of https://gitee.com/openkylin/platform_system_core.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

libchromeos: void OsReleaseReader.Load() 

Previously OsReleaseReader returned a bool, which meant that code that
called load wanted to CHECK the return values and possibly log warning
messages, etc. This was unecessary since OsReleaseReader.Load never
returns false.

TEST=unittests
BUG=none

Change-Id: I7064c6a788897b5d5c687d6c9c5f4e03d4ca21a7
Reviewed-on: https://chromium-review.googlesource.com/223990
Reviewed-by: Bertrand Simonnet <bsimonnet@google.com>
Commit-Queue: Nathan Bullock <nathanbullock@google.com>
Tested-by: Nathan Bullock <nathanbullock@google.com>
This commit is contained in:
Nathan Bullock 2014-10-17 10:03:52 -04:00 committed by chrome-internal-fetch
parent cac74e122f
commit d78f3df6bc
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
metrics/uploader/system_profile_cache.cc
View File

@ -150,10 +150,9 @@ bool SystemProfileCache::GetProductId(int* product_id) const {
chromeos::OsReleaseReader reader;
if (testing_) {
base::FilePath root(config_root_);
CHECK(reader.LoadTestingOnly(root)) << "Failed to load os-release fields "
"from" << root.value();
reader.LoadTestingOnly(root);
} else {
CHECK(reader.Load()) << "Failed to load os-release fields.";
reader.Load();
}
std::string id;