From 60f21a7f61479fd5215ee8ec8b63ac438be3e5d7 Mon Sep 17 00:00:00 2001 From: Stephen Hines Date: Wed, 26 Nov 2014 01:06:01 -0800 Subject: [PATCH] Fix incorrect path name check. This was caught by clang 3.6's -Wpointer-bool-conversion. The device_path field is a char[256], and thus never NULL. The intention for this code was to check whether or not there is a named path at all. Checking whether this is an empty string matches the original intent. Change-Id: I5ccedc03167e6a457e472089de26130aff7f96e3 --- fastboot/fastboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fastboot/fastboot.c b/fastboot/fastboot.c index 43d05aa3e..ddd3aa5c7 100644 --- a/fastboot/fastboot.c +++ b/fastboot/fastboot.c @@ -244,7 +244,7 @@ int list_devices_callback(usb_ifc_info *info) // output compatible with "adb devices" if (!long_listing) { printf("%s\tfastboot\n", serial); - } else if (!info->device_path) { + } else if (!strcmp("", info->device_path)) { printf("%-22s fastboot\n", serial); } else { printf("%-22s fastboot %s\n", serial, info->device_path);