diff --git a/bootstat/Android.bp b/bootstat/Android.bp index 5e2d171ff..edff26df5 100644 --- a/bootstat/Android.bp +++ b/bootstat/Android.bp @@ -30,8 +30,8 @@ cc_defaults { "libbase", "libcutils", "liblog", - "libmetricslogger", ], + static_libs: ["libgtest_prod"], } // bootstat static library diff --git a/bootstat/boot_event_record_store.h b/bootstat/boot_event_record_store.h index f872c85c8..e8523048f 100644 --- a/bootstat/boot_event_record_store.h +++ b/bootstat/boot_event_record_store.h @@ -69,4 +69,4 @@ class BootEventRecordStore { DISALLOW_COPY_AND_ASSIGN(BootEventRecordStore); }; -#endif // BOOT_EVENT_RECORD_STORE_H_ \ No newline at end of file +#endif // BOOT_EVENT_RECORD_STORE_H_ diff --git a/bootstat/bootstat.cpp b/bootstat/bootstat.cpp index 6409db0d5..c5fc154ad 100644 --- a/bootstat/bootstat.cpp +++ b/bootstat/bootstat.cpp @@ -44,7 +44,6 @@ #include #include #include -#include #include #include "boot_event_record_store.h" @@ -57,9 +56,10 @@ void LogBootEvents() { BootEventRecordStore boot_event_store; auto events = boot_event_store.GetAllBootEvents(); - for (auto i = events.cbegin(); i != events.cend(); ++i) { - android::metricslogger::LogHistogram(i->first, i->second); - } + // TODO(b/148575354): Replace with statsd. + // for (auto i = events.cbegin(); i != events.cend(); ++i) { + // android::metricslogger::LogHistogram(i->first, i->second); + // } } // Records the named boot |event| to the record store. If |value| is non-empty @@ -1212,13 +1212,17 @@ void RecordBootReason() { const auto reason = android::base::GetProperty(bootloader_reboot_reason_property, ""); if (reason.empty()) { + // TODO(b/148575354): Replace with statsd. // Log an empty boot reason value as '' to ensure the value is intentional // (and not corruption anywhere else in the reporting pipeline). - android::metricslogger::LogMultiAction(android::metricslogger::ACTION_BOOT, - android::metricslogger::FIELD_PLATFORM_REASON, ""); + // android::metricslogger::LogMultiAction(android::metricslogger::ACTION_BOOT, + // android::metricslogger::FIELD_PLATFORM_REASON, + // ""); } else { - android::metricslogger::LogMultiAction(android::metricslogger::ACTION_BOOT, - android::metricslogger::FIELD_PLATFORM_REASON, reason); + // TODO(b/148575354): Replace with statsd. + // android::metricslogger::LogMultiAction(android::metricslogger::ACTION_BOOT, + // android::metricslogger::FIELD_PLATFORM_REASON, + // reason); } // Log the raw bootloader_boot_reason property value. @@ -1246,9 +1250,11 @@ void RecordFactoryReset() { time_t current_time_utc = time(nullptr); if (current_time_utc < 0) { + // TODO(b/148575354): Replace with statsd. // UMA does not display negative values in buckets, so convert to positive. - android::metricslogger::LogHistogram("factory_reset_current_time_failure", - std::abs(current_time_utc)); + // Logging via BootEventRecordStore. + // android::metricslogger::LogHistogram("factory_reset_current_time_failure", + // std::abs(current_time_utc)); // Logging via BootEventRecordStore to see if using android::metricslogger::LogHistogram // is losing records somehow. @@ -1256,7 +1262,8 @@ void RecordFactoryReset() { std::abs(current_time_utc)); return; } else { - android::metricslogger::LogHistogram("factory_reset_current_time", current_time_utc); + // TODO(b/148575354): Replace with statsd. + // android::metricslogger::LogHistogram("factory_reset_current_time", current_time_utc); // Logging via BootEventRecordStore to see if using android::metricslogger::LogHistogram // is losing records somehow. @@ -1276,7 +1283,8 @@ void RecordFactoryReset() { // Calculate and record the difference in time between now and the // factory_reset time. time_t factory_reset_utc = record.second; - android::metricslogger::LogHistogram("factory_reset_record_value", factory_reset_utc); + // TODO(b/148575354): Replace with statsd. + // android::metricslogger::LogHistogram("factory_reset_record_value", factory_reset_utc); // Logging via BootEventRecordStore to see if using android::metricslogger::LogHistogram // is losing records somehow.