diff --git a/base/Android.bp b/base/Android.bp index 7b1dc8e36..121da4214 100644 --- a/base/Android.bp +++ b/base/Android.bp @@ -42,24 +42,36 @@ cc_library { srcs: [ "errors_unix.cpp", "properties.cpp", + "chrono_utils.cpp", ], cppflags: ["-Wexit-time-destructors"], sanitize: { misc_undefined: ["integer"], }, + }, darwin: { - srcs: ["errors_unix.cpp"], + srcs: [ + "chrono_utils.cpp", + "errors_unix.cpp", + ], cppflags: ["-Wexit-time-destructors"], }, linux_bionic: { - srcs: ["errors_unix.cpp"], + srcs: [ + "chrono_utils.cpp", + "errors_unix.cpp", + ], cppflags: ["-Wexit-time-destructors"], enabled: true, }, linux: { - srcs: ["errors_unix.cpp"], + srcs: [ + "chrono_utils.cpp", + "errors_unix.cpp", + ], cppflags: ["-Wexit-time-destructors"], + host_ldlibs: ["-lrt"], }, windows: { srcs: [ @@ -92,11 +104,18 @@ cc_test { ], target: { android: { - srcs: ["properties_test.cpp"], + srcs: [ + "chrono_utils_test.cpp", + "properties_test.cpp" + ], sanitize: { misc_undefined: ["integer"], }, }, + linux: { + srcs: ["chrono_utils_test.cpp"], + host_ldlibs: ["-lrt"], + }, windows: { srcs: ["utf8_test.cpp"], enabled: true, diff --git a/bootstat/uptime_parser.cpp b/base/chrono_utils.cpp similarity index 52% rename from bootstat/uptime_parser.cpp rename to base/chrono_utils.cpp index 7c2034c3d..5eedf3bce 100644 --- a/bootstat/uptime_parser.cpp +++ b/base/chrono_utils.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2016 The Android Open Source Project + * Copyright (C) 2017 The Android Open Source Project * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -14,25 +14,24 @@ * limitations under the License. */ -#include "uptime_parser.h" +#include "android-base/chrono_utils.h" #include -#include -#include -#include -#include -namespace bootstat { +namespace android { +namespace base { -time_t ParseUptime() { - std::string uptime_str; - if (!android::base::ReadFileToString("/proc/uptime", &uptime_str)) { - PLOG(ERROR) << "Failed to read /proc/uptime"; - return -1; - } - - // Cast intentionally rounds down. - return static_cast(strtod(uptime_str.c_str(), NULL)); +boot_clock::time_point boot_clock::now() { +#ifdef __ANDROID__ + timespec ts; + clock_gettime(CLOCK_BOOTTIME, &ts); + return boot_clock::time_point(std::chrono::seconds(ts.tv_sec) + + std::chrono::nanoseconds(ts.tv_nsec)); +#else + // Darwin does not support clock_gettime. + return boot_clock::time_point(); +#endif // __ANDROID__ } -} // namespace bootstat \ No newline at end of file +} // namespace base +} // namespace android diff --git a/base/chrono_utils_test.cpp b/base/chrono_utils_test.cpp new file mode 100644 index 000000000..057132d9f --- /dev/null +++ b/base/chrono_utils_test.cpp @@ -0,0 +1,46 @@ +/* + * Copyright (C) 2017 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "android-base/chrono_utils.h" + +#include + +#include + +#include + +namespace android { +namespace base { + +std::chrono::seconds GetBootTimeSeconds() { + struct timespec now; + clock_gettime(CLOCK_BOOTTIME, &now); + + auto now_tp = boot_clock::time_point(std::chrono::seconds(now.tv_sec) + + std::chrono::nanoseconds(now.tv_nsec)); + return std::chrono::duration_cast(now_tp.time_since_epoch()); +} + +// Tests (at least) the seconds accuracy of the boot_clock::now() method. +TEST(ChronoUtilsTest, BootClockNowSeconds) { + auto now = GetBootTimeSeconds(); + auto boot_seconds = + std::chrono::duration_cast(boot_clock::now().time_since_epoch()); + EXPECT_EQ(now, boot_seconds); +} + +} // namespace base +} // namespace android \ No newline at end of file diff --git a/bootstat/uptime_parser.h b/base/include/android-base/chrono_utils.h similarity index 54% rename from bootstat/uptime_parser.h rename to base/include/android-base/chrono_utils.h index 756ae9b7c..0086425e5 100644 --- a/bootstat/uptime_parser.h +++ b/base/include/android-base/chrono_utils.h @@ -1,5 +1,5 @@ /* - * Copyright (C) 2016 The Android Open Source Project + * Copyright (C) 2017 The Android Open Source Project * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -14,16 +14,24 @@ * limitations under the License. */ -#ifndef UPTIME_PARSER_H_ -#define UPTIME_PARSER_H_ +#ifndef ANDROID_BASE_CHRONO_UTILS_H +#define ANDROID_BASE_CHRONO_UTILS_H -#include +#include -namespace bootstat { +namespace android { +namespace base { -// Returns the number of seconds the system has been on since reboot. -time_t ParseUptime(); +// A std::chrono clock based on CLOCK_BOOTTIME. +class boot_clock { + public: + typedef std::chrono::nanoseconds duration; + typedef std::chrono::time_point time_point; -} // namespace bootstat + static time_point now(); +}; -#endif // UPTIME_PARSER_H_ \ No newline at end of file +} // namespace base +} // namespace android + +#endif // ANDROID_BASE_CHRONO_UTILS_H diff --git a/bootstat/Android.bp b/bootstat/Android.bp index f744ad128..95c9af50e 100644 --- a/bootstat/Android.bp +++ b/bootstat/Android.bp @@ -16,7 +16,6 @@ bootstat_lib_src_files = [ "boot_event_record_store.cpp", - "uptime_parser.cpp", ] cc_defaults { diff --git a/bootstat/boot_event_record_store.cpp b/bootstat/boot_event_record_store.cpp index 26485942d..99d94057c 100644 --- a/bootstat/boot_event_record_store.cpp +++ b/bootstat/boot_event_record_store.cpp @@ -20,13 +20,16 @@ #include #include #include + +#include #include #include #include + +#include #include #include #include -#include "uptime_parser.h" namespace { @@ -55,7 +58,9 @@ BootEventRecordStore::BootEventRecordStore() { } void BootEventRecordStore::AddBootEvent(const std::string& event) { - AddBootEventWithValue(event, bootstat::ParseUptime()); + auto uptime = std::chrono::duration_cast( + android::base::boot_clock::now().time_since_epoch()); + AddBootEventWithValue(event, uptime.count()); } // The implementation of AddBootEventValue makes use of the mtime file diff --git a/bootstat/boot_event_record_store_test.cpp b/bootstat/boot_event_record_store_test.cpp index 90f6513e4..d98169b87 100644 --- a/bootstat/boot_event_record_store_test.cpp +++ b/bootstat/boot_event_record_store_test.cpp @@ -21,15 +21,18 @@ #include #include #include + +#include #include #include + +#include #include #include #include #include -#include #include -#include "uptime_parser.h" +#include using testing::UnorderedElementsAreArray; @@ -89,6 +92,13 @@ void DeleteDirectory(const std::string& path) { rmdir(path.c_str()); } +// Returns the time in seconds since boot. +time_t GetUptimeSeconds() { + return std::chrono::duration_cast( + android::base::boot_clock::now().time_since_epoch()) + .count(); +} + class BootEventRecordStoreTest : public ::testing::Test { public: BootEventRecordStoreTest() { @@ -126,7 +136,7 @@ TEST_F(BootEventRecordStoreTest, AddSingleBootEvent) { BootEventRecordStore store; store.SetStorePath(GetStorePathForTesting()); - time_t uptime = bootstat::ParseUptime(); + time_t uptime = GetUptimeSeconds(); ASSERT_NE(-1, uptime); store.AddBootEvent("cenozoic"); @@ -141,7 +151,7 @@ TEST_F(BootEventRecordStoreTest, AddMultipleBootEvents) { BootEventRecordStore store; store.SetStorePath(GetStorePathForTesting()); - time_t uptime = bootstat::ParseUptime(); + time_t uptime = GetUptimeSeconds(); ASSERT_NE(-1, uptime); store.AddBootEvent("cretaceous"); diff --git a/bootstat/bootstat.cpp b/bootstat/bootstat.cpp index a4cc5f22e..6f25d963d 100644 --- a/bootstat/bootstat.cpp +++ b/bootstat/bootstat.cpp @@ -21,6 +21,7 @@ #include #include +#include #include #include #include @@ -30,15 +31,15 @@ #include #include -#include +#include #include #include #include +#include #include #include #include "boot_event_record_store.h" -#include "uptime_parser.h" namespace { @@ -255,7 +256,8 @@ void RecordBootComplete() { BootEventRecordStore boot_event_store; BootEventRecordStore::BootEventRecord record; - time_t uptime = bootstat::ParseUptime(); + auto uptime = std::chrono::duration_cast( + android::base::boot_clock::now().time_since_epoch()); time_t current_time_utc = time(nullptr); if (boot_event_store.GetBootEvent("last_boot_time_utc", &record)) { @@ -282,22 +284,21 @@ void RecordBootComplete() { // Log the amount of time elapsed until the device is decrypted, which // includes the variable amount of time the user takes to enter the // decryption password. - boot_event_store.AddBootEventWithValue("boot_decryption_complete", uptime); + boot_event_store.AddBootEventWithValue("boot_decryption_complete", uptime.count()); // Subtract the decryption time to normalize the boot cycle timing. - time_t boot_complete = uptime - record.second; + std::chrono::seconds boot_complete = std::chrono::seconds(uptime.count() - record.second); boot_event_store.AddBootEventWithValue(boot_complete_prefix + "_post_decrypt", - boot_complete); - + boot_complete.count()); } else { - boot_event_store.AddBootEventWithValue(boot_complete_prefix + "_no_encryption", - uptime); + boot_event_store.AddBootEventWithValue(boot_complete_prefix + "_no_encryption", + uptime.count()); } // Record the total time from device startup to boot complete, regardless of // encryption state. - boot_event_store.AddBootEventWithValue(boot_complete_prefix, uptime); + boot_event_store.AddBootEventWithValue(boot_complete_prefix, uptime.count()); RecordInitBootTimeProp(&boot_event_store, "ro.boottime.init"); RecordInitBootTimeProp(&boot_event_store, "ro.boottime.init.selinux"); diff --git a/init/init.cpp b/init/init.cpp index 6f3b3a690..e14034f6f 100644 --- a/init/init.cpp +++ b/init/init.cpp @@ -40,6 +40,7 @@ #include #include +#include #include #include #include @@ -69,6 +70,7 @@ #include "util.h" #include "watchdogd.h" +using android::base::boot_clock; using android::base::GetProperty; using android::base::StringPrintf; diff --git a/init/service.cpp b/init/service.cpp index 3db34db89..e89de9af6 100644 --- a/init/service.cpp +++ b/init/service.cpp @@ -32,6 +32,7 @@ #include +#include #include #include #include @@ -48,6 +49,7 @@ #include "property_service.h" #include "util.h" +using android::base::boot_clock; using android::base::ParseInt; using android::base::StringPrintf; using android::base::WriteStringToFile; diff --git a/init/service.h b/init/service.h index f08a03f9a..d84ce0281 100644 --- a/init/service.h +++ b/init/service.h @@ -26,6 +26,8 @@ #include #include +#include + #include "action.h" #include "capabilities.h" #include "descriptors.h" @@ -144,8 +146,8 @@ class Service { unsigned flags_; pid_t pid_; - boot_clock::time_point time_started_; // time of last start - boot_clock::time_point time_crashed_; // first crash within inspection window + android::base::boot_clock::time_point time_started_; // time of last start + android::base::boot_clock::time_point time_crashed_; // first crash within inspection window int crash_count_; // number of times crashed within window uid_t uid_; diff --git a/init/util.cpp b/init/util.cpp index 8a1993987..14fd7ab19 100644 --- a/init/util.cpp +++ b/init/util.cpp @@ -52,6 +52,8 @@ #include "reboot.h" #include "util.h" +using android::base::boot_clock; + static unsigned int do_decode_uid(const char *s) { unsigned int v; @@ -198,13 +200,6 @@ bool write_file(const char* path, const char* content) { return success; } -boot_clock::time_point boot_clock::now() { - timespec ts; - clock_gettime(CLOCK_BOOTTIME, &ts); - return boot_clock::time_point(std::chrono::seconds(ts.tv_sec) + - std::chrono::nanoseconds(ts.tv_nsec)); -} - int mkdir_recursive(const char *pathname, mode_t mode) { char buf[128]; diff --git a/init/util.h b/init/util.h index 81c64d79b..23509d3fe 100644 --- a/init/util.h +++ b/init/util.h @@ -25,8 +25,11 @@ #include #include +#include + #define COLDBOOT_DONE "/dev/.coldboot_done" +using android::base::boot_clock; using namespace std::chrono_literals; int create_socket(const char *name, int type, mode_t perm, @@ -35,32 +38,22 @@ int create_socket(const char *name, int type, mode_t perm, bool read_file(const char* path, std::string* content); bool write_file(const char* path, const char* content); -// A std::chrono clock based on CLOCK_BOOTTIME. -class boot_clock { - public: - typedef std::chrono::nanoseconds duration; - typedef std::chrono::time_point time_point; - static constexpr bool is_steady = true; - - static time_point now(); -}; - class Timer { - public: - Timer() : start_(boot_clock::now()) { - } + public: + Timer() : start_(boot_clock::now()) {} - double duration_s() const { - typedef std::chrono::duration double_duration; - return std::chrono::duration_cast(boot_clock::now() - start_).count(); - } + double duration_s() const { + typedef std::chrono::duration double_duration; + return std::chrono::duration_cast(boot_clock::now() - start_).count(); + } - int64_t duration_ms() const { - return std::chrono::duration_cast(boot_clock::now() - start_).count(); - } + int64_t duration_ms() const { + return std::chrono::duration_cast(boot_clock::now() - start_) + .count(); + } - private: - boot_clock::time_point start_; + private: + android::base::boot_clock::time_point start_; }; std::ostream& operator<<(std::ostream& os, const Timer& t);