diff --git a/fs_mgr/libsnapshot/cow_api_test.cpp b/fs_mgr/libsnapshot/cow_api_test.cpp index f9e9b4ca7..40d5efbeb 100644 --- a/fs_mgr/libsnapshot/cow_api_test.cpp +++ b/fs_mgr/libsnapshot/cow_api_test.cpp @@ -70,7 +70,7 @@ TEST_F(CowTest, ReadWrite) { ASSERT_TRUE(writer.AddCopy(10, 20)); ASSERT_TRUE(writer.AddRawBlocks(50, data.data(), data.size())); ASSERT_TRUE(writer.AddZeroBlocks(51, 2)); - ASSERT_TRUE(writer.Finalize()); + ASSERT_TRUE(writer.Flush()); ASSERT_EQ(lseek(cow_->fd, 0, SEEK_SET), 0); @@ -145,7 +145,7 @@ TEST_F(CowTest, CompressGz) { data.resize(options.block_size, '\0'); ASSERT_TRUE(writer.AddRawBlocks(50, data.data(), data.size())); - ASSERT_TRUE(writer.Finalize()); + ASSERT_TRUE(writer.Flush()); ASSERT_EQ(lseek(cow_->fd, 0, SEEK_SET), 0); @@ -182,7 +182,7 @@ TEST_F(CowTest, CompressTwoBlocks) { data.resize(options.block_size * 2, '\0'); ASSERT_TRUE(writer.AddRawBlocks(50, data.data(), data.size())); - ASSERT_TRUE(writer.Finalize()); + ASSERT_TRUE(writer.Flush()); ASSERT_EQ(lseek(cow_->fd, 0, SEEK_SET), 0); @@ -224,7 +224,7 @@ TEST_P(CompressionTest, HorribleSink) { data.resize(options.block_size, '\0'); ASSERT_TRUE(writer.AddRawBlocks(50, data.data(), data.size())); - ASSERT_TRUE(writer.Finalize()); + ASSERT_TRUE(writer.Flush()); ASSERT_EQ(lseek(cow_->fd, 0, SEEK_SET), 0); @@ -259,7 +259,7 @@ TEST_F(CowTest, GetSize) { ASSERT_TRUE(writer.AddRawBlocks(50, data.data(), data.size())); ASSERT_TRUE(writer.AddZeroBlocks(51, 2)); auto size_before = writer.GetCowSize(); - ASSERT_TRUE(writer.Finalize()); + ASSERT_TRUE(writer.Flush()); auto size_after = writer.GetCowSize(); ASSERT_EQ(size_before, size_after); struct stat buf; @@ -279,7 +279,7 @@ TEST_F(CowTest, Append) { std::string data = "This is some data, believe it"; data.resize(options.block_size, '\0'); ASSERT_TRUE(writer->AddRawBlocks(50, data.data(), data.size())); - ASSERT_TRUE(writer->Finalize()); + ASSERT_TRUE(writer->Flush()); ASSERT_EQ(lseek(cow_->fd, 0, SEEK_SET), 0); @@ -289,7 +289,7 @@ TEST_F(CowTest, Append) { std::string data2 = "More data!"; data2.resize(options.block_size, '\0'); ASSERT_TRUE(writer->AddRawBlocks(51, data2.data(), data2.size())); - ASSERT_TRUE(writer->Finalize()); + ASSERT_TRUE(writer->Flush()); ASSERT_EQ(lseek(cow_->fd, 0, SEEK_SET), 0); diff --git a/fs_mgr/libsnapshot/cow_snapuserd_test.cpp b/fs_mgr/libsnapshot/cow_snapuserd_test.cpp index bbda55266..1d6c10405 100644 --- a/fs_mgr/libsnapshot/cow_snapuserd_test.cpp +++ b/fs_mgr/libsnapshot/cow_snapuserd_test.cpp @@ -227,7 +227,7 @@ void SnapuserdTest::CreateCowDevice(std::unique_ptr& cow) { ASSERT_TRUE(writer.AddRawBlocks(blk_random2_replace_start, random_buffer_2_.get(), size_)); // Flush operations - ASSERT_TRUE(writer.Finalize()); + ASSERT_TRUE(writer.Flush()); ASSERT_EQ(lseek(cow->fd, 0, SEEK_SET), 0); } diff --git a/fs_mgr/libsnapshot/cow_writer.cpp b/fs_mgr/libsnapshot/cow_writer.cpp index f9ba0b3c2..f96f174c5 100644 --- a/fs_mgr/libsnapshot/cow_writer.cpp +++ b/fs_mgr/libsnapshot/cow_writer.cpp @@ -293,7 +293,7 @@ static void SHA256(const void*, size_t, uint8_t[]) { #endif } -bool CowWriter::Finalize() { +bool CowWriter::Flush() { header_.ops_size = ops_.size(); memset(header_.ops_checksum, 0, sizeof(uint8_t) * 32); diff --git a/fs_mgr/libsnapshot/estimate_cow_from_nonab_ota.cpp b/fs_mgr/libsnapshot/estimate_cow_from_nonab_ota.cpp index 45833e121..2a0136b6d 100644 --- a/fs_mgr/libsnapshot/estimate_cow_from_nonab_ota.cpp +++ b/fs_mgr/libsnapshot/estimate_cow_from_nonab_ota.cpp @@ -375,7 +375,7 @@ bool NonAbEstimator::AnalyzePartition(const std::string& partition_name) { } } - if (!writer->Finalize()) { + if (!writer->Flush()) { return false; } diff --git a/fs_mgr/libsnapshot/include/libsnapshot/cow_writer.h b/fs_mgr/libsnapshot/include/libsnapshot/cow_writer.h index 3ab377823..2bc017100 100644 --- a/fs_mgr/libsnapshot/include/libsnapshot/cow_writer.h +++ b/fs_mgr/libsnapshot/include/libsnapshot/cow_writer.h @@ -53,7 +53,7 @@ class ICowWriter { // Flush all pending writes. This must be called before closing the writer // to ensure that the correct headers and footers are written. - virtual bool Finalize() = 0; + virtual bool Flush() = 0; // Return number of bytes the cow image occupies on disk. virtual uint64_t GetCowSize() = 0; @@ -84,7 +84,7 @@ class CowWriter : public ICowWriter { bool Initialize(android::base::unique_fd&& fd, OpenMode mode = OpenMode::WRITE); bool Initialize(android::base::borrowed_fd fd, OpenMode mode = OpenMode::WRITE); - bool Finalize() override; + bool Flush() override; uint64_t GetCowSize() override; diff --git a/fs_mgr/libsnapshot/include/libsnapshot/snapshot_writer.h b/fs_mgr/libsnapshot/include/libsnapshot/snapshot_writer.h index 48d20be65..bf57a0078 100644 --- a/fs_mgr/libsnapshot/include/libsnapshot/snapshot_writer.h +++ b/fs_mgr/libsnapshot/include/libsnapshot/snapshot_writer.h @@ -50,7 +50,7 @@ class OnlineKernelSnapshotWriter : public ISnapshotWriter { // Set the device used for all writes. void SetSnapshotDevice(android::base::unique_fd&& snapshot_fd, uint64_t cow_size); - bool Finalize() override; + bool Flush() override; uint64_t GetCowSize() override { return cow_size_; } virtual std::unique_ptr OpenReader() override; diff --git a/fs_mgr/libsnapshot/make_cow_from_ab_ota.cpp b/fs_mgr/libsnapshot/make_cow_from_ab_ota.cpp index d0b8f52e0..f76107709 100644 --- a/fs_mgr/libsnapshot/make_cow_from_ab_ota.cpp +++ b/fs_mgr/libsnapshot/make_cow_from_ab_ota.cpp @@ -204,7 +204,7 @@ bool PayloadConverter::ProcessPartition(const PartitionUpdate& update) { } } - if (!writer_->Finalize()) { + if (!writer_->Flush()) { LOG(ERROR) << "Unable to finalize COW for " << partition_name; return false; } diff --git a/fs_mgr/libsnapshot/snapshot_writer.cpp b/fs_mgr/libsnapshot/snapshot_writer.cpp index 8c1311cff..1958f188b 100644 --- a/fs_mgr/libsnapshot/snapshot_writer.cpp +++ b/fs_mgr/libsnapshot/snapshot_writer.cpp @@ -40,7 +40,7 @@ void OnlineKernelSnapshotWriter::SetSnapshotDevice(android::base::unique_fd&& sn cow_size_ = cow_size; } -bool OnlineKernelSnapshotWriter::Finalize() { +bool OnlineKernelSnapshotWriter::Flush() { if (fsync(snapshot_fd_.get()) < 0) { PLOG(ERROR) << "fsync"; return false;