platform_system_core

Commit Graph

Author	SHA1	Message	Date
Tom Cherry	9b4246dc2d	logd: fix various clang-tidy issues In order of severity: 1) Add a CHECK() that a pointer is not nullptr, where the analyzer believes this is possible. 2) Add `final` appropriately to functions called from constructors. 3) Add missing cloexec flags. 4) Add missing `noexcept` and other subtle performance warnings Test: build with clang-tidy Change-Id: Ifd9a1299a51027a47382926b2224748b5750d6cf	2020-06-17 11:40:55 -07:00
Tom Cherry	4e9bf955d6	logd: remove class LogCommand, rename LogCommand.cpp to LogPermissions.cpp class LogCommand isn't needed, so remove it. Since the rest of LogCommand.cpp only has to do with permissions, rename it appropriately. Test: logging unit tests Change-Id: I32d09c74d00b6e50083e46832eca3dd886b46682	2020-05-15 11:58:47 -07:00

Author

SHA1

Message

Date

Tom Cherry

9b4246dc2d

logd: fix various clang-tidy issues

In order of severity:
1) Add a CHECK() that a pointer is not nullptr, where the analyzer
   believes this is possible.
2) Add `final` appropriately to functions called from constructors.
3) Add missing cloexec flags.
4) Add missing `noexcept` and other subtle performance warnings

Test: build with clang-tidy
Change-Id: Ifd9a1299a51027a47382926b2224748b5750d6cf

2020-06-17 11:40:55 -07:00

Tom Cherry

4e9bf955d6

logd: remove class LogCommand, rename LogCommand.cpp to LogPermissions.cpp

class LogCommand isn't needed, so remove it.  Since the rest of
LogCommand.cpp only has to do with permissions, rename it
appropriately.

Test: logging unit tests
Change-Id: I32d09c74d00b6e50083e46832eca3dd886b46682

2020-05-15 11:58:47 -07:00

2 Commits