platform_system_core

Commit Graph

Author	SHA1	Message	Date
Josh Gao	d3387380f7	Hopefully fix more darwin build breakage. Silence narrowing warnings by manually casting to a smaller type, convert static_asserts to CHECKs, and switch from using MSG_CMSG_CLOEXEC to manually setting FD_CLOEXEC. Test: mma Change-Id: I8aa02804179d754de860279fe34773800b937ab6	2019-02-19 14:37:02 -08:00
Josh Gao	b57dc7a670	Fix darwin build break. The <malloc.h> include was vestigial from a previous revision. Test: mma on linux Change-Id: Iaf8351bec23c2792cefca0e5c9bd42664488f5c4	2019-02-19 13:17:23 -08:00
Josh Gao	14f9500a35	base: add helpers for sending/receiving file descriptors. Almost all of the uses of cmsg(3) in our source tree are wrong in at least one of the following ways: - not aligning the cmsg buffer - leaking fds if more fds are received than expected - blindly dereferencing CMSG_DATA without checking the header - using CMSG_SPACE instead of CMSG_LEN for .cmsg_len - using CMSG_LEN instead of CMSG_SPACE for .msg_controllen - using a length specified in number of fds instead of bytes Implement wrapper functions that implement this dumpster fire of an API correctly. Bug: http://b/122047630 Test: libbase_test32 Change-Id: I6ac34d67bbbf1bfa9727ab598248fc178ea19df9	2019-02-13 13:21:54 -08:00

Author

SHA1

Message

Date

Josh Gao

d3387380f7

Hopefully fix more darwin build breakage.

Silence narrowing warnings by manually casting to a smaller type,
convert static_asserts to CHECKs, and switch from using MSG_CMSG_CLOEXEC
to manually setting FD_CLOEXEC.

Test: mma
Change-Id: I8aa02804179d754de860279fe34773800b937ab6

2019-02-19 14:37:02 -08:00

Josh Gao

b57dc7a670

Fix darwin build break.

The <malloc.h> include was vestigial from a previous revision.

Test: mma on linux
Change-Id: Iaf8351bec23c2792cefca0e5c9bd42664488f5c4

2019-02-19 13:17:23 -08:00

Josh Gao

14f9500a35

base: add helpers for sending/receiving file descriptors.

Almost all of the uses of cmsg(3) in our source tree are wrong in at
least one of the following ways:

  - not aligning the cmsg buffer
  - leaking fds if more fds are received than expected
  - blindly dereferencing CMSG_DATA without checking the header
  - using CMSG_SPACE instead of CMSG_LEN for .cmsg_len
  - using CMSG_LEN instead of CMSG_SPACE for .msg_controllen
  - using a length specified in number of fds instead of bytes

Implement wrapper functions that implement this dumpster fire of an
API correctly.

Bug: http://b/122047630
Test: libbase_test32
Change-Id: I6ac34d67bbbf1bfa9727ab598248fc178ea19df9

2019-02-13 13:21:54 -08:00

3 Commits