Narayan Kamath
b2f019ec1e
liblog: don't bother keeping FD around once it's mapped.
...
Posix and linux explicitly state that this isn't necessary.
bug: 30963384
Change-Id: I2cc16ded04f0ebc909dc3027e02867594fb49d05
2016-09-01 19:31:08 +01:00
Mark Salyzyn
6322efe522
Merge "liblog: add __android_log_close()"
...
am: 812d1c7ea2
Change-Id: I2ba5ed22e78564a864bab6b550b6d2bd2609a629
2016-08-24 16:05:05 +00:00
Mark Salyzyn
2d562c9dce
Merge "logger: validate hdr_size field in logger entry"
...
am: fcf7ab8b1b
Change-Id: Ic88fe616256ab4949040771d3bed1dfb823ab981
2016-08-24 16:05:04 +00:00
Treehugger Robot
812d1c7ea2
Merge "liblog: add __android_log_close()"
2016-08-24 15:58:48 +00:00
Mark Salyzyn
df7a4c6bae
liblog: add __android_log_close()
...
Bug: 30963384
Change-Id: I901e6ac2cc3c601bbecc2d64e00a98e2ab448210
2016-08-23 15:25:03 -07:00
Mark Salyzyn
305374cf0f
logger: validate hdr_size field in logger entry
...
- check hdr_size to make sure it is in the expected range
from sizeof entry_v1 to entry (entry_v4).
- alter msg() method to report NULL on invalid hdr_size
- alter all users of msg() method.
Bug: 30947841
Change-Id: I9bc1740d7aa9f37df5be966c18de1fb9de63d5dd
2016-08-23 14:51:50 -07:00
Elliott Hughes
33f8c194f9
Merge "liblog: use SOCK_NONBLOCK directly."
...
am: fca43d3ec5
Change-Id: I4d959d9091adbf8bf2d7b68653a3c6064893a65a
2016-08-23 01:20:36 +00:00
Elliott Hughes
5ba3003467
liblog: use SOCK_NONBLOCK directly.
...
No need to have a race, even if it doesn't matter.
Change-Id: Ia79f2633643bc63618de0fd85953b3226415484f
2016-08-22 16:19:58 -07:00
Chih-Hung Hsieh
89cc78b77f
Merge \"Fix google-explicit-constructor warnings in system/core.\"
...
am: 6dc68cb5f9
Change-Id: I5a010465364b6e14423b19e8c0f9cffa58ee3152
2016-07-29 17:01:17 +00:00
Chih-Hung Hsieh
034c475931
Fix google-explicit-constructor warnings in system/core.
...
* Declare explicit conversion constructors.
* Add NOLINT for implicit conversion constructors.
* Fix also some misaligned indendations.
Bug: 28341362
Change-Id: Idf911f35923b408d92285cc1a053f382ba08c63e
Test: build with clang-tidy
2016-07-26 11:26:01 -07:00
Mark Salyzyn
0d9ce37382
Merge \"liblog: pmsg_read add validity checking for prio\"
...
am: 73cc6edf0e
Change-Id: Iba5e7b7c2325e127eb9f040c8ab86ba24efd5b20
2016-07-15 19:04:48 +00:00
Mark Salyzyn
56da612ec4
Merge \"liblog: reset pid and uid cache after a vfork()\"
...
am: d4f6324176
Change-Id: I3b59f56b2b5f399b079ab9439600dc3a72c669a6
2016-07-14 15:55:55 +00:00
Mark Salyzyn
3d8afe9b01
liblog: pmsg_read add validity checking for prio
...
Improve pmsg data corruption detection.
Bug: 30085794
Change-Id: I215da4fff07797b8c0a3462f850bafb090adfc68
2016-07-14 07:34:53 -07:00
Mark Salyzyn
ec4f5c776d
liblog: reset pid and uid cache after a vfork()
...
Bionic getuid() and getpid() calls cache to reduce the need to
perform a syscall, and also reset their own cache after a vfork().
No more need for liblog to be performing this flawed cache operation.
Bug: 30085794
Change-Id: I70feed8bff0ddd919c2885a348ba67b14ddc0e0d
2016-07-14 07:34:53 -07:00
Colin Cross
68bfe51348
Merge \"Rename Android.soong.mk to Android.mk\"
...
am: b07df4dd3f
Change-Id: I9d9a232539b9991ab935e143140a3b77d896ebc7
2016-07-12 16:20:21 +00:00
Colin Cross
b39e4025ae
Rename Android.soong.mk to Android.mk
...
Soong is always on now, so we don't have to distinguish between
makefiles that should be ignored because Soong is handling them with an
Android.bp file, and makefiles that are still needed with Soong. All
obsolete Android.mk files have been removed, rename all Android.soong.mk
files to Android.mk.
Change-Id: Iabbddcbfb2c837cfd4556241b570474452cc5d4d
2016-07-11 16:56:51 -07:00
Elliott Hughes
016ad16100
Merge "Use alignas for alignment." am: bb1e7977fb
...
am: 689b998ab2
* commit '689b998ab26f2a04e079312aee2f8e32fbe7f26c':
Use alignas for alignment.
Change-Id: Ic81a88146df0f407849800c63d2edb7404efe0ac
2016-06-07 15:55:12 +00:00
Elliott Hughes
5f4a946c09
Use alignas for alignment.
...
Change-Id: I427c407a188682a360c74b2bd5a44dd62551ea66
2016-06-06 19:59:45 -07:00
Colin Cross
bfcb1b779f
Merge "Remove deprecated Android.mk files" am: ce5b4fee23
...
am: 5806404e4d
* commit '5806404e4d693699fef2e710fd8ad836815f8852':
Remove deprecated Android.mk files
Change-Id: I8a87996377bd53a16d330c0df9bfff84c92e10a2
2016-06-02 16:41:27 +00:00
Colin Cross
ce5b4fee23
Merge "Remove deprecated Android.mk files"
2016-06-02 16:31:42 +00:00
Dan Willemsen
9ce49be616
Merge "Fix liblog logtags" am: 59e6afc617
...
am: 6b5255722e
* commit '6b5255722e7497fc7c854cf1ae9e51322bc7ceae':
Fix liblog logtags
Change-Id: I6225d8fd338b9ffc5b4406d5dbb92e2816bcaaad
2016-06-01 23:47:45 +00:00
Dan Willemsen
d119101807
Fix liblog logtags
...
This was broken because we didn't have logtags support in Soong.
Bug: 28989759
Change-Id: I8370a73cf14703b86aafd85e7ea74fc570c3ff0f
2016-06-01 15:32:35 -07:00
Colin Cross
b50216ed86
Remove deprecated Android.mk files
...
These directories all have Android.bp files that are always used now,
delete the Android.mk files.
Change-Id: I8b0c89072a660c4a7a30fcefc76a7bbe247df977
2016-05-26 16:58:28 -07:00
Chih-hung Hsieh
d581f2c47d
Merge "Fix misc-macro-parentheses warnings in liblog." am: 2bd428e1f9
...
am: 1cff850bb3
* commit '1cff850bb383d75c395d4627086b6baa63639a18':
Fix misc-macro-parentheses warnings in liblog.
Change-Id: I318ab4909ba59e7181b9ec9c3e73f58ea8b0c0d8
2016-05-19 01:02:34 +00:00
Chih-hung Hsieh
2bd428e1f9
Merge "Fix misc-macro-parentheses warnings in liblog."
2016-05-19 00:48:44 +00:00
Chih-Hung Hsieh
f0f94fe49b
Fix misc-macro-parentheses warnings in liblog.
...
Bug: 28705665
Change-Id: Ib272a83cb93b09d986c19a40e23a2679b9e17558
2016-05-18 15:48:50 -07:00
Mark Salyzyn
5d32a9821d
Merge "liblog: log reader validate headers" am: 0321476fe2
...
am: 0a7dec432c
* commit '0a7dec432ce3a72edcf5bf092871296225cd814b':
liblog: log reader validate headers
Change-Id: Ic035cf9d3e765e95799a25c1441d5fa88ab3fda7
2016-05-18 14:27:54 +00:00
Mark Salyzyn
8fd1faa596
liblog: log reader validate headers
...
Ensure len and hdr_size fields are valid and match the return value.
Truncate or zero content as necessary, but do not drop the message.
Bug: 28610769
Change-Id: I10785fa5b03aa3da7d07b368188e3f7c36a84b4f
2016-05-17 13:54:42 -07:00
Mark Salyzyn
5d76be85a4
Merge "liblog: sleep 20ms before critical property_set" am: 1d560ff24a
...
am: 03ac8fe0be
* commit '03ac8fe0be882b09d7faba4d5f96e536a94198ab':
liblog: sleep 20ms before critical property_set
Change-Id: I91d3262a478f83556851881208fb1f83de62f189
2016-05-12 16:48:21 +00:00
Mark Salyzyn
5cceee6404
liblog: sleep 20ms before critical property_set
...
Going too fast can result in the property not being set
and causing an extreme corner case failure being reported
and blamed on is_loggable functionality.
Bug: 25792367
Change-Id: Idda6f67d655d8a84d2809daf695394d5293e7431
2016-05-12 15:58:57 +00:00
Rubin Xu
7dcdd52cf6
Merge "Return correct length from pmsgRead()" am: fc2a8b2bd6
...
am: a76e171bf3
* commit 'a76e171bf351e3d26b3eb596188b6c9b2fcab3f4':
Return correct length from pmsgRead()
Change-Id: I616c3c889e99292454b0a7c33f999a56ada2c939
2016-05-09 15:36:23 +00:00
Rubin Xu
9c2f803e9d
Return correct length from pmsgRead()
...
Bug: 28610769
Change-Id: I38cac786ca43ef8d9530f4e2e5a0bdd4cc3bccef
2016-05-05 16:50:44 +01:00
Mark Salyzyn
9fd5df3816
Merge "liblog: O_CLOEXEC flag on opens" am: fc80b22752
...
am: a0afba8a87
* commit 'a0afba8a8721319233e788cf723e979d3f0781e2':
liblog: O_CLOEXEC flag on opens
Change-Id: I4c018e556b645ab58477cc537d65489d904fa78b
2016-04-29 15:44:52 +00:00
Mark Salyzyn
a3692040fa
Merge "liblog: logcat -g readable size wrong" am: 7f18790bd7
...
am: 7a5b8c7f53
* commit '7a5b8c7f53ca79f99e74655b2f68356c7184532a':
liblog: logcat -g readable size wrong
Change-Id: I1461a41dc0b1bff3394caa5a107d7ad80cc7d068
2016-04-29 14:53:23 +00:00
Mark Salyzyn
78786da116
liblog: O_CLOEXEC flag on opens
...
Bug: 28455828
Change-Id: Ic00101a6192aab7271cb0c3461e249a77d7f29ed
2016-04-29 07:52:36 -07:00
Mark Salyzyn
ccfb244b36
liblog: logcat -g readable size wrong
...
Bug: 28451229
Change-Id: I4bbc2bed933d69416c23cc7af617be3fb55d0b62
2016-04-29 07:39:51 -07:00
Colin Cross
c4dcc38e44
Merge "Update sanitize property format" am: 0652728
...
am: 9ba3f6d
* commit '9ba3f6db392f0f9b25cc5b3ad03c984fdc76094f':
Update sanitize property format
Change-Id: I7ac818440c50c7166921d74dfb3b6c10af19ee09
2016-04-19 22:51:08 +00:00
Colin Cross
0652728e2a
Merge "Update sanitize property format"
2016-04-19 22:42:04 +00:00
Mark Salyzyn
ab162d6cb2
Merge "liblog: android_log_isloggable failing apct" am: 0d4661d
...
am: cee2ce6755
* commit 'cee2ce6755d032c494be4295e98064b3b40ffa51':
liblog: android_log_isloggable failing apct
Change-Id: I2cddfa04aff9a39ec897a75408a3f63c38692f4a
2016-04-19 00:28:59 +00:00
Colin Cross
5d35ce649c
Update sanitize property format
...
Change-Id: I81c299609ece7a1c7f27093f563d5df08efe989b
2016-04-15 16:33:21 -07:00
Mark Salyzyn
efe8ecc1d9
liblog: android_log_isloggable failing apct
...
- periodic failures in apct, dropped second serial test
in refresh_cache, trusting check_cache or global.
- The retry loop to see if is_loggable recovers of 1000
was hiding subsequent tests, drop to 10 retries.
- On the whole, the average performance remains the same.
Bug: 25792367
Change-Id: I4110440ef46671d7a1c128689bde623808bed04f
2016-04-15 11:04:24 -07:00
Mark Salyzyn
c1bfe53f76
Merge "liblog: remove android_ids and replace with getpwuid" am: f7040c8
...
am: 4a7d498
* commit '4a7d498e2ff0ee58112710c04f284a24a3f88cd2':
liblog: remove android_ids and replace with getpwuid
Change-Id: Idb750dd8944807cc14c265b388e2c058e17bbe53
2016-04-11 16:01:13 +00:00
William Roberts
8a5b9caaa6
liblog: remove android_ids and replace with getpwuid
...
Note: This code makes the assumption that getpwuid is
thread safe, which it is ONLY ON BIONIC. Thus,
if you attempt to use this on a non-target build, you
may get burned. Thus, an ifndef checking on __BIONIC__
is used to produce a build error if you attempt to do
so.
Change-Id: I61038c428b71771edcfc76f18d8fc5cbe349238b
Bug: 27999086
Signed-off-by: William Roberts <william.c.roberts@intel.com>
2016-04-11 14:55:56 +00:00
Mark Salyzyn
33aecaa784
Merge "liblog: suppress pmsg on user builds" am: 0858071
...
am: 24967e5
* commit '24967e5f5e87e5079f416d3cbc3d6a5dba7e8865':
liblog: suppress pmsg on user builds
Change-Id: Ic4f2c02e227ee3c0dc29eb11757dc024aae3b950
2016-03-31 21:07:32 +00:00
Mark Salyzyn
7ef5249afa
liblog: suppress pmsg on user builds
...
- add optimized & cached LIBLOG_HIDDEN __android_log_is_debuggable()
- check when writing, either LOG_ID_SECURITY, SafetyNet or
debuggable when pushing content to the pmsg buffer.
Bug: 27566046
Change-Id: I85f1b55ec329b38e00f4183836b6ed53046c323d
2016-03-29 13:52:21 -07:00
Mark Salyzyn
47cce8c410
Merge "liblog: gate write on log id available" am: fbdbf10
...
am: f44cb4c
* commit 'f44cb4c6cb11a4a2cd6af8f72d84a092bcfcf513':
liblog: gate write on log id available
Change-Id: Ida839dd23ea2b3b1b860c6e8e2b32af61b2fea29
2016-03-29 20:00:52 +00:00
Mark Salyzyn
c33103c440
liblog: gate write on log id available
...
- Secure LOG_ID_KERNEL in writer
- Secure LOG_ID_SECURITY in reader and writer
- if writer transport says not available, do not write to that log id
Bug: 27566046
Bug: 27896341
Change-Id: If63a78a56fb94adfbf9979454c4cadb81af45c19
2016-03-29 12:29:04 -07:00
Mark Salyzyn
cca6f20341
Merge "liblog: update Android.bp" into nyc-dev
...
am: 033bc9f
* commit '033bc9f3e7175ece714c13258c2385d503c35dc8':
liblog: update Android.bp
2016-03-25 19:59:25 +00:00
Mark Salyzyn
93101bea8b
liblog: update Android.bp
...
Update Android.bp to match the version in AOSP.
Change-Id: I93aba0f93a7a8d255073661331f1d966a53e20aa
(cherry picked from commit c457a4b73e
)
2016-03-24 13:45:00 -07:00
Mark Salyzyn
128c0f7081
liblog: logprint: deal with malformed log messages
...
am: 476b771
* commit '476b771bdaebf7aa72d41730557fce82cee7faf3':
liblog: logprint: deal with malformed log messages
2016-03-24 19:25:32 +00:00