platform_system_core

Commit Graph

Author	SHA1	Message	Date
Ruchir Rastogi	d177461a72	Fix bug in stats_event_benchmark Now, the number of elements in each simulated stats_event is correctly sampled from a uniform distribution. Rerunning the benchmarking tests indicates that truncating the buffer increases the number of cycles require to log an event by only 1.6%. Test: m libstatssocket_benchmark Test: bit libstatssocket_benchmark:* Change-Id: I8d5c1734861038beec8eeb7ce1f84a24bde25a75	2020-01-06 23:10:51 +00:00
Ruchir Rastogi	79dd3eaa87	Improve stats_event memory usage We now truncate the buffer to the appropriate length when clients call stats_event_build(). Benchmarking tests indicate that truncating the buffer to the appropriate length increases the cost clients pay to write to the socket by 2%. This is negligible enough that I decided to truncate the buffer for both pushed and pulled atoms in order to simplify the API. Test: m libstatssocket Test: bit libstatssocket_benchmark:* Bug: 144126231 Change-Id: I35dec748ff87c0821d0d06779a406997e6e64966 Merged-In: Ife976bb383ecff8de5064730692a95e2a3a82c9d	2019-12-18 17:44:26 -08:00

Author

SHA1

Message

Date

Ruchir Rastogi

d177461a72

Fix bug in stats_event_benchmark

Now, the number of elements in each simulated stats_event is correctly
sampled from a uniform distribution.

Rerunning the benchmarking tests indicates that truncating the buffer
increases the number of cycles require to log an event by only 1.6%.

Test: m libstatssocket_benchmark
Test: bit libstatssocket_benchmark:*
Change-Id: I8d5c1734861038beec8eeb7ce1f84a24bde25a75

2020-01-06 23:10:51 +00:00

Ruchir Rastogi

79dd3eaa87

Improve stats_event memory usage

We now truncate the buffer to the appropriate length when clients call
stats_event_build().

Benchmarking tests indicate that truncating the buffer to the
appropriate length increases the cost clients pay to write to the socket
by 2%. This is negligible enough that I decided to truncate the buffer
for both pushed and pulled atoms in order to simplify the API.

Test: m libstatssocket
Test: bit libstatssocket_benchmark:*
Bug: 144126231
Change-Id: I35dec748ff87c0821d0d06779a406997e6e64966
Merged-In: Ife976bb383ecff8de5064730692a95e2a3a82c9d

2019-12-18 17:44:26 -08:00

2 Commits