Commit Graph

3508 Commits

Author SHA1 Message Date
android-build-team Robot 9f801c2054 Make change and version bump to r_aml_300802900 for mainline module file: adb/apex/apex_manifest.json
Change-Id: Ibe5237d97cbd821ce052dbaa42c4974a55e6dd53
2020-06-27 03:30:07 +00:00
android-build-team Robot 340ad8a612 Make change and version bump to r_aml_300802800 for mainline module file: adb/apex/apex_manifest.json
Change-Id: Iffcf3b70c83e67142600fecf899d1d838cc40378
2020-06-26 03:15:15 +00:00
android-build-team Robot 9ccd27ecff Make change and version bump to r_aml_300802700 for mainline module file: adb/apex/apex_manifest.json
Change-Id: I789140f4f9a6e86e876485a988f66fa603952636
2020-06-25 03:20:03 +00:00
Josh Gao a5c24c323d adbd: check auth id.
When multiple auth requests come in (e.g. if someone connects over TCP
and USB, or if we send a USB request, and then kill adb and try again),
we need to disambiguate.

Bug: http://b/159061108
Test: manual
Change-Id: I0768dc3c1830456cb8cbd4395c23ef8f193cc420
2020-06-24 16:25:49 -07:00
android-build-team Robot 2a4f9a3faa Version bump to r_aml_300802600 [adb/apex/apex_manifest.json]
Change-Id: Ide7c0d333abd042892716facef373aa2ff3a5772
2020-06-24 16:53:22 +00:00
android-build-team Robot 5a073667df Make change and version bump to r_aml_300802500 for mainline module file: adb/apex/apex_manifest.json
Change-Id: I9f1cc1af57de4fbe2384577de2a9d90ee74ddb9c
2020-06-24 03:15:47 +00:00
android-build-team Robot f1db70008a Make change and version bump to r_aml_300802400 for mainline module file: adb/apex/apex_manifest.json
Change-Id: I6bd0d2709a2d06a7cc49c28ddbdf37b643af8e94
2020-06-23 03:15:35 +00:00
android-build-team Robot 56fa8079a1 Make change and version bump to r_aml_300802300 for mainline module file: adb/apex/apex_manifest.json
Change-Id: I007eb3724220351cd44183c1d4455b795c34220f
2020-06-22 03:15:28 +00:00
android-build-team Robot ff388b339d Make change and version bump to r_aml_300802200 for mainline module file: adb/apex/apex_manifest.json
Change-Id: I19f83a4b7dc4be37734945e9c1ee2bf0a676ae9a
2020-06-20 03:20:06 +00:00
android-build-team Robot 86c26e68fd Make change and version bump to r_aml_300802100 for mainline module file: adb/apex/apex_manifest.json
Change-Id: I59280498d251551e09708a21ec060d9640bb64e9
2020-06-19 07:16:03 +00:00
android-build-team Robot 6204414809 Make change and version bump to r_aml_300802000 for mainline module file: adb/apex/apex_manifest.json
Change-Id: I74a98a83b018b40df0711373ab9b5b7103d68836
2020-06-18 07:15:57 +00:00
android-build-team Robot 1687e42a75 Make change and version bump to r_aml_300801900 for mainline module file: adb/apex/apex_manifest.json
Change-Id: I6304f8f10109fbdb5ecedb9e829b3d6334a761ad
2020-06-17 19:56:28 +00:00
android-build-team Robot 2a613052e0 Make change and version bump to r_aml_300801800 for mainline module file: adb/apex/apex_manifest.json
Change-Id: I67412c29ed3bd211cd34196b5685d8750c37de6c
2020-06-17 07:17:09 +00:00
android-build-team Robot 157a105d46 Make change and version bump to r_aml_300801700 for mainline module file: adb/apex/apex_manifest.json
Change-Id: Ia721a85c7321b1316ef186221edd2f9f49c552f9
2020-06-16 07:15:04 +00:00
android-build-team Robot ec54be6082 Make change and version bump to r_aml_300801600 for mainline module file: adb/apex/apex_manifest.json
Change-Id: I85ad9bdcb8d2bb3a24e1664b9ba3280b1a540cb9
2020-06-15 07:15:15 +00:00
android-build-team Robot 42f32a6bd1 Make change and version bump to r_aml_300801500 for mainline module file: adb/apex/apex_manifest.json
Change-Id: Ic2c480c0922ac22ab9d2ef8420555d7722d6f2ab
2020-06-14 07:20:18 +00:00
android-build-team Robot f46bbc5609 Make change and version bump to r_aml_300801400 for mainline module file: adb/apex/apex_manifest.json
Change-Id: If42da0d917943a6f207d293e846f7fd6e94f1481
2020-06-12 07:20:00 +00:00
android-build-team Robot 3bb237b409 Make change and version bump to r_aml_300801300 for mainline module file: adb/apex/apex_manifest.json
Change-Id: I62b89c36bf58a535f519b32e62340be5a8aa1f1a
2020-06-11 07:14:55 +00:00
android-build-team Robot ee029c3028 Make change and version bump to r_aml_300801200 for mainline module file: adb/apex/apex_manifest.json
Change-Id: Iec096d5b01866095a23dcecd7fce8a581e0fedad
2020-06-10 07:15:19 +00:00
TreeHugger Robot ab7a967d1c Merge "adbd: remove ifdefs guarding root/secure." into rvc-dev 2020-06-09 21:42:05 +00:00
Josh Gao b6b70c23c9 adbd: remove ifdefs guarding root/secure.
The same adbd module prebuilt will get used for both user and userdebug
builds in the post-APEX world, so we can't guard functionality with
product variable ifdefs anymore.

The code that was previously compiled out runs before we drop root, so
the increased attack surface essentially consists of an attacker having
control over system properties, and that likely implies that we're
doomed already (either they have filesystem control, or they have code
execution in init).

Bug: http://b/158156979
Test: treehugger
Change-Id: Ia70d3140189e5212beb813ff719355e30ca5fa04
(cherry picked from commit d076857c4f)
2020-06-09 13:05:47 -07:00
android-build-team Robot 51dc7597bb Make change and version bump to r_aml_300801100 for mainline module file: adb/apex/apex_manifest.json
Change-Id: I1ce79b75b9069fd0aa5a337aa7d86159936e3a99
2020-06-09 07:15:41 +00:00
Josh Gao 0217d52d01 Move libadbd_auth, libadbd_fs to adbd_system_binaries.
The required block inside the definition of "adbd" does nothing: we get
the libraries it contains via direct dependency when building from
source, and not at all when using a prebuilt. Move them to a phony
rule that's explicitly listed in PRODUCT_PACKAGES.

Bug: http://b/157709367
Test: treehugger
Change-Id: I97c0889558482cfbe18ae91b39b6889d3fee877c
(cherry picked from commit e572f2fc44)
2020-06-08 21:24:26 +00:00
android-build-team Robot 4b1e2ec8fb Make change and version bump to r_aml_300801000 for mainline module file: adb/apex/apex_manifest.json
Change-Id: I4a8b369adf64c0ad9c7b8c1657c3ddd0d211c43e
2020-06-08 07:15:27 +00:00
android-build-team Robot 124e98a392 Make change and version bump to r_aml_300800800 for mainline module file: adb/apex/apex_manifest.json
Change-Id: I597fd46b14de4a3c56e88a982aa3f7b63ae3ffb3
2020-06-07 07:16:04 +00:00
android-build-team Robot b92540d372 Make change and version bump to r_aml_300800500 for mainline module file: adb/apex/apex_manifest.json
Change-Id: I7a1c00023f8f74601938400a19756b27214c578d
2020-06-05 16:29:33 +00:00
android-build-team Robot dfe888fd97 Make change and version bump to r_aml_300800400 for mainline module file: adb/apex/apex_manifest.json
Change-Id: I116f19c2a51422319f63eaf558b1254977aecb5d
2020-06-05 07:30:08 +00:00
android-build-team Robot f7fbd135ad Make change and version bump to r_aml_300800200 for mainline module file: adb/apex/apex_manifest.json
Change-Id: Ieaeb532bba164be995f2b6d34478ccfb771b859f
2020-06-04 21:51:12 +00:00
Josh Gao a311f7866f check_ms_os_desc: fix buffer overflow.
Bug: http://b/155505587
Test: check_ms_os_desc
Change-Id: Ie99715ab62571d24460c3a1fb859d22951f30cb8
Merged-In: Ie99715ab62571d24460c3a1fb859d22951f30cb8
2020-06-03 15:32:06 -07:00
TreeHugger Robot d4c8a20d4b Merge changes I1118f2e2,I6c039b32 into rvc-dev
* changes:
  adb: only submit USB writes on the worker thread.
  adbd: don't use libc++_static.
2020-05-27 05:15:55 +00:00
Josh Gao 6da375fdc9 adb: only submit USB writes on the worker thread.
After USB disconnection, io_submit will block until the endpoint comes
back up. We handle this in the worker thread by sending it a signal to
break it out of io_submit when we notice that USB has gone down, but
opportunistic writes from the main thread can get stuck in this scenario
as well. Submitting the writes only on the worker thread doesn't have a
measurable impact on performance, so avert this scenario by only
submitting writes from the worker thread.

Bug: http://b/157078255
Test: test_device.py
Change-Id: I1118f2e2a70d13f15592eb996e7084033ed5cb9d
(cherry picked from commit 962551000b)
2020-05-21 14:55:46 -07:00
Josh Gao 2081cf31b3 adbd: don't use libc++_static.
We have dependencies that use libc++_shared, which results in ODR
violation manifesting as host adbd crashing on launch in libc++ locale
initialization.

Bug: http://b/151056300
Test: adbd on host
Change-Id: I6c039b325308fb8c36dfe5c1d090ff4ebe9e3433
(cherry picked from commit d5d5ba1644)
2020-05-21 14:55:38 -07:00
Alex Buynytskyy 61f4ab89a2 Optimizing install-multi-package to use ABB.
Bug: 150803885
Test: atest adb_test adbd_test
Test: adb install-multi-package Picsart_9.30.5.apk Pinterest_6.54.0.apk
Change-Id: I2fcd093e61afdd16d481194e1d5f8f66acf6a66c
Merged-In: I2fcd093e61afdd16d481194e1d5f8f66acf6a66c
2020-05-19 04:26:42 +00:00
Alex Buynytskyy f1e187be01 Incremental install mode for install-multi.
Bug: 150803885
Test: atest adb_test adbd_test fastdeploy_test
Change-Id: I242104267273bac21ab41390d3e77a434ffa565d
Merged-In: I242104267273bac21ab41390d3e77a434ffa565d
2020-05-18 21:26:10 -07:00
Alex Buynytskyy 74e9e3c27a Passing additional flags to incremental installation.
Bug: 150803885
Test: atest adb_test adbd_test fastdeploy_test
Change-Id: Ifa9b9e570259d35eb0121817bbb791044c6efcfd
Merged-In: Ifa9b9e570259d35eb0121817bbb791044c6efcfd
2020-05-14 21:00:10 +00:00
Chen Zhu 8950624662 Merge "Add test config for adbd_test and apply MainlineTestModuleController to it" into rvc-dev 2020-05-09 02:48:48 +00:00
Chen Zhu 5daea5a6a2 Add test config for adbd_test and apply MainlineTestModuleController to it
to only run the tests when com.google.android.adbd is

installed on device.

Bug: 154845935
Test: m mts && mts-tradefed run mts-adbd
Change-Id: I2f203d25288580a07391703e2b28df54479a69f0
2020-05-08 16:47:07 -07:00
Alex Buynytskyy 13e98eaf72 Using ABB for install-multi.
ABB uses single shared CMD for all operations which improves
reliability.

Bug: b/153486595
Fixes: 153486595
Test: atest adb_test adbd_test fastdeploy_test
Change-Id: I1e3da63882c980811ed2e9f5556732b24a041ce5
Merged-In: I1e3da63882c980811ed2e9f5556732b24a041ce5
2020-05-06 14:10:56 -07:00
Greg Kaiser cb885c24fc adb: Avoid extra string construction
Bug: 150827486
Test: TreeHugger
Change-Id: Ie03062a17b98866f1bc419a7e509461cf4e6bb80
Merged-In: Ie03062a17b98866f1bc419a7e509461cf4e6bb80
2020-04-21 20:34:44 -07:00
Jiyong Park 132bb5f861 Merge changes from topic "apex_available" into rvc-dev
* changes:
  adbd: add apex_available and visibility for internal libs.
  Set apex_available property
  Set apex_available property
  Set apex_available property
  Set apex_available property
2020-04-21 03:15:39 +00:00
Joshua Duong aa0b72931d adb: change mdns tls service names (RFC 6763).
Even though mdnsresponder seems to allow us to use _adb_secure_connect
and _adb_secure_pairing as service names, these names violate the syntax
outlined in RFC6763, and may not be compatible with other dns-sd
implementations.

Also address some comments from a previous CL.

Bug: 154268895

Test: atest adbd_test
Change-Id: Ia872e976fc4276587b500a827a41d46d9dc755dd
Merged-In: Ia872e976fc4276587b500a827a41d46d9dc755dd
2020-04-20 21:03:15 +00:00
Josh Gao d11e67d88d adbd: add apex_available and visibility for internal libs.
abb links against libadbd_core for the shell protocol, and must be
on the system image because it links against cmd, so let's just
expose it to abb for now.

Exempt-From-Owner-Approval: cherry-pick from AOSP

Bug: http://b/151398197
Test: treehugger
Merged-In: Id926bc4324d3259def21ea19d3bd72320311a6e3
(cherry picked from commit b567303330)
Change-Id: Id926bc4324d3259def21ea19d3bd72320311a6e3
2020-04-20 17:21:22 +09:00
Jiyong Park 137fb1ff1e Set apex_available property
The marked library(ies) were available to the adbd APEX via the
hand-written whitelist in build/soong/apex/apex.go. Trying to remove the
whitelist by adding apex_available property to the Android.bp of the
libraries.

Exempt-From-Owner-Approval: already +2'ed by the owner (enh)

Bug: 150999716
Bug: 151398197
Test: m
Merged-In: I8b572e3c4e76bd10c0443a6c08b72e9519243ab5
(cherry picked from commit d25bb60e05)
Change-Id: I8b572e3c4e76bd10c0443a6c08b72e9519243ab5
2020-04-20 16:07:35 +09:00
Elliott Hughes 44daa2dde1 macOS build fix: no off64_t on darwin.
Darwin has always had a 64-bit off_t, and never added an off64_t.

Bug: 153328340
Test: builds on mac
Change-Id: I4b244dda94c67da76c9e0f47b333c2734f5a94af
2020-04-17 10:17:02 +00:00
Elliott Hughes e2bd0f0f6d Add missing `static` for macOS inline.
Also switch to #pragma once and s/__inline__/inline/g for consistency.

There are a handful of inlines that are missing static, which seems like
a bug, but I've left those for now.

Bug: http://b/153328340
Test: treehugger
Change-Id: I2353215c0a8a6154ce8b39ecde022b282f5c0cb9
Merged-In: I2353215c0a8a6154ce8b39ecde022b282f5c0cb9
(cherry picked from commit 681338dfb6)
2020-04-13 17:17:31 -07:00
Alex Buynytskyy e2e850f325 [incfs] Stream the hash tree for incremental installation
Instead of sending the whole tree upfront use the same
streaming interface for it as for the data blocks

This improves installation speed by almost 200ms,
650-800ms -> 500-600ms

Bug: 153696423
Test: manual, adb install in various configurations

Change-Id: Ia83de2af54ca0b1969397514ea5d761719af9055
2020-04-10 14:45:51 -07:00
Josh Gao b3b43be658 Revert "Reland "adb: daemon: Assign valid fd to usb_handle ep0 file descriptor""
This reverts commit d9684d5943.

This seems to be correlated with an increase in the rate of devices
going offline. Revert it to see if failure rates improve.

Bug: http://b/150863651
Test: treehugger
Change-Id: Ia6163fd9e31d2bf812628e028249662594ac2024
2020-04-06 16:48:35 -07:00
Jooyung Han a05e2b1a92 Merge "Add min_sdk_version:R to updatable apexes" into rvc-dev 2020-04-05 00:14:36 +00:00
Josh Gao d527ae40dc Merge "adb: add implementation of mempcpy for deficient platforms." into rvc-dev 2020-04-04 06:45:09 +00:00
Josh Gao fbf30e4155 adb: add implementation of mempcpy for deficient platforms.
Bug: http://b/150827486
Test: none
Change-Id: Ic2f4e1c85c9f02e804d849c6cb60b22e15e981d6
(cherry picked from commit 0aafa0f714)
2020-04-03 12:18:29 -07:00